From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A79C433ED for ; Sun, 16 May 2021 10:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C19C861164 for ; Sun, 16 May 2021 10:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbhEPLAz (ORCPT ); Sun, 16 May 2021 07:00:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhEPLAw (ORCPT ); Sun, 16 May 2021 07:00:52 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EECEC061573 for ; Sun, 16 May 2021 03:59:37 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id x188so3049901pfd.7 for ; Sun, 16 May 2021 03:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4GxSFPpWStKHjj7EXT1jNvKcDZSOJF70aqfxoCB02kY=; b=Cpy1ZhzNx1aXXw3LdrNWLhQV74sEFSo4yuPbZKep5yiUfJ7jFrzsL2A7fwWfhE6lWS /KSnKu0QTHLxD3kyOFX9a2EalkBpWDdhslf7K6x7qt3tcIXgOqFK4uChKM+J4xhZrLnS bYcuqmCK/DTMUUwmoOFvd80zHMnPJlCBJp5jw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4GxSFPpWStKHjj7EXT1jNvKcDZSOJF70aqfxoCB02kY=; b=A4pft2LTIzEEa4SpBYrjJ+wcoP6uBEkqteJ9KcVfmIcO0E8WGB1tR4PIg5nHZNKFHN 4XE1Rgk7i8TyJcDEV0KlWJziwMeJXgN9o0yaFGqstRXWKlwt4A0ZZGcm+2R6GvYCr8FQ anKl1SgOiTCUzdiMk6aIyZDV4f2DIa28iP7TSRp4Inv0eygXRR9pzeQaf79tQ8CiANlW 5Yk7k4iJNeg31QZ7Q9VEXhYF4z8ka8ofUQOars8G9LyRXX82u+bWmj2UnYc2NKjvfosd IYoKUo4zxVYfrZny79ey202QOV6X3cgs8AhTodQJte14bfcb+B/bsdnc6T46FFnX466c AZ3A== X-Gm-Message-State: AOAM531OqUL3y1YsbAFK9TRkeGWxP1YUXST2Y+W42Jl56NynqzxwQqC8 Lk9g7mm5TWRgPvFJOX3ko5c0LA== X-Google-Smtp-Source: ABdhPJzQJp5Q3my2xZ7H1eLd22WRM8iYd4u+a0Zh7oLI6yZH3geaz4ojkhR6TlZ63R3BXwn99le9yA== X-Received: by 2002:aa7:88c9:0:b029:2ab:aea7:e761 with SMTP id k9-20020aa788c90000b02902abaea7e761mr45338082pff.71.1621162776789; Sun, 16 May 2021 03:59:36 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:4596:acad:c782:2f52]) by smtp.gmail.com with ESMTPSA id z5sm5077648pfa.172.2021.05.16.03.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 03:59:36 -0700 (PDT) Date: Sun, 16 May 2021 19:59:31 +0900 From: Sergey Senozhatsky To: Takashi Iwai Cc: Sergey Senozhatsky , Jaroslav Kysela , Takashi Iwai , "Gustavo A. R. Silva" , Leon Romanovsky , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/05/16 11:49), Takashi Iwai wrote: > Subject: [PATCH] ALSA: intel8x0: Don't update period unless prepared > > The interrupt handler of intel8x0 calls snd_intel8x0_update() whenever > the hardware sets the corresponding status bit for each stream. This > works fine for most cases as long as the hardware behaves properly. > But when the hardware gives a wrong bit set, this leads to a NULL > dereference Oops, and reportedly, this seems what happened on a VM. > > For fixing the crash, this patch adds a internal flag indicating that > the stream is ready to be updated, and check it (as well as the flag > being in suspended) to ignore such spurious update. > > Cc: > Reported-by: Sergey Senozhatsky > Signed-off-by: Takashi Iwai I kicked the tests. Will let you know. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389FFC433B4 for ; Sun, 16 May 2021 11:00:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7726561164 for ; Sun, 16 May 2021 11:00:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7726561164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0238D1699; Sun, 16 May 2021 12:59:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0238D1699 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621162840; bh=NaKCo3cvEd2Vzbel/pGGkJh5gcqTEUZ0t8adAJDQ6Ec=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Yy5j6doIJZdi6wBRfrDhtXSYgjZR7PhwZw+kIxQ3YlQVEpwta6FFxM0jV90o5Svrw 2LzNgDHcAerXQl5Fx074iUPAZho7ESaJG//iJ156eVvhqudt6oo9nRk2uejI3OL9w1 o1AOhnXYRuXt/HWiL2+/PLl7rp4csr32vgqvdY3E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 763B0F801DB; Sun, 16 May 2021 12:59:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 511FCF80217; Sun, 16 May 2021 12:59:47 +0200 (CEST) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F0C0EF8016E for ; Sun, 16 May 2021 12:59:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F0C0EF8016E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Cpy1ZhzN" Received: by mail-pf1-x434.google.com with SMTP id h127so3040502pfe.9 for ; Sun, 16 May 2021 03:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4GxSFPpWStKHjj7EXT1jNvKcDZSOJF70aqfxoCB02kY=; b=Cpy1ZhzNx1aXXw3LdrNWLhQV74sEFSo4yuPbZKep5yiUfJ7jFrzsL2A7fwWfhE6lWS /KSnKu0QTHLxD3kyOFX9a2EalkBpWDdhslf7K6x7qt3tcIXgOqFK4uChKM+J4xhZrLnS bYcuqmCK/DTMUUwmoOFvd80zHMnPJlCBJp5jw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4GxSFPpWStKHjj7EXT1jNvKcDZSOJF70aqfxoCB02kY=; b=CmvInCTHUgjM1F0/bry4VpLy7eOpirojDJ290xOR8vRk8BJZ8FcC4A/OO+EpWgm0zL 2ipiRK4V/O07QVK3qUQxcWM5fxi7jFwCF+BWORMqxPQc2RiK1h8C/IRsJjnLNmX0cEcC Idd6kRsNnCzj6KXE8nhBiHw+PGB9kbLdUbtxj0uySfhBm/H+OX/pMS8AO/RcR9nq4AOq FnHBgROIjkeyWsSfR8piopVLsIECbb7Ds9IpsT1WRb0StCD7KZ2n/YgtKeCoeVtKH0/R TvfX0PdqMBgT8PvqsrAuNrNRv2z9VByjxVQuzPjSuAW7Yv8PI+Ay7yZvd07gN5Hg/00H lvaQ== X-Gm-Message-State: AOAM532vCX+JN9JZaC7l/sudcuWxey+yzwwKrq7Ja1pm5fHaUNRP5TmG JR8tDOZtOEKtjTuUXQlWRJR10A== X-Google-Smtp-Source: ABdhPJzQJp5Q3my2xZ7H1eLd22WRM8iYd4u+a0Zh7oLI6yZH3geaz4ojkhR6TlZ63R3BXwn99le9yA== X-Received: by 2002:aa7:88c9:0:b029:2ab:aea7:e761 with SMTP id k9-20020aa788c90000b02902abaea7e761mr45338082pff.71.1621162776789; Sun, 16 May 2021 03:59:36 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:4596:acad:c782:2f52]) by smtp.gmail.com with ESMTPSA id z5sm5077648pfa.172.2021.05.16.03.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 03:59:36 -0700 (PDT) Date: Sun, 16 May 2021 19:59:31 +0900 From: Sergey Senozhatsky To: Takashi Iwai Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, Leon Romanovsky , linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Takashi Iwai , Sergey Senozhatsky X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On (21/05/16 11:49), Takashi Iwai wrote: > Subject: [PATCH] ALSA: intel8x0: Don't update period unless prepared > > The interrupt handler of intel8x0 calls snd_intel8x0_update() whenever > the hardware sets the corresponding status bit for each stream. This > works fine for most cases as long as the hardware behaves properly. > But when the hardware gives a wrong bit set, this leads to a NULL > dereference Oops, and reportedly, this seems what happened on a VM. > > For fixing the crash, this patch adds a internal flag indicating that > the stream is ready to be updated, and check it (as well as the flag > being in suspended) to ignore such spurious update. > > Cc: > Reported-by: Sergey Senozhatsky > Signed-off-by: Takashi Iwai I kicked the tests. Will let you know.