From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F9FC433B4 for ; Sun, 16 May 2021 08:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3FBD61168 for ; Sun, 16 May 2021 08:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234197AbhEPIdD (ORCPT ); Sun, 16 May 2021 04:33:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbhEPIdC (ORCPT ); Sun, 16 May 2021 04:33:02 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170A2C061573 for ; Sun, 16 May 2021 01:31:47 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id lj11-20020a17090b344bb029015bc3073608so2106920pjb.3 for ; Sun, 16 May 2021 01:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JvPi/up8/Q2jB6nmPheLInSV8cVD1xDyiACL39QHuIM=; b=mi1CkwraEzqq7EM0mHtQ8oepYHvCEEXP8ciKdlDvLqraGMF4pWHpbIIs3J3iS2jTQY lvaXlVy7Dtd13AVtl9UjTXZfdLGzcX1xj4U6U7yl0U/9DWOwau3qNICtxn/xhXAhK5fT 2CGr44oH7N9qjbcQmLI/tSHzFPaW975IJ553s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JvPi/up8/Q2jB6nmPheLInSV8cVD1xDyiACL39QHuIM=; b=Q++UZEWjobs080PxrhADcD9Dc90htuxi6x/BJVZnFFjtSSATdBIzq+QYaCTbQSuIJL GJRBbnc2qdL3ILJq5nvzId1cKSNYVELsamY6d0OHXeG060nt4hlzd3j0uFo4it0BcJm/ T5F0ABnbzmdWENRwHNR6pzG2OXtueQ084RpAM0IQytaHfkZ4lx3QdmECNLoVS06jHMXJ WDpEdFfhF3f1txByF1m0EMCBdoBo2Ymtu/rP+k4YbB3cw7l+vI6qDKtOu862B0ALnCmx uZzO+hfitDsECXGhbLr+VNlwlf1HmPJJ4gINLjYeuBd4UC0lXr1az8azug1oTOpVfQl4 y9wQ== X-Gm-Message-State: AOAM532TcWIq13U+EM3MHgIr/wau0hp/wDKqae9UkceeK6ws6rSOBA2t Aue7uCfNucQRaMvPmKWaLOWq5w== X-Google-Smtp-Source: ABdhPJw/afxurF3CFS9XitDbZWTdJj6qhpYvwmCjSbZfQdzJa9IROBfg2+2roWy11BdpOHVzJ6KBRA== X-Received: by 2002:a17:90a:690d:: with SMTP id r13mr20761076pjj.19.1621153906716; Sun, 16 May 2021 01:31:46 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:4596:acad:c782:2f52]) by smtp.gmail.com with ESMTPSA id a16sm7328843pfc.37.2021.05.16.01.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 01:31:46 -0700 (PDT) Date: Sun, 16 May 2021 17:31:41 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Cc: Takashi Iwai , Jaroslav Kysela , Takashi Iwai , "Gustavo A. R. Silva" , Leon Romanovsky , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/05/16 17:30), Sergey Senozhatsky wrote: > On (21/05/14 20:16), Sergey Senozhatsky wrote: > > > --- a/sound/pci/intel8x0.c > > > +++ b/sound/pci/intel8x0.c > > > @@ -691,6 +691,9 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > > > int status, civ, i, step; > > > int ack = 0; > > > > > > + if (!ichdev->substream || ichdev->suspended) > > > + return; > > > + > > > spin_lock_irqsave(&chip->reg_lock, flags); > > > status = igetbyte(chip, port + ichdev->roff_sr); > > > civ = igetbyte(chip, port + ICH_REG_OFF_CIV); > > This does the problem for me. ^^^ does fix From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09069C433B4 for ; Sun, 16 May 2021 08:32:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D446B61177 for ; Sun, 16 May 2021 08:32:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D446B61177 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C363416B9; Sun, 16 May 2021 10:32:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C363416B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621153971; bh=0T3Or1eX4zP1vsuQZsXnHre4xuJ4rFQuxxjHGCiuWwQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NyUEVRYkuzvuDW/OtFVyK/ItPOWGCIyxZF4xjM9KQWFzyocIeTOe3iFg4iP052s+e U2lCZB9WT9fHg96Fry4vsVbh1GGrh6+JcUNF3pVrHOs5s4+Hv4KG4/rYv+09Z5BYKk Jkf2iKl9qMmOSDkaaew40pJLCxNjp7lSBCgV+VoU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 44B71F80257; Sun, 16 May 2021 10:31:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE8E4F80272; Sun, 16 May 2021 10:31:52 +0200 (CEST) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4DACBF8012C for ; Sun, 16 May 2021 10:31:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4DACBF8012C Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mi1Ckwra" Received: by mail-pj1-x1035.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so2115693pjv.1 for ; Sun, 16 May 2021 01:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JvPi/up8/Q2jB6nmPheLInSV8cVD1xDyiACL39QHuIM=; b=mi1CkwraEzqq7EM0mHtQ8oepYHvCEEXP8ciKdlDvLqraGMF4pWHpbIIs3J3iS2jTQY lvaXlVy7Dtd13AVtl9UjTXZfdLGzcX1xj4U6U7yl0U/9DWOwau3qNICtxn/xhXAhK5fT 2CGr44oH7N9qjbcQmLI/tSHzFPaW975IJ553s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JvPi/up8/Q2jB6nmPheLInSV8cVD1xDyiACL39QHuIM=; b=Q4Eid4o8EF9cOPn3gsKYrohb4lemIwr6tWg4ElbeE72T2tJVkRqSpAnQ0sFo/b75OE GW0QAbAZ+0iHNQU7UvOPb4R6gF+oMqDZYl2LEku73Z19MFoAJfg1Nmz3phcX/FVdqasR /Gdek3qZ4jFhpVyTZlK/5V4OeWCfvll4ApGYOXOGWXGUhxjYjAP8pPbmVW9RPAi9vv0R aXQ91Gs9m1gauDW/o6Rhy5+vNLcn0g8dznSkJQ7SwIRrtIvz3FbXSdi21w1FLY8LpY56 NPhhgEVIobV8NgVhF30le/KbrtNL93/ej1ZyHd34WHwOfi/NWVcgeNXfhlc52WJAkDrR RRSQ== X-Gm-Message-State: AOAM530tRwggzkCoYkvRnGsWQy3pT6JdYG5+ZbhtAqsIe1D9Dix3LyhE uI9WMWN8hQ4and0urEIE3+OGZw== X-Google-Smtp-Source: ABdhPJw/afxurF3CFS9XitDbZWTdJj6qhpYvwmCjSbZfQdzJa9IROBfg2+2roWy11BdpOHVzJ6KBRA== X-Received: by 2002:a17:90a:690d:: with SMTP id r13mr20761076pjj.19.1621153906716; Sun, 16 May 2021 01:31:46 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:4596:acad:c782:2f52]) by smtp.gmail.com with ESMTPSA id a16sm7328843pfc.37.2021.05.16.01.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 01:31:46 -0700 (PDT) Date: Sun, 16 May 2021 17:31:41 +0900 From: Sergey Senozhatsky To: Sergey Senozhatsky Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, Leon Romanovsky , Takashi Iwai , linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On (21/05/16 17:30), Sergey Senozhatsky wrote: > On (21/05/14 20:16), Sergey Senozhatsky wrote: > > > --- a/sound/pci/intel8x0.c > > > +++ b/sound/pci/intel8x0.c > > > @@ -691,6 +691,9 @@ static inline void snd_intel8x0_update(struct intel8x0 *chip, struct ichdev *ich > > > int status, civ, i, step; > > > int ack = 0; > > > > > > + if (!ichdev->substream || ichdev->suspended) > > > + return; > > > + > > > spin_lock_irqsave(&chip->reg_lock, flags); > > > status = igetbyte(chip, port + ichdev->roff_sr); > > > civ = igetbyte(chip, port + ICH_REG_OFF_CIV); > > This does the problem for me. ^^^ does fix