From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA355C433B4 for ; Sun, 16 May 2021 12:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9621610F7 for ; Sun, 16 May 2021 12:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233422AbhEPM5G (ORCPT ); Sun, 16 May 2021 08:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbhEPM5F (ORCPT ); Sun, 16 May 2021 08:57:05 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E73C061573 for ; Sun, 16 May 2021 05:55:51 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id l70so2842061pga.1 for ; Sun, 16 May 2021 05:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZxcBGrT6Kyw/+duJ+BUSdpPCJHKScouIvkGJ8rV7HfI=; b=U7x3BfjBpTAKts9FEMf8K29lMBLNInANLuYCvw9ZMoG5tfsIVytInnUkmLdqo5FO/q GcQGQmK0d+FLzMEuXhCaOgJeqSddjApL8ZcIvygk7vjH9ypviy413lXoFiXf+jNPPwRB XHP3IE9eUmqkK8mpdWq3T8DT0r+mwXPzXxvwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZxcBGrT6Kyw/+duJ+BUSdpPCJHKScouIvkGJ8rV7HfI=; b=GKTo+DB7Kt2zFz3tncDTuaqOp6iSVfYrTvdkJYCzDCJ/C1qkB6VNPxQijY30o6JVRq JMuZcaMfR2nfK0ksHFlE7NrYzKabcXaqwliHdQiH9zbjOZ7cXhwS6JYQlOvb7PFpdcUp Zi2KU/WFfvjbSlGL0SmMuJin5p11fyEwaZf77+FDOcF0FxL4EF0mG1HnwGX2yFx/R8jj bMQ6ywBPBzaXVlHYv/VOuqIF9TvEgTl39DA/t0YSgjfCAQAJVhIOGBhEgAb8EmVSZA1a 9CD9LK/6qIh9np7RkxIt1v8RFifhrlZ6FlA7hR3t+1tw8+ZL02v4WJbnb+8SDrCfu4A+ JZmQ== X-Gm-Message-State: AOAM532xy6yYDM12vVt51x2eLzJRLsww5I9cDIGvy7w6DzV1aQOOm3Za g2k9x7yrw9KmH7EYFSVB6K/x/Q== X-Google-Smtp-Source: ABdhPJwBSVlfoJv9AlafwzBVQ170xi4hh/0woJXOQkdsUBMyXrxu/TCRP/+JGLPdo9R5VbUN9J8B3A== X-Received: by 2002:a63:af57:: with SMTP id s23mr4519959pgo.393.1621169750516; Sun, 16 May 2021 05:55:50 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:4596:acad:c782:2f52]) by smtp.gmail.com with ESMTPSA id 187sm7572024pff.139.2021.05.16.05.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 05:55:49 -0700 (PDT) Date: Sun, 16 May 2021 21:55:45 +0900 From: Sergey Senozhatsky To: Takashi Iwai Cc: Sergey Senozhatsky , Jaroslav Kysela , Takashi Iwai , "Gustavo A. R. Silva" , Leon Romanovsky , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/05/16 14:07), Takashi Iwai wrote: > > > For fixing the crash, this patch adds a internal flag indicating that > > > the stream is ready to be updated, and check it (as well as the flag > > > being in suspended) to ignore such spurious update. > > > > I reproduced the "spurious IRQ" case, and the patch handled it correctly > > (VM did not crash). > > > > > Cc: > > > Reported-by: Sergey Senozhatsky > > > Signed-off-by: Takashi Iwai > > > > I'll keep running test, but seems that it works as intended > > > > Tested-by: Sergey Senozhatsky > > OK, below is the revised patch I'm going to apply. > Sounds good. > Thanks! Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DABDC433B4 for ; Sun, 16 May 2021 12:56:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 851D061176 for ; Sun, 16 May 2021 12:56:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 851D061176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4AC9A16A1; Sun, 16 May 2021 14:56:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4AC9A16A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621169814; bh=Q7bQUno3qBWuOvh+/in0lBItriONMrX4nK06EMS3dH4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H2m4kd/eH+NDvSzoBKxnS9hHQLSM+XWA63TQh4hS9ZB79ralg9lCGnd0AingP3KjZ 4pBbRnEvm6T+CJOf4SdJWs52xLLpF/q7b8zE5n23WlQ7OOXPakAnKFSZK1Hi576Nna 7RQqRA0pW7xOfiwG2/mqCKR0wDtJDmwZc7JvRmNs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C4989F8013A; Sun, 16 May 2021 14:56:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 437E3F80217; Sun, 16 May 2021 14:56:02 +0200 (CEST) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B5AB4F8013A for ; Sun, 16 May 2021 14:55:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B5AB4F8013A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="U7x3BfjB" Received: by mail-pg1-x52c.google.com with SMTP id m190so2840884pga.2 for ; Sun, 16 May 2021 05:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZxcBGrT6Kyw/+duJ+BUSdpPCJHKScouIvkGJ8rV7HfI=; b=U7x3BfjBpTAKts9FEMf8K29lMBLNInANLuYCvw9ZMoG5tfsIVytInnUkmLdqo5FO/q GcQGQmK0d+FLzMEuXhCaOgJeqSddjApL8ZcIvygk7vjH9ypviy413lXoFiXf+jNPPwRB XHP3IE9eUmqkK8mpdWq3T8DT0r+mwXPzXxvwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZxcBGrT6Kyw/+duJ+BUSdpPCJHKScouIvkGJ8rV7HfI=; b=tMXCJwZpL3b7+V5XpAEfoDp+b5LeNUksQ3wwtqXMEPTG5QUIfh/PzvXmWERC42HWcz NbLQilpDttjgTS1wPhninfcjJolQa2jEgLvf3twMdsjVQRCB4y+d2PK27Hr8YQRi6Fy3 B1Fqkhhbwhin56V9iSA/Nvta9k3NScFFgIcLXqE3lcuWIaP/ONc2uGJ7Aq9D5EWsdhzp 4X2g/VI1Ly1URg5a97iUfZqdvgYEiZZeukTP7zkJuMrVfu83ihYFBjNvyO+cUnU2ayBz 61PZATCPIj18Tu8EKRWCdXqn58LBY8bGJ9RoxOk8pbfKJK6dy6WbCcvJGFffo89B6IPC 1/LQ== X-Gm-Message-State: AOAM532ffhUtzOkEBoI8gz7YtiqTFaAefkQQWkGEZnvq6EhjWsS29wgq LEwg0L2nyq+oatnvGoQK8JZc4xU7r0hOpg== X-Google-Smtp-Source: ABdhPJwBSVlfoJv9AlafwzBVQ170xi4hh/0woJXOQkdsUBMyXrxu/TCRP/+JGLPdo9R5VbUN9J8B3A== X-Received: by 2002:a63:af57:: with SMTP id s23mr4519959pgo.393.1621169750516; Sun, 16 May 2021 05:55:50 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:4596:acad:c782:2f52]) by smtp.gmail.com with ESMTPSA id 187sm7572024pff.139.2021.05.16.05.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 May 2021 05:55:49 -0700 (PDT) Date: Sun, 16 May 2021 21:55:45 +0900 From: Sergey Senozhatsky To: Takashi Iwai Subject: Re: ALSA: intel8x0: div by zero in snd_intel8x0_update() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, Leon Romanovsky , linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Takashi Iwai , Sergey Senozhatsky X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On (21/05/16 14:07), Takashi Iwai wrote: > > > For fixing the crash, this patch adds a internal flag indicating that > > > the stream is ready to be updated, and check it (as well as the flag > > > being in suspended) to ignore such spurious update. > > > > I reproduced the "spurious IRQ" case, and the patch handled it correctly > > (VM did not crash). > > > > > Cc: > > > Reported-by: Sergey Senozhatsky > > > Signed-off-by: Takashi Iwai > > > > I'll keep running test, but seems that it works as intended > > > > Tested-by: Sergey Senozhatsky > > OK, below is the revised patch I'm going to apply. > Sounds good. > Thanks! Thank you.