From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E79470 for ; Mon, 17 May 2021 08:20:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8F6BD60C3D; Mon, 17 May 2021 08:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621239604; bh=jQEQ7PpbzLvBN7FZBkkzLqlizTBIfqJ/Z60sV9hQdlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RaGuDfWGUMSDbEUQvxhJL0zEuVPFpjcqDWMtGFn4+pvOgk2azBgCWwfS3Hxhp/+UG g51WZN3430KZEO+N9c5rKUZkpeLv4J4thomaAEu/IkQEyIgUSiGVhAO6Bcc3wQbC9K SxtsLnOV87xr9eVUtW8Fz1IXAhdbGiENaDSnDOOQ= Date: Mon, 17 May 2021 10:20:01 +0200 From: Greg KH To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Pavel Machek , Mauro Carvalho Chehab , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 01/17] staging: add support for NUC WMI LEDs Message-ID: References: <7cec257fcc6e5789e5620495674e442a727a766f.1621161037.git.mchehab+huawei@kernel.org> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cec257fcc6e5789e5620495674e442a727a766f.1621161037.git.mchehab+huawei@kernel.org> On Sun, May 16, 2021 at 12:53:29PM +0200, Mauro Carvalho Chehab wrote: > Some Intel Next Unit of Computing (NUC) machines have > software-configured LEDs that can be used to display a > variety of events: > > - Power State > - HDD Activity > - Ethernet > - WiFi > - Power Limit One nit: > +static void nuc_wmi_remove(struct wmi_device *wdev) > +{ > + struct device *dev = &wdev->dev; > + > + dev_info(dev, "NUC WMI driver removed.\n"); > +} Drivers, when working properly, should be quiet. No need for noisy stuff like this, it just slows down booting/loading for everyone. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F73C433ED for ; Mon, 17 May 2021 08:20:11 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E832610A1 for ; Mon, 17 May 2021 08:20:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E832610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 47253401A4; Mon, 17 May 2021 08:20:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jQXtCY_gidX9; Mon, 17 May 2021 08:20:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 5A4ED40233; Mon, 17 May 2021 08:20:07 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 451931BF354 for ; Mon, 17 May 2021 08:20:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 34C3B60784 for ; Mon, 17 May 2021 08:20:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=linuxfoundation.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W_4FZWJS9lOn for ; Mon, 17 May 2021 08:20:04 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5FD7E60683 for ; Mon, 17 May 2021 08:20:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8F6BD60C3D; Mon, 17 May 2021 08:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621239604; bh=jQEQ7PpbzLvBN7FZBkkzLqlizTBIfqJ/Z60sV9hQdlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RaGuDfWGUMSDbEUQvxhJL0zEuVPFpjcqDWMtGFn4+pvOgk2azBgCWwfS3Hxhp/+UG g51WZN3430KZEO+N9c5rKUZkpeLv4J4thomaAEu/IkQEyIgUSiGVhAO6Bcc3wQbC9K SxtsLnOV87xr9eVUtW8Fz1IXAhdbGiENaDSnDOOQ= Date: Mon, 17 May 2021 10:20:01 +0200 From: Greg KH To: Mauro Carvalho Chehab Subject: Re: [PATCH 01/17] staging: add support for NUC WMI LEDs Message-ID: References: <7cec257fcc6e5789e5620495674e442a727a766f.1621161037.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7cec257fcc6e5789e5620495674e442a727a766f.1621161037.git.mchehab+huawei@kernel.org> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-staging@lists.linux.dev, linuxarm@huawei.com, linux-kernel@vger.kernel.org, Pavel Machek , mauro.chehab@huawei.com, Mauro Carvalho Chehab , linux-leds@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, May 16, 2021 at 12:53:29PM +0200, Mauro Carvalho Chehab wrote: > Some Intel Next Unit of Computing (NUC) machines have > software-configured LEDs that can be used to display a > variety of events: > > - Power State > - HDD Activity > - Ethernet > - WiFi > - Power Limit One nit: > +static void nuc_wmi_remove(struct wmi_device *wdev) > +{ > + struct device *dev = &wdev->dev; > + > + dev_info(dev, "NUC WMI driver removed.\n"); > +} Drivers, when working properly, should be quiet. No need for noisy stuff like this, it just slows down booting/loading for everyone. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel