From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21FA470 for ; Mon, 17 May 2021 09:08:56 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 41DC0611C2; Mon, 17 May 2021 09:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621242535; bh=BRGz+Os9JiMGd3fXuweYLwu0b6U6pfMRs8vms0cIF4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuzGYw8ynk+yr0zyDt1Tw3qHniQtoVCQChSHu55WUnSsIdQEpfp8wwSjt5/Wq1aFr vMcYJ1luC8jDU+WGxBKnx8CfBA14UIZgbUt2dFLF0DB9yIIJfrVkfdIDXlug7B6OJW Yi+sdwd2ctRqyhLWDlPuozfr3xIVCVJFF6T4na80= Date: Mon, 17 May 2021 11:08:53 +0200 From: Greg KH To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Pavel Machek , linux-leds@vger.kernel.org, Mauro Carvalho Chehab , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 00/17] Add an experimental driver for Intel NUC leds Message-ID: References: <20210517110258.341da12c@coco.lan> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517110258.341da12c@coco.lan> On Mon, May 17, 2021 at 11:02:58AM +0200, Mauro Carvalho Chehab wrote: > Em Mon, 17 May 2021 10:18:57 +0200 > Greg KH escreveu: > > > On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote: > > > Hi Greg, > > > > > > This series add support for the LEDs found at Intel NUCs since > > > NUC version 6. > > > > > > On several NUC models, the function of the LEDs are programmable, > > > which allow them to indicate several different hardware events. > > > > > > They can even be programmed to represent an userspace-driven event. > > > > > > Some models come with single colored or dual-colored LEDs, but > > > high end models have RGB LEDs. > > > > > > Programming them can ether be done via BIOS or by the OS. > > > > > > There are 3 different API types, and there is already some OOT > > > drivers that were written to support them, using procfs, each > > > one using a different (and IMO confusing) API. > > > > > > After looking at the existing drivers and not liking the uAPI > > > interfaces there, I opted to write a new driver from scratch, > > > unifying support for all different versions and using sysfs > > > via the leds class. > > > > Just do this the "right way" and not add it to staging first. Just use > > the existing LED class apis and all should be fine, no need for doing > > anything unusual here. > > I'm using the standard LED class already (but not triggers), and the > standard WMI support. > > Still, this API is complex, as it controls the LED behavior even when > the machine is suspended. I would feel more comfortable if the ABI > is not set into a stone at the beginning. code in drivers/staging/ does not mean that you can mess with the userspace api at will. It still follows the same "rules" of any other kernel code when it comes to that. So just work with the LED developers to come to a valid api that works properly within that framework please. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 116C7C433ED for ; Mon, 17 May 2021 09:09:03 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4B64611CC for ; Mon, 17 May 2021 09:09:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4B64611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7431E60586; Mon, 17 May 2021 09:09:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xu0iBeyIAr5w; Mon, 17 May 2021 09:09:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 62B33605A0; Mon, 17 May 2021 09:09:01 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 06D361BF35B for ; Mon, 17 May 2021 09:09:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 03032400F6 for ; Mon, 17 May 2021 09:09:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=linuxfoundation.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id COisbYqzkDns for ; Mon, 17 May 2021 09:08:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1E79D401A4 for ; Mon, 17 May 2021 09:08:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 41DC0611C2; Mon, 17 May 2021 09:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621242535; bh=BRGz+Os9JiMGd3fXuweYLwu0b6U6pfMRs8vms0cIF4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YuzGYw8ynk+yr0zyDt1Tw3qHniQtoVCQChSHu55WUnSsIdQEpfp8wwSjt5/Wq1aFr vMcYJ1luC8jDU+WGxBKnx8CfBA14UIZgbUt2dFLF0DB9yIIJfrVkfdIDXlug7B6OJW Yi+sdwd2ctRqyhLWDlPuozfr3xIVCVJFF6T4na80= Date: Mon, 17 May 2021 11:08:53 +0200 From: Greg KH To: Mauro Carvalho Chehab Subject: Re: [PATCH 00/17] Add an experimental driver for Intel NUC leds Message-ID: References: <20210517110258.341da12c@coco.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210517110258.341da12c@coco.lan> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-staging@lists.linux.dev, linuxarm@huawei.com, linux-kernel@vger.kernel.org, Pavel Machek , mauro.chehab@huawei.com, Mauro Carvalho Chehab , linux-leds@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, May 17, 2021 at 11:02:58AM +0200, Mauro Carvalho Chehab wrote: > Em Mon, 17 May 2021 10:18:57 +0200 > Greg KH escreveu: > > > On Sun, May 16, 2021 at 12:53:28PM +0200, Mauro Carvalho Chehab wrote: > > > Hi Greg, > > > > > > This series add support for the LEDs found at Intel NUCs since > > > NUC version 6. > > > > > > On several NUC models, the function of the LEDs are programmable, > > > which allow them to indicate several different hardware events. > > > > > > They can even be programmed to represent an userspace-driven event. > > > > > > Some models come with single colored or dual-colored LEDs, but > > > high end models have RGB LEDs. > > > > > > Programming them can ether be done via BIOS or by the OS. > > > > > > There are 3 different API types, and there is already some OOT > > > drivers that were written to support them, using procfs, each > > > one using a different (and IMO confusing) API. > > > > > > After looking at the existing drivers and not liking the uAPI > > > interfaces there, I opted to write a new driver from scratch, > > > unifying support for all different versions and using sysfs > > > via the leds class. > > > > Just do this the "right way" and not add it to staging first. Just use > > the existing LED class apis and all should be fine, no need for doing > > anything unusual here. > > I'm using the standard LED class already (but not triggers), and the > standard WMI support. > > Still, this API is complex, as it controls the LED behavior even when > the machine is suspended. I would feel more comfortable if the ABI > is not set into a stone at the beginning. code in drivers/staging/ does not mean that you can mess with the userspace api at will. It still follows the same "rules" of any other kernel code when it comes to that. So just work with the LED developers to come to a valid api that works properly within that framework please. thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel