From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3602DC43460 for ; Mon, 17 May 2021 17:24:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2B8460FDB for ; Mon, 17 May 2021 17:24:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2B8460FDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C4686EA16; Mon, 17 May 2021 17:24:17 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CB1C6E9BB; Mon, 17 May 2021 17:24:14 +0000 (UTC) IronPort-SDR: 3URc5UuiYatlzc/+9lw1dNvtUIDGRJccYTmc3+KaaDhhE5RaeYEBF27bURyZvhV8JSP7/cpR4R tI+EowO0JBxg== X-IronPort-AV: E=McAfee;i="6200,9189,9987"; a="180120447" X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="180120447" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 10:24:04 -0700 IronPort-SDR: kF0CZl+GAeg2A0GvpYg15dIeMDeUqq1uyYy9TEHZFdrOMbYDz+DzmSlhN9sE6tGcFUrO/E1pq2 QCZ5WEyCEKLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="404444619" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 17 May 2021 10:24:01 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 17 May 2021 20:24:01 +0300 Date: Mon, 17 May 2021 20:24:01 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Emil Velikov Subject: Re: [PATCH] drm/i915: only disable default vga device Message-ID: References: <20210516171432.1734268-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210516171432.1734268-1-emil.l.velikov@gmail.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > From: Vivek Das Mohapatra > > This patch is to do with seamless handover, eg when the sequence is > bootloader → plymouth → desktop. > > It switches the vga arbiter from the "other" GPU to the default one > (intel in this case), so the driver can issue some io(). I don't understand what this commit message is trying to say. > > Signed-off-by: Vivek Das Mohapatra > Signed-off-by: Emil Velikov > --- > Greetings all, > > This patch has been downstream for a while now yet it seems perfectly > reasonable thing to have in the Linux kernel. > > https://github.com/ValveSoftware/steamos_kernel/commit/5431b5b1999c3d3b5efee817fb3373fbbd473063 > > > drivers/gpu/drm/i915/display/intel_vga.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c > index be333699c515..4f07b5ad5fa0 100644 > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -30,12 +30,14 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > u8 sr1; > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > - vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > - outb(SR01, VGA_SR_INDEX); > - sr1 = inb(VGA_SR_DATA); > - outb(sr1 | 1 << 5, VGA_SR_DATA); > - vga_put(pdev, VGA_RSRC_LEGACY_IO); > - udelay(300); > + if (pdev == vga_default_device()) { > + vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > + outb(SR01, VGA_SR_INDEX); > + sr1 = inb(VGA_SR_DATA); > + outb(sr1 | 1 << 5, VGA_SR_DATA); > + vga_put(pdev, VGA_RSRC_LEGACY_IO); > + udelay(300); > + } > > intel_de_write(dev_priv, vga_reg, VGA_DISP_DISABLE); > intel_de_posting_read(dev_priv, vga_reg); > -- > 2.27.0 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB40C433B4 for ; Mon, 17 May 2021 17:24:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE5AC60FDB for ; Mon, 17 May 2021 17:24:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE5AC60FDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 449AF6E9BB; Mon, 17 May 2021 17:24:17 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2CB1C6E9BB; Mon, 17 May 2021 17:24:14 +0000 (UTC) IronPort-SDR: 3URc5UuiYatlzc/+9lw1dNvtUIDGRJccYTmc3+KaaDhhE5RaeYEBF27bURyZvhV8JSP7/cpR4R tI+EowO0JBxg== X-IronPort-AV: E=McAfee;i="6200,9189,9987"; a="180120447" X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="180120447" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2021 10:24:04 -0700 IronPort-SDR: kF0CZl+GAeg2A0GvpYg15dIeMDeUqq1uyYy9TEHZFdrOMbYDz+DzmSlhN9sE6tGcFUrO/E1pq2 QCZ5WEyCEKLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,307,1613462400"; d="scan'208";a="404444619" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 17 May 2021 10:24:01 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 17 May 2021 20:24:01 +0300 Date: Mon, 17 May 2021 20:24:01 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Emil Velikov Message-ID: References: <20210516171432.1734268-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210516171432.1734268-1-emil.l.velikov@gmail.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gU3VuLCBNYXkgMTYsIDIwMjEgYXQgMDY6MTQ6MzJQTSArMDEwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+IEZyb206IFZpdmVrIERhcyBNb2hhcGF0cmEgPHZpdmVrQGNvbGxhYm9yYS5jb20+Cj4g Cj4gVGhpcyBwYXRjaCBpcyB0byBkbyB3aXRoIHNlYW1sZXNzIGhhbmRvdmVyLCBlZyB3aGVuIHRo ZSBzZXF1ZW5jZSBpcwo+IGJvb3Rsb2FkZXIg4oaSIHBseW1vdXRoIOKGkiBkZXNrdG9wLgo+IAo+ IEl0IHN3aXRjaGVzIHRoZSB2Z2EgYXJiaXRlciBmcm9tIHRoZSAib3RoZXIiIEdQVSB0byB0aGUg ZGVmYXVsdCBvbmUKPiAoaW50ZWwgaW4gdGhpcyBjYXNlKSwgc28gdGhlIGRyaXZlciBjYW4gaXNz dWUgc29tZSBpbygpLgoKSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQgdGhpcyBjb21taXQgbWVzc2Fn ZSBpcyB0cnlpbmcgdG8gc2F5LgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaXZlayBEYXMgTW9oYXBh dHJhIDx2aXZla0Bjb2xsYWJvcmEuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEVtaWwgVmVsaWtvdiA8 ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gLS0tCj4gR3JlZXRpbmdzIGFsbCwKPiAKPiBU aGlzIHBhdGNoIGhhcyBiZWVuIGRvd25zdHJlYW0gZm9yIGEgd2hpbGUgbm93IHlldCBpdCBzZWVt cyBwZXJmZWN0bHkKPiByZWFzb25hYmxlIHRoaW5nIHRvIGhhdmUgaW4gdGhlIExpbnV4IGtlcm5l bC4KPiAKPiBodHRwczovL2dpdGh1Yi5jb20vVmFsdmVTb2Z0d2FyZS9zdGVhbW9zX2tlcm5lbC9j b21taXQvNTQzMWI1YjE5OTljM2QzYjVlZmVlODE3ZmIzMzczZmJiZDQ3MzA2Mwo+IAo+IAo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3ZnYS5jIHwgMTQgKysrKysrKystLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF92Z2EuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdmdhLmMKPiBpbmRleCBiZTMzMzY5 OWM1MTUuLjRmMDdiNWFkNWZhMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9k aXNwbGF5L2ludGVsX3ZnYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF92Z2EuYwo+IEBAIC0zMCwxMiArMzAsMTQgQEAgdm9pZCBpbnRlbF92Z2FfZGlzYWJsZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAl1OCBzcjE7Cj4gIAo+ICAJLyog V2FFbmFibGVWR0FBY2Nlc3NUaHJvdWdoSU9Qb3J0OmN0ZyxlbGssaWxrLHNuYixpdmIsdmx2LGhz dyAqLwo+IC0JdmdhX2dldF91bmludGVycnVwdGlibGUocGRldiwgVkdBX1JTUkNfTEVHQUNZX0lP KTsKPiAtCW91dGIoU1IwMSwgVkdBX1NSX0lOREVYKTsKPiAtCXNyMSA9IGluYihWR0FfU1JfREFU QSk7Cj4gLQlvdXRiKHNyMSB8IDEgPDwgNSwgVkdBX1NSX0RBVEEpOwo+IC0JdmdhX3B1dChwZGV2 LCBWR0FfUlNSQ19MRUdBQ1lfSU8pOwo+IC0JdWRlbGF5KDMwMCk7Cj4gKwlpZiAocGRldiA9PSB2 Z2FfZGVmYXVsdF9kZXZpY2UoKSkgewo+ICsJCXZnYV9nZXRfdW5pbnRlcnJ1cHRpYmxlKHBkZXYs IFZHQV9SU1JDX0xFR0FDWV9JTyk7Cj4gKwkJb3V0YihTUjAxLCBWR0FfU1JfSU5ERVgpOwo+ICsJ CXNyMSA9IGluYihWR0FfU1JfREFUQSk7Cj4gKwkJb3V0YihzcjEgfCAxIDw8IDUsIFZHQV9TUl9E QVRBKTsKPiArCQl2Z2FfcHV0KHBkZXYsIFZHQV9SU1JDX0xFR0FDWV9JTyk7Cj4gKwkJdWRlbGF5 KDMwMCk7Cj4gKwl9Cj4gIAo+ICAJaW50ZWxfZGVfd3JpdGUoZGV2X3ByaXYsIHZnYV9yZWcsIFZH QV9ESVNQX0RJU0FCTEUpOwo+ICAJaW50ZWxfZGVfcG9zdGluZ19yZWFkKGRldl9wcml2LCB2Z2Ff cmVnKTsKPiAtLSAKPiAyLjI3LjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==