All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Doug Ledford <dledford@redhat.com>,
	linux-rdma@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH 09/13] RDMA/core: Expose the ib port sysfs attribute machinery
Date: Mon, 17 May 2021 19:37:11 +0200	[thread overview]
Message-ID: <YKKpx8WlYpSfTggP@kroah.com> (raw)
In-Reply-To: <20210517173100.GT1002214@nvidia.com>

On Mon, May 17, 2021 at 02:31:00PM -0300, Jason Gunthorpe wrote:
> On Mon, May 17, 2021 at 07:12:55PM +0200, Greg KH wrote:
> 
> > > +int ib_port_sysfs_create_groups(struct ib_device *ibdev, u32 port_num,
> > > +				const struct attribute_group **groups)
> > > +{
> > > +	return sysfs_create_groups(&ibdev->port_data[port_num].sysfs->kobj,
> > > +				   groups);
> > > +}
> > > +EXPORT_SYMBOL(ib_port_sysfs_create_groups);
> > 
> > You are wrapping _GPL symbols here with a "convenience" function, please
> > make these all EXPORT_SYMBOL_GPL() so I don't get nervous.
> 
> These functions get deleted in a following patch once everything can
> be switched to ops->get_port_groups(), which provides even less
> flexability for the driver to do things wrong.
> 
> The whole subsystem already uses !GPL export so it is very strange to
> see a GPL symbol at all:
> 
> $ git grep EXPORT_SYMBOL\( drivers/infiniband/core/ | wc -l
> 310
> $ git grep EXPORT_SYMBOL_GPL\( drivers/infiniband/core/ | wc -l
> 1
> 
> Anyhow, if it makes you happy I'll change it.

Please do, it's a simple wrapper function.

thanks,

greg k-h

  reply	other threads:[~2021-05-17 17:37 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 16:47 [PATCH 00/13] Reorganize sysfs file creation for struct ib_devices Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 01/13] RDMA: Split the alloc_hw_stats() ops to port and device variants Jason Gunthorpe
2021-05-17 23:06   ` Saleem, Shiraz
2021-05-17 23:10     ` Jason Gunthorpe
2021-05-18  0:18       ` Saleem, Shiraz
2021-05-18  0:20         ` Jason Gunthorpe
2021-05-18 21:58           ` Saleem, Shiraz
2021-05-19 12:25             ` Jason Gunthorpe
2021-05-19 16:50               ` Saleem, Shiraz
2021-05-18  3:49   ` Mark Zhang
2021-05-19  1:10     ` Saleem, Shiraz
2021-05-20 16:29     ` Jason Gunthorpe
2021-05-19 11:29   ` Gal Pressman
2021-05-19 13:44     ` Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 02/13] RDMA/core: Replace the ib_port_data hw_stats pointers with a ib_port pointer Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 03/13] RDMA/core: Split port and device counter sysfs attributes Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 04/13] RDMA/core: Split gid_attrs related sysfs from add_port() Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 05/13] RDMA/core: Simplify how the gid_attrs sysfs is created Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 06/13] RDMA/core: Simplify how the port " Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 07/13] RDMA/core: Create the device hw_counters through the normal groups mechanism Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 08/13] RDMA/core: Remove the kobject_uevent() NOP Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 09/13] RDMA/core: Expose the ib port sysfs attribute machinery Jason Gunthorpe
2021-05-17 17:12   ` Greg KH
2021-05-17 17:31     ` Jason Gunthorpe
2021-05-17 17:37       ` Greg KH [this message]
2021-05-17 16:47 ` [PATCH 10/13] RDMA/cm: Use an attribute_group on the ib_port_attribute intead of kobj's Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 11/13] RDMA/qib: Use attributes for the port sysfs Jason Gunthorpe
2021-05-17 17:11   ` Greg KH
2021-05-17 17:13     ` Jason Gunthorpe
2021-05-17 17:31       ` Greg KH
2021-05-17 18:44         ` Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 12/13] RDMA/hfi1: " Jason Gunthorpe
2021-05-17 16:47 ` [PATCH 13/13] RDMA: Change ops->init_port to ops->get_port_groups Jason Gunthorpe
2021-05-18 23:07 ` [PATCH 00/13] Reorganize sysfs file creation for struct ib_devices Nathan Chancellor
2021-05-19 13:46   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKKpx8WlYpSfTggP@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dledford@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=keescook@chromium.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nathan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.