From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4499C433B4 for ; Tue, 18 May 2021 07:33:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4BAC6117A for ; Tue, 18 May 2021 07:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241988AbhERHeo (ORCPT ); Tue, 18 May 2021 03:34:44 -0400 Received: from cloud.peff.net ([104.130.231.41]:57472 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240235AbhERHeo (ORCPT ); Tue, 18 May 2021 03:34:44 -0400 Received: (qmail 11280 invoked by uid 109); 18 May 2021 07:33:26 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 18 May 2021 07:33:26 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 5412 invoked by uid 111); 18 May 2021 07:33:28 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 18 May 2021 03:33:28 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 18 May 2021 03:33:25 -0400 From: Jeff King To: Junio C Hamano Cc: Derrick Stolee via GitGitGadget , git@vger.kernel.org, stolee@gmail.com, git@jeffhostetler.com, Derrick Stolee , Derrick Stolee Subject: Re: [PATCH v2 2/4] csum-file.h: increase hashfile buffer size Message-ID: References: <9dc602f6c4221e2259778842ec3d1eda57508333.1621254292.git.gitgitgadget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, May 18, 2021 at 06:54:57AM +0900, Junio C Hamano wrote: > Just after the previous step justified its simplification of its > progress logic based on how small the buffer is, this step makes it > 16 times as big, which felt a tiny bit dishonest. We probably > should say somewhere that 128k is still small enough that the > rewrite in the previous step is still valid ;-) I noticed that, too. I'm not sure if still is small enough. For local pack writes, etc, it seems fine. But what about "index-pack --stdin" reading over the network? Updating progress every 8k instead of every 128k seems like it would be more responsive, especially if the network is slow or jittery. I dunno. Maybe that is too small to care about for the modern world, but I just want to make sure we are not being blinded by the fast networks all of us presumably enjoy. :) -Peff