All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Kashyap Desai <kashyap.desai@broadcom.com>
Cc: linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, steve.hagan@broadcom.com,
	peter.rivera@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com,
	sathya.prakash@broadcom.com, bvanassche@acm.org,
	thenzl@redhat.com, hare@suse.de, himanshu.madhani@oracle.com,
	hch@infradead.org
Subject: Re: [PATCH v5 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig
Date: Tue, 18 May 2021 08:39:06 +0100	[thread overview]
Message-ID: <YKNvGn9TTwthUaMv@infradead.org> (raw)
In-Reply-To: <20210513083608.2243297-2-kashyap.desai@broadcom.com>

> +	help
> +	This driver supports Broadcom's Unified MPI3 based Storage & RAID Controllers.

Overly long line here.

> +#ifndef MPI30_API_H
> +#define MPI30_API_H     1
> +#include "mpi30_transport.h"
> +#include "mpi30_image.h"
> +#include "mpi30_init.h"
> +#include "mpi30_ioc.h"
> +#endif

Just including the four headers where needed directly would make more
sense to me than this meta-header.

> + *           Name: mpi30_image.h

We generally do not add comments like this.  It does not add any value
and gets stale very quickly.

> + *  Creation Date: 04/02/2018
> + *        Version: 03.00.00

No need for this information either.  If you important from a specific
internal version this is something that should go into the commit log.

> +struct _mpi3_comp_image_version {

Please drop the leading underscore from the various type names.

  parent reply	other threads:[~2021-05-18  7:40 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13  8:35 [PATCH v5 00/24] Introducing mpi3mr driver Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 01/24] mpi3mr: add mpi30 Rev-R headers and Kconfig Kashyap Desai
2021-05-14 11:31   ` Hannes Reinecke
2021-05-14 14:39   ` Tomas Henzl
2021-05-14 16:18   ` Himanshu Madhani
2021-05-17 15:52     ` Kashyap Desai
2021-05-18  7:39   ` Christoph Hellwig [this message]
2021-05-19 14:58     ` Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 02/24] mpi3mr: base driver code Kashyap Desai
2021-05-14 14:43   ` Tomas Henzl
2021-05-14 20:16   ` Himanshu Madhani
2021-05-13  8:35 ` [PATCH v5 03/24] mpi3mr: create operational request and reply queue pair Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 04/24] mpi3mr: add support of queue command processing Kashyap Desai
2021-05-14 11:41   ` Hannes Reinecke
2021-05-17 15:37     ` Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 05/24] mpi3mr: add support of internal watchdog thread Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 06/24] mpi3mr: add support of event handling part-1 Kashyap Desai
2021-05-14 11:45   ` Hannes Reinecke
2021-05-13  8:35 ` [PATCH v5 07/24] mpi3mr: add support of event handling pcie devices part-2 Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 08/24] mpi3mr: add support of event handling part-3 Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 09/24] mpi3mr: add support for recovering controller Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 10/24] mpi3mr: add support of timestamp sync with firmware Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 11/24] mpi3mr: print ioc info for debugging Kashyap Desai
2021-05-14 11:45   ` Hannes Reinecke
2021-05-13  8:35 ` [PATCH v5 12/24] mpi3mr: add bios_param shost template hook Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 13/24] mpi3mr: implement scsi error handler hooks Kashyap Desai
2021-05-14 14:51   ` Tomas Henzl
2021-05-13  8:35 ` [PATCH v5 14/24] mpi3mr: add change queue depth support Kashyap Desai
2021-05-13  8:35 ` [PATCH v5 15/24] mpi3mr: allow certain commands during pci-remove hook Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 16/24] mpi3mr: hardware workaround for UNMAP commands to nvme drives Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 17/24] mpi3mr: add support of threaded isr Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 18/24] mpi3mr: add complete support of soft reset Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 19/24] mpi3mr: print pending host ios for debug Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 20/24] mpi3mr: wait for pending IO completions upon detection of VD IO timeout Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 21/24] mpi3mr: add support of PM suspend and resume Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 22/24] mpi3mr: add support of DSN secure fw check Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 23/24] mpi3mr: add eedp dif dix support Kashyap Desai
2021-05-13  8:36 ` [PATCH v5 24/24] mpi3mr: add event handling debug prints Kashyap Desai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKNvGn9TTwthUaMv@infradead.org \
    --to=hch@infradead.org \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=himanshu.madhani@oracle.com \
    --cc=jejb@linux.ibm.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpi3mr-linuxdrv.pdl@broadcom.com \
    --cc=peter.rivera@broadcom.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=steve.hagan@broadcom.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.