From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A0AC433ED for ; Wed, 19 May 2021 00:04:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E43C6135B for ; Wed, 19 May 2021 00:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239854AbhESAGF (ORCPT ); Tue, 18 May 2021 20:06:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:49116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232153AbhESAGE (ORCPT ); Tue, 18 May 2021 20:06:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B5096135D; Wed, 19 May 2021 00:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621382686; bh=fDRMp6la+ZcO5o042pAO9F4TsB3TBtyXZEm5oCc5P38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bvqEZnImrNrt7AR9pV3HbJHdRQsLGs6+rH6LJTWkf5DaLd0DaX1l5uEZJPHve1jc1 1h8wF5O5OgHG4WZpNi+41Tg5skdzyFIBm6xoYHfbYtRc1RZih+WCgWlc6AiGQI9oQT KqR4ihgH/nGqbSM0IFGIvrEJGBfZrnckNX6I5BVKx3371+I4iK7pozq8Sd3OLTi8Gk gzye1FR3mDmlQcV2UTRPMHWaGhT07WNwNv9MbN9b/FG5YxmHS2hwWBOg/7+Z628p3e GtIORMGaG9WQRiGHDq8PQFHM65YTNf3gau6fAJtO86/3leP/YEq9baAH9ibdj+fbm+ dD5GIv4WQqt2g== Date: Tue, 18 May 2021 20:04:45 -0400 From: Sasha Levin To: Eric Dumazet Cc: "Michael S. Tsirkin" , Greg Kroah-Hartman , LKML , stable@vger.kernel.org, Xuan Zhuo , Jason Wang , virtualization@lists.linux-foundation.org, "David S. Miller" Subject: Re: [PATCH 5.4 042/111] virtio_net: Do not pull payload in skb->head Message-ID: References: <20210412084004.200986670@linuxfoundation.org> <20210412084005.653952525@linuxfoundation.org> <20210412051230-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 09:35:26PM +0200, Eric Dumazet wrote: >On Mon, Apr 12, 2021 at 11:12 AM Michael S. Tsirkin wrote: >> Note that an issue related to this patch was recently reported. >> It's quite possible that the root cause is a bug elsewhere >> in the kernel, but it probably makes sense to defer the backport >> until we know more ... > >I think the patch should be backported now, all issues have been sorted out ? This is just 38ec4944b593 ("gro: ensure frag0 meets IP header alignment"), right? I can queue both for the next round of releases. -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB58C433ED for ; Wed, 19 May 2021 00:04:52 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCB1E61361 for ; Wed, 19 May 2021 00:04:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCB1E61361 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A9CD783D03; Wed, 19 May 2021 00:04:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L-IIw4E_4CBJ; Wed, 19 May 2021 00:04:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id 67A058384B; Wed, 19 May 2021 00:04:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 32026C000D; Wed, 19 May 2021 00:04:50 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4A246C0001 for ; Wed, 19 May 2021 00:04:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2F019405DF for ; Wed, 19 May 2021 00:04:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4HuBFvFdxcZs for ; Wed, 19 May 2021 00:04:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp4.osuosl.org (Postfix) with ESMTPS id E5239405D5 for ; Wed, 19 May 2021 00:04:46 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B5096135D; Wed, 19 May 2021 00:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621382686; bh=fDRMp6la+ZcO5o042pAO9F4TsB3TBtyXZEm5oCc5P38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bvqEZnImrNrt7AR9pV3HbJHdRQsLGs6+rH6LJTWkf5DaLd0DaX1l5uEZJPHve1jc1 1h8wF5O5OgHG4WZpNi+41Tg5skdzyFIBm6xoYHfbYtRc1RZih+WCgWlc6AiGQI9oQT KqR4ihgH/nGqbSM0IFGIvrEJGBfZrnckNX6I5BVKx3371+I4iK7pozq8Sd3OLTi8Gk gzye1FR3mDmlQcV2UTRPMHWaGhT07WNwNv9MbN9b/FG5YxmHS2hwWBOg/7+Z628p3e GtIORMGaG9WQRiGHDq8PQFHM65YTNf3gau6fAJtO86/3leP/YEq9baAH9ibdj+fbm+ dD5GIv4WQqt2g== Date: Tue, 18 May 2021 20:04:45 -0400 From: Sasha Levin To: Eric Dumazet Subject: Re: [PATCH 5.4 042/111] virtio_net: Do not pull payload in skb->head Message-ID: References: <20210412084004.200986670@linuxfoundation.org> <20210412084005.653952525@linuxfoundation.org> <20210412051230-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Xuan Zhuo , "Michael S. Tsirkin" , Greg Kroah-Hartman , LKML , stable@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, May 18, 2021 at 09:35:26PM +0200, Eric Dumazet wrote: >On Mon, Apr 12, 2021 at 11:12 AM Michael S. Tsirkin wrote: >> Note that an issue related to this patch was recently reported. >> It's quite possible that the root cause is a bug elsewhere >> in the kernel, but it probably makes sense to defer the backport >> until we know more ... > >I think the patch should be backported now, all issues have been sorted out ? This is just 38ec4944b593 ("gro: ensure frag0 meets IP header alignment"), right? I can queue both for the next round of releases. -- Thanks, Sasha _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization