Re: [PATCH 1/2] fs: anon_inodes: export anon_inode_getfile_secure helper

From: Christoph Hellwig <hch@infradead.org>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: io-uring@vger.kernel.org, Pavel Emelyanov <xemul@openvz.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jens Axboe <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>,
	Lokesh Gidra <lokeshgidra@google.com>,
	Eric Biggers <ebiggers@google.com>,
	Paul Moore <paul@paul-moore.com>,
	Daniel Colascione <dancol@google.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH  1/2] fs: anon_inodes: export anon_inode_getfile_secure helper
Date: Wed, 19 May 2021 17:04:57 +0100	[thread overview]
Message-ID: <YKU3KWn4ZnRSyyFY@infradead.org> (raw)
In-Reply-To: <20210519113058.1979817-2-memxor@gmail.com>

On Wed, May 19, 2021 at 05:00:56PM +0530, Kumar Kartikeya Dwivedi wrote:
> This is the non-fd installing analogue of anon_inode_getfd_secure. In
> addition to allowing LSMs to attach policy to the distinct inode, this
> is also needed for checkpoint restore of an io_uring instance where a
> mapped region needs to mapped back to the io_uring fd by CRIU. This is
> currently not possible as all anon_inodes share a single inode.

No need to export it, as io_uring can't be built modular.

> +struct file *anon_inode_getfile_secure(const char *name,
> +				       const struct file_operations *fops,
> +				       void *priv, int flags,
> +				       const struct inode *context_inode)
> +{
> +	return __anon_inode_getfile(name, fops, priv, flags, context_inode, true);
> +}
> +EXPORT_SYMBOL_GPL(anon_inode_getfile_secure);

Please avoid the overly long line here.