From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D85C43462 for ; Thu, 20 May 2021 15:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E5A761073 for ; Thu, 20 May 2021 15:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236410AbhETPsH (ORCPT ); Thu, 20 May 2021 11:48:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbhETPsF (ORCPT ); Thu, 20 May 2021 11:48:05 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36997C06175F for ; Thu, 20 May 2021 08:46:44 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id v12so9293796plo.10 for ; Thu, 20 May 2021 08:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=sLtEbitldgXrD8ZBjQvwX8vXZsSeGCvELvSzENcd2YSqXu9iBk1TDDVBxvGX2WckOo ZLff2Dr5rf7BZosrT+ewzXMyOMJf7XdiMM+n3CouAjKLmyJ4lGRwEzzaStNPUE+WjS7D c4LMP0I9t0UmqsR5mCkTOYB5wd2kxuubtNhodBLwxrETygnNDHDCHy31/oGVyKeNzdvA oWnKYwvfUNzPUzQWFbzq2skT99K0pE/S0vy4Ytuvbak/Y0917zqNoYtlUW9/+DpwLaIl gnMbO4DOkYo0VcpgnuDlYdMT3S9glBXtaGx55Sc4kX843kWuILdUe5osSIXS/GEEbknw Mxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=Mhki1DUXl+qtfmdIofXLyAiwuUVp4/OgqAqMPbEJpEst+avRrWI8czAhXd5OVqyW0t hEcIc+DNkWMfSvm5I9QvSeR2lUKyBrpzzbI512qy1enxwBz7w7T0Qkk8af/9oZEScNWO 8z5massBKIg4C4m5mmgeraidZoPeIpG7K0RFsrhoGMgTyoGhLmJ4a1W4rDd2ojcfGely fuEMmaaQAIF4oMlHJbaWibk8NOpKbcbeacco8kAXdVrOoi7fCkJs2HKyIZ4TEUBQ6DB+ p8Fj1rdRLyFcmFJ1S8phFXFhUY2GX7IezpJ8/gwDVRCR9cwopQGf7BYC4GmgI3yiZary 9iiQ== X-Gm-Message-State: AOAM5338s/Utg0p7Rj3x/x8M4m+rNzXAQKjDbdypsP1w767lDo32vvFn w8zEEadOdn4nDT27Y+MfhMcZZA== X-Google-Smtp-Source: ABdhPJxiFrIPGyZeGPWU+3qcevfuOBti/QMH85WV51tQ0Qoku7ZeZreMmR0xPInOvOCdtXteJDisrw== X-Received: by 2002:a17:90a:fb51:: with SMTP id iq17mr5581236pjb.4.1621525603564; Thu, 20 May 2021 08:46:43 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id x13sm2654328pja.3.2021.05.20.08.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 08:46:42 -0700 (PDT) Date: Thu, 20 May 2021 15:46:39 +0000 From: Sean Christopherson To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH 2/6] KVM: X86: Don't use BIT() macro in UAPI headers Message-ID: References: <20210520104343.317119-1-joerichey94@gmail.com> <20210520104343.317119-3-joerichey94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520104343.317119-3-joerichey94@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This feedback applies to all patches in this series. On Thu, May 20, 2021, Joe Richey wrote: > From: Joe Richey > > A previous patch Heh, I think it goes without saying that the code was introduced by a previous patch, unless you've invented a time machine, in which case we should talk... > [1] used the BIT() macro to define the > KVM_DIRTY_GFN_F_* constants in KVM's UAPI header. > > This macro is defined in the kernel but not in the UAPI headers. > > [1] https://patchwork.kernel.org/patch/11854393 Linking to the patch isn't helpful/desirable in this case because it doesn't provide any info about when the commit actually landed in the kernel. And depending on the whims of the maintainer, what was posted may not exactly match the code that was commited. What you want is a Fixes: tag that points at the offending commit. The Fixes: tag will also get the fix picked up for stable kernels, though in KVM we often explicitly add "Cc: stable@vger.kernel.org" (though IIRC tglx prefers not to have the explicit Cc). Anyways, the changelog can simply be something like: Replace BIT() in KVM's UAPI header with an open coded equivalent. BIT() is not defined in the UAPI headers and its usage may cause userspace build errors. Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking") Signed-off-by: Joe Richey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71232C43460 for ; Thu, 20 May 2021 15:49:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F344D610CC for ; Thu, 20 May 2021 15:49:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F344D610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UZYu8hoN946AKjVsOhfx8C7NeLGs3BFwksKbe1g2Iec=; b=bXgStOz88LIe5X0IV+NqMZu9Gr i5Sx1db6NBrtuEf1fhVKRvjbutVHYCfTDuCNncvVVhFy5NpYbl3OV5glfrXzLSzsnRjv8PtvJr8LE 9iJFZ7lDZvdEoK7Iq3x8PtnuwtUqHSus75UQBY4t9DUQaxVD0KkiktRaqYZVnC/T76b1DyI9ByF/z sr2FvQj9cOi8HPhm2VLroZFJNwuiZ98GMcl/My2IGiEIyvtX7292QS5DaI6mNTcFgsk0239xkwtqV tLMLvoiPWRsQCK+TE4KRGtYrMy5ZwhQO0+NHFZck7Xgd2YT04/QP9zd7JKswnunKFqjXqGNWbD/0S dT7oviPg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljksu-001l5K-I3; Thu, 20 May 2021 15:46:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljksq-001l4G-NT for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 15:46:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=1OTOlPc/jUN0Zneu+hNj/JjcLk P0tbCUp/EY0X/Q9qc2STlG3yG7xMRFdRez9IjyxogxRMUH1d/pZh2T7oeRXeABUUy0cWjH8SLSSaC XiN/kETQavsbDEh0t/Sa4eT3rNtSV6PUCuDbJDfuSCJ02oZugcVL+oE7iy9PCtfCd8ONj5B4EvC7n zZgy7yMq8cRoJBLXA7EPINFhdOifbJ9QSIEGnh51T1kIgvM2ZKqv/KldBBxhXJPCLUentvaDJRri4 Tfy7I5v+0in0HpWQX6J9V49zeHjxmzjN1MJpWhB9Mt99jPLUElOmBK6Vj98gf6T7tMLC7wLGH8P3U LZf3OA/w==; Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljksn-00GTk5-0b for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 15:46:47 +0000 Received: by mail-pj1-x102c.google.com with SMTP id ot16so7408722pjb.3 for ; Thu, 20 May 2021 08:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=sLtEbitldgXrD8ZBjQvwX8vXZsSeGCvELvSzENcd2YSqXu9iBk1TDDVBxvGX2WckOo ZLff2Dr5rf7BZosrT+ewzXMyOMJf7XdiMM+n3CouAjKLmyJ4lGRwEzzaStNPUE+WjS7D c4LMP0I9t0UmqsR5mCkTOYB5wd2kxuubtNhodBLwxrETygnNDHDCHy31/oGVyKeNzdvA oWnKYwvfUNzPUzQWFbzq2skT99K0pE/S0vy4Ytuvbak/Y0917zqNoYtlUW9/+DpwLaIl gnMbO4DOkYo0VcpgnuDlYdMT3S9glBXtaGx55Sc4kX843kWuILdUe5osSIXS/GEEbknw Mxjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oQs9jtWBxUSYheKfenr+oS5kRIQjvZiaP96jdn9gsMU=; b=RI1xYumXcx2wX7cisr0V44J8d/5adEbmxpoJbCeukE2RRmVOq97qQevvy7SG8TPaZt XwdIomzoyZsmGG4LwxsBqp/gS195a99DfU7NI4yDb1fskPYWPPqhDX7E2+hAhd9eYNci VTbZmiuvQO/BlLsvpwgTS7ln2IdPmbAy9BoJPem5a0z8xCwuoqrv1YVnm6styy3thRLK oFqM0+MgqlO+cEOY7o9UaT6gqk0kQ3dB8jeNPf2Z3SQkD+QZo6ZKe/kU00ptnNZg9tPw 0rm78biYX+qNDCCASpcf+mEyHl4Ed2vtQPw11Y1yKrpkr7upAdYqfuwDXq/pU91nO2Nm f4gg== X-Gm-Message-State: AOAM532DFclFJSziiRn3o7oFwnKxi3eyOiJlrxllfTZUX7XOxatksLIU CQ2RaKkERbm5fPALUFjkdQ+EgQ== X-Google-Smtp-Source: ABdhPJxiFrIPGyZeGPWU+3qcevfuOBti/QMH85WV51tQ0Qoku7ZeZreMmR0xPInOvOCdtXteJDisrw== X-Received: by 2002:a17:90a:fb51:: with SMTP id iq17mr5581236pjb.4.1621525603564; Thu, 20 May 2021 08:46:43 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id x13sm2654328pja.3.2021.05.20.08.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 08:46:42 -0700 (PDT) Date: Thu, 20 May 2021 15:46:39 +0000 From: Sean Christopherson To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH 2/6] KVM: X86: Don't use BIT() macro in UAPI headers Message-ID: References: <20210520104343.317119-1-joerichey94@gmail.com> <20210520104343.317119-3-joerichey94@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520104343.317119-3-joerichey94@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_084645_067114_2F5CC516 X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This feedback applies to all patches in this series. On Thu, May 20, 2021, Joe Richey wrote: > From: Joe Richey > > A previous patch Heh, I think it goes without saying that the code was introduced by a previous patch, unless you've invented a time machine, in which case we should talk... > [1] used the BIT() macro to define the > KVM_DIRTY_GFN_F_* constants in KVM's UAPI header. > > This macro is defined in the kernel but not in the UAPI headers. > > [1] https://patchwork.kernel.org/patch/11854393 Linking to the patch isn't helpful/desirable in this case because it doesn't provide any info about when the commit actually landed in the kernel. And depending on the whims of the maintainer, what was posted may not exactly match the code that was commited. What you want is a Fixes: tag that points at the offending commit. The Fixes: tag will also get the fix picked up for stable kernels, though in KVM we often explicitly add "Cc: stable@vger.kernel.org" (though IIRC tglx prefers not to have the explicit Cc). Anyways, the changelog can simply be something like: Replace BIT() in KVM's UAPI header with an open coded equivalent. BIT() is not defined in the UAPI headers and its usage may cause userspace build errors. Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking") Signed-off-by: Joe Richey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel