From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9AEEC433B4 for ; Fri, 21 May 2021 01:43:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C238613AC for ; Fri, 21 May 2021 01:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237541AbhEUBoV (ORCPT ); Thu, 20 May 2021 21:44:21 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50340 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237311AbhEUBoU (ORCPT ); Thu, 20 May 2021 21:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=c+XCuLEAL9tyzjer230+dzuUWAppVl3JEe2dMavLJEc=; b=GR e4C4SUPoVgjD1y/T6PfFPFpKX7ifxo3EtyHuyheN88JkYx5vUZqVC8acWMU8OqfULpKpVLd9+3L/v qXbpkyXbupL0X/dlb03YwP0BRuJwKz/+k88h/GYLCZQSZ0URU35zkvzjIrSkuI082rIg+oIcXCNR8 1NpDm10jDV1kmLA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ljuBj-005CPk-9y; Fri, 21 May 2021 03:42:55 +0200 Date: Fri, 21 May 2021 03:42:55 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory CLEMENT , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 mvebu + mvebu/dt64 2/2] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210520113844.32319-1-pali@kernel.org> <20210520113844.32319-3-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210520113844.32319-3-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 01:38:44PM +0200, Pali Rohár wrote: > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > the generic armada-37xx.dtsi file and use the generic compatible string > 'marvell,armada-3700-rwtm-firmware' instead of the current one. > > Turris MOX DTS file contains also old compatible string for backward > compatibility. > > The Turris MOX rWTM firmware can be used on any Armada 37xx device, > giving them access to the rWTM hardware random number generator, which > is otherwise unavailable. > > This change allows Linux to load the turris-mox-rwtm.ko module on these > boards. > > Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and > CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails > to probe, while with CZ.NIC's firmware it registers the HW random number > generator. > > Signed-off-by: Pali Rohár > Signed-off-by: Marek Behún > Cc: # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-3720-turris-mox: add firmware node") Please drop stable. It is a new feature, not a fix. Otherwise Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A72D9C433B4 for ; Fri, 21 May 2021 01:44:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E4326135C for ; Fri, 21 May 2021 01:44:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E4326135C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AbZHKSonTENjVhAVHXMAexo5a8pH3Nm1qvEjEGsYnEU=; b=UaxoaCr9mL4KaR+Tf+IXF5ZWOD 9mUJhmhsv/f5PRD8zrFo4+ayPcchxiIhR5mGf6elVrh9pb/rTgbmhSGidJSSwLPaFw2TZXSgFvAXP mzfZgXiOniAk/gyHdi2qBhC3Eahitgr5kmjdhoMz8nV/TYSVCf4pQfb1hSkV+S3mFlPP+OtQjgsns 8AHK+z1Ar+FhioqVI8LHJD+A9kja5v2Gjt63Co9QJ016wiHUttlZiY2T/9MvvIBHaVr9J8jBVXZ0V UQk7OTTGFkpj2pEpsKZ/YEZuDkkX8Ph5kWF8eKkVX4halQdVM78F+7l5lk+eQJ0lMUiNKB5I5qi2D UeMlaxHQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljuBu-003JNg-Su; Fri, 21 May 2021 01:43:07 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljuBn-003JK8-TM for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 01:43:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=c+XCuLEAL9tyzjer230+dzuUWAppVl3JEe2dMavLJEc=; b=Oz0KHkgbrHd3yh2ve1sPB10QXm zKIlNgt/RRYzVvWCUZ7bV9y3YA0GlSTVQl9WNtQrQ7rc2VDX4I1dS0CiU4xN5qM4D8SmTR/nvgIv5 SaM8pwbqj//xBtylZx72OPux6tsfr66ZpAVWadO+tkqkEUjq1IcB1JM2AYUv9OvwStyNNAlyweA+E JuFynBAKRdloHya47H2SNnKx2gFwaWOzFAL5+6xmnHbFvLz7XTaA8M4dMmOpLEKbIZdviYKwHAl2K rL++zmZTgSd/yrS7QQx57ugypMhOkFNMzNUzNJmUtXVvuWoG1j2tm2HAI5UKiCe1r6AZDnjMwybc/ 0c87gyMg==; Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljuBl-00Gkiy-5D for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 01:42:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=c+XCuLEAL9tyzjer230+dzuUWAppVl3JEe2dMavLJEc=; b=GR e4C4SUPoVgjD1y/T6PfFPFpKX7ifxo3EtyHuyheN88JkYx5vUZqVC8acWMU8OqfULpKpVLd9+3L/v qXbpkyXbupL0X/dlb03YwP0BRuJwKz/+k88h/GYLCZQSZ0URU35zkvzjIrSkuI082rIg+oIcXCNR8 1NpDm10jDV1kmLA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ljuBj-005CPk-9y; Fri, 21 May 2021 03:42:55 +0200 Date: Fri, 21 May 2021 03:42:55 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Gregory CLEMENT , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 mvebu + mvebu/dt64 2/2] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file Message-ID: References: <20210308153703.23097-1-kabel@kernel.org> <20210520113844.32319-1-pali@kernel.org> <20210520113844.32319-3-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520113844.32319-3-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_184257_455801_37278A20 X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 01:38:44PM +0200, Pali Roh=E1r wrote: > Move the turris-mox-rwtm firmware node from Turris MOX' device tree into > the generic armada-37xx.dtsi file and use the generic compatible string > 'marvell,armada-3700-rwtm-firmware' instead of the current one. > = > Turris MOX DTS file contains also old compatible string for backward > compatibility. > = > The Turris MOX rWTM firmware can be used on any Armada 37xx device, > giving them access to the rWTM hardware random number generator, which > is otherwise unavailable. > = > This change allows Linux to load the turris-mox-rwtm.ko module on these > boards. > = > Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and > CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails > to probe, while with CZ.NIC's firmware it registers the HW random number > generator. > = > Signed-off-by: Pali Roh=E1r > Signed-off-by: Marek Beh=FAn > Cc: # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-37= 20-turris-mox: add firmware node") Please drop stable. It is a new feature, not a fix. Otherwise Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel