All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hw/nvme/ctrl: fix functions style
       [not found] <CGME20210521061352epcas5p145b3a19453f7ff9d625bb9ae447b649c@epcas5p1.samsung.com>
@ 2021-05-21  6:08 ` Gollu Appalanaidu
  2021-05-21  7:13   ` Klaus Jensen
  0 siblings, 1 reply; 3+ messages in thread
From: Gollu Appalanaidu @ 2021-05-21  6:08 UTC (permalink / raw)
  To: qemu-devel
  Cc: fam, kwolf, qemu-block, Gollu Appalanaidu, mreitz, its, stefanha, kbusch

Identify command related functions style fix.

Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
---
 hw/nvme/ctrl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 0bcaf7192f..40a7efcea9 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
 }
 
 static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
-        bool active)
+                                     bool active)
 {
     NvmeNamespace *ns;
     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
 }
 
 static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
-        bool active)
+                                     bool active)
 {
     NvmeNamespace *ns;
     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
 }
 
 static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
-        bool active)
+                                         bool active)
 {
     NvmeNamespace *ns;
     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw/nvme/ctrl: fix functions style
  2021-05-21  6:08 ` [PATCH] hw/nvme/ctrl: fix functions style Gollu Appalanaidu
@ 2021-05-21  7:13   ` Klaus Jensen
  2021-05-24 12:33     ` Gollu Appalanaidu
  0 siblings, 1 reply; 3+ messages in thread
From: Klaus Jensen @ 2021-05-21  7:13 UTC (permalink / raw)
  To: Gollu Appalanaidu
  Cc: fam, kwolf, qemu-block, qemu-devel, mreitz, stefanha, kbusch

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

On May 21 11:38, Gollu Appalanaidu wrote:
>Identify command related functions style fix.
>
>Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>---
> hw/nvme/ctrl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
>index 0bcaf7192f..40a7efcea9 100644
>--- a/hw/nvme/ctrl.c
>+++ b/hw/nvme/ctrl.c
>@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
> }
>
> static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                     bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
> }
>
> static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                     bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
> }
>
> static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                         bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>-- 
>2.17.1
>
>

Thanks, applied to nvme-next.

Please just use 'hw/nvme:' in the commit title, we don't need to specify 
the sub-subsystem ;)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw/nvme/ctrl: fix functions style
  2021-05-21  7:13   ` Klaus Jensen
@ 2021-05-24 12:33     ` Gollu Appalanaidu
  0 siblings, 0 replies; 3+ messages in thread
From: Gollu Appalanaidu @ 2021-05-24 12:33 UTC (permalink / raw)
  To: Klaus Jensen; +Cc: fam, kwolf, qemu-block, qemu-devel, mreitz, stefanha, kbusch

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

On Fri, May 21, 2021 at 09:13:51AM +0200, Klaus Jensen wrote:
>On May 21 11:38, Gollu Appalanaidu wrote:
>>Identify command related functions style fix.
>>
>>Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>>---
>>hw/nvme/ctrl.c | 6 +++---
>>1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
>>index 0bcaf7192f..40a7efcea9 100644
>>--- a/hw/nvme/ctrl.c
>>+++ b/hw/nvme/ctrl.c
>>@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
>>}
>>
>>static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>>-        bool active)
>>+                                     bool active)
>>{
>>    NvmeNamespace *ns;
>>    NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>>}
>>
>>static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>>-        bool active)
>>+                                     bool active)
>>{
>>    NvmeNamespace *ns;
>>    NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>>}
>>
>>static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
>>-        bool active)
>>+                                         bool active)
>>{
>>    NvmeNamespace *ns;
>>    NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>>-- 
>>2.17.1
>>
>>
>
>Thanks, applied to nvme-next.
>
>Please just use 'hw/nvme:' in the commit title, we don't need to 
>specify the sub-subsystem ;)

Sure Klaus, Thanks :)


[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-25  3:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210521061352epcas5p145b3a19453f7ff9d625bb9ae447b649c@epcas5p1.samsung.com>
2021-05-21  6:08 ` [PATCH] hw/nvme/ctrl: fix functions style Gollu Appalanaidu
2021-05-21  7:13   ` Klaus Jensen
2021-05-24 12:33     ` Gollu Appalanaidu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.