From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH] USB: gadget: lpc32xx_udc: remove debugfs dentry variable
Date: Fri, 21 May 2021 13:45:06 +0200 [thread overview]
Message-ID: <YKedQtgkBB+Bm0xT@kroah.com> (raw)
In-Reply-To: <4353dd50-1b41-65f8-815a-ae3fbafb387b@mleia.com>
On Wed, May 19, 2021 at 02:09:17PM +0300, Vladimir Zapolskiy wrote:
> On 5/18/21 7:20 PM, Greg Kroah-Hartman wrote:
> > There is no need to store the dentry for a fixed filename that we have
> > the string for. So just have debugfs look it up when we need it to
> > remove the file, no need to store it anywhere locally.
> >
> > Note, this driver is broken in that debugfs will not work for more than
> > one instance of the device it supports. But given that this patch does
> > not change that, and no one has ever seemed to notice, it must not be an
> > issue...
>
> Yep, there is only one SoC with this device, and it has only one instance
> of this UDC. Bad excuse, I know it.
Not a big deal :)
> > Cc: Felipe Balbi <balbi@kernel.org>
> > Cc: Vladimir Zapolskiy <vz@mleia.com>
> > Cc: linux-usb@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Thanks for the review!
greg k-h
next prev parent reply other threads:[~2021-05-21 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 16:20 [PATCH] USB: gadget: lpc32xx_udc: remove debugfs dentry variable Greg Kroah-Hartman
2021-05-19 11:09 ` Vladimir Zapolskiy
2021-05-21 11:45 ` Greg Kroah-Hartman [this message]
2021-05-19 12:05 ` Felipe Balbi
2021-05-21 11:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKedQtgkBB+Bm0xT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.