From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 761EDC433B4 for ; Fri, 21 May 2021 12:47:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59A0E613D8 for ; Fri, 21 May 2021 12:47:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234478AbhEUMtG (ORCPT ); Fri, 21 May 2021 08:49:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:32908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234312AbhEUMtB (ORCPT ); Fri, 21 May 2021 08:49:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1B2A2613CC; Fri, 21 May 2021 12:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621601258; bh=ENTtycla6YwFTERpKa9JcOnfx4HXvBKAO7BqN7/IJVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+cYJi7ka1r4587j8Le1eVmc3OfKYDJ7sZ2wxGfmOkdmoH4W0/09mF253SE4LijO/ bcs0onyPuINzEJSSpKWCKxdOBz873WimMdKpbMocHj1qVggOj8KEnvCRDqQbYH67eW W63Kl7geq1iKXj8JN4mg3h7DhIkc0IpfeTAZLwGI= Date: Fri, 21 May 2021 14:47:36 +0200 From: Greg KH To: Nathan Lynch Cc: linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, linux-kernel@vger.kernel.org, jirislaby@kernel.org Subject: Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN Message-ID: References: <20210514214422.3019105-1-nathanl@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514214422.3019105-1-nathanl@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: > hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN > when the underlying hcall returns a "busy" status, but udbg_hvc_putc() > doesn't handle this. When using xmon on a PowerVM guest, this can > result in incomplete or garbled output when printing relatively large > amounts of data quickly, such as when dumping the kernel log buffer. > > Call again on -EAGAIN. > > Signed-off-by: Nathan Lynch > --- > drivers/tty/hvc/hvc_vio.c | 2 +- Subject line does not match up with this file name. Don't you want "tty" and "hvc" in there somewhere? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8C6C433ED for ; Fri, 21 May 2021 12:48:15 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 877F3613D8 for ; Fri, 21 May 2021 12:48:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 877F3613D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FmmcD6QCmz3bw5 for ; Fri, 21 May 2021 22:48:12 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=c+cYJi7k; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=c+cYJi7k; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fmmbd5TWLz2xg1 for ; Fri, 21 May 2021 22:47:41 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1B2A2613CC; Fri, 21 May 2021 12:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621601258; bh=ENTtycla6YwFTERpKa9JcOnfx4HXvBKAO7BqN7/IJVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c+cYJi7ka1r4587j8Le1eVmc3OfKYDJ7sZ2wxGfmOkdmoH4W0/09mF253SE4LijO/ bcs0onyPuINzEJSSpKWCKxdOBz873WimMdKpbMocHj1qVggOj8KEnvCRDqQbYH67eW W63Kl7geq1iKXj8JN4mg3h7DhIkc0IpfeTAZLwGI= Date: Fri, 21 May 2021 14:47:36 +0200 From: Greg KH To: Nathan Lynch Subject: Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN Message-ID: References: <20210514214422.3019105-1-nathanl@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210514214422.3019105-1-nathanl@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: > hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN > when the underlying hcall returns a "busy" status, but udbg_hvc_putc() > doesn't handle this. When using xmon on a PowerVM guest, this can > result in incomplete or garbled output when printing relatively large > amounts of data quickly, such as when dumping the kernel log buffer. > > Call again on -EAGAIN. > > Signed-off-by: Nathan Lynch > --- > drivers/tty/hvc/hvc_vio.c | 2 +- Subject line does not match up with this file name. Don't you want "tty" and "hvc" in there somewhere? thanks, greg k-h