From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA550C47076 for ; Fri, 21 May 2021 15:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5E16613AE for ; Fri, 21 May 2021 15:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234223AbhEUPaw (ORCPT ); Fri, 21 May 2021 11:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232199AbhEUPav (ORCPT ); Fri, 21 May 2021 11:30:51 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AF09C0613CE for ; Fri, 21 May 2021 08:29:28 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id b7so10757501wmh.5 for ; Fri, 21 May 2021 08:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=lQZa3nF5KuYnerm4GLvju2DxCctG/p2J7D9NyuUkBqM=; b=dt1qnNiTnNH8FRdvLy1J/0tKQBFSQ3uYooI2fCgW3aJZqXUdbGz1sD0/Ycw3WiWQ7D tIEdeIg6H8Q51Kpxw4zMfOsDDeoyVeFkIowCThTaqaDhz38YNpr0BbtntTJ3M3izxMTh SxtALgBMTKAKnU/tJRQ/8ktg6DuDTMVBrPq9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=lQZa3nF5KuYnerm4GLvju2DxCctG/p2J7D9NyuUkBqM=; b=U0fMQ929q5hOTD4+As+dQl5bLL9RTCN2je7re4p7nndnDJBe6NfZBVKxiiRmlyexil RNaKeO8d/+hzvrEdWB6R/MwzC3+MMNg4VicR5O5R53IV81hUGFslnn2Lit1fiZibiv4K r8LPT4eiitRaM4Ce9QnuWEy0n6QbvXZwSaDDD4H0udeC8h/XHHX0xHSCNMD8KCzzCNQM d0xgPAWS1z0FyaUoNE6e5vqQqKKbtc4+DXmBV+ZU6xJr3m53Xb/QcMcYbna/ggvN1Ut0 9hPDa5oXI5bHTfnnazrjGIZ/ziVVeYga3/jldKVOU5J5WrUPuAdIUM6Nkov5fwUXuGZ4 kVDw== X-Gm-Message-State: AOAM53107qNXKPJEwL5edmGN2Vc5Y79suHpgqKMsEzJPRnmTyPe4/aab 2IV9gRkepX+w6c6uVeDWUOUGUg== X-Google-Smtp-Source: ABdhPJyXe0znQ5LDPzXI9ISS+1RysJAiGcv2EjlURPsfwLAa62NVbU2C5NMOIKrc6RPMqRg406Z4sg== X-Received: by 2002:a7b:cd16:: with SMTP id f22mr9489300wmj.8.1621610966950; Fri, 21 May 2021 08:29:26 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x4sm12492047wmj.17.2021.05.21.08.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 08:29:26 -0700 (PDT) Date: Fri, 21 May 2021 17:29:24 +0200 From: Daniel Vetter To: Vinod Koul Cc: Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , David Airlie , Daniel Vetter , Jonathan Marek , Dmitry Baryshkov , Abhinav Kumar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function Message-ID: Mail-Followup-To: Vinod Koul , Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , David Airlie , Jonathan Marek , Dmitry Baryshkov , Abhinav Kumar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20210521124946.3617862-1-vkoul@kernel.org> <20210521124946.3617862-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521124946.3617862-2-vkoul@kernel.org> X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, May 21, 2021 at 06:19:30PM +0530, Vinod Koul wrote: > We required a helper to create and set the dsc_dce_header, so add the > dsc_dce_header and API drm_dsc_dsi_pps_header_init > > Signed-off-by: Vinod Koul > --- > drivers/gpu/drm/drm_dsc.c | 11 +++++++++++ > include/drm/drm_dsc.h | 16 ++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c > index ff602f7ec65b..0c1b745090e2 100644 > --- a/drivers/gpu/drm/drm_dsc.c > +++ b/drivers/gpu/drm/drm_dsc.c > @@ -49,6 +49,17 @@ void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header) > } > EXPORT_SYMBOL(drm_dsc_dp_pps_header_init); > > +void drm_dsc_dsi_pps_header_init(struct dsc_dce_header *dsc_header) Kerneldoc for anything exported to drivers please, also ideally for all the structures. Thanks, Daniel > +{ > + memset(dsc_header, 0, sizeof(*dsc_header)); > + > + dsc_header->bp0 = 0x0A; > + dsc_header->bp1 = 1; > + dsc_header->bp4 = 10; > + dsc_header->bp6 = 128; > +} > +EXPORT_SYMBOL(drm_dsc_dsi_pps_header_init); > + > /** > * drm_dsc_dp_rc_buffer_size - get rc buffer size in bytes > * @rc_buffer_block_size: block size code, according to DPCD offset 62h > diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h > index bbe120f461e5..5a3bbeb3e12f 100644 > --- a/include/drm/drm_dsc.h > +++ b/include/drm/drm_dsc.h > @@ -602,8 +602,24 @@ struct drm_dsc_pps_infoframe { > struct drm_dsc_picture_parameter_set pps_payload; > } __packed; > > +struct dsc_dce_header { > + u8 bp0; > + u8 bp1; > + u8 bp2; > + u8 bp3; > + u8 bp4; > + u8 bp5; > + u8 bp6; > +} __packed; > + > +struct drm_dsi_dsc_infoframe { > + struct dsc_dce_header dsc_header; > + struct drm_dsc_picture_parameter_set pps_payload; > +} __packed; > + > void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header); > int drm_dsc_dp_rc_buffer_size(u8 rc_buffer_block_size, u8 rc_buffer_size); > +void drm_dsc_dsi_pps_header_init(struct dsc_dce_header *dsc_header); > void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_sdp, > const struct drm_dsc_config *dsc_cfg); > int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg); > -- > 2.26.3 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D07CCC4707A for ; Fri, 21 May 2021 15:29:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59AFC613AE for ; Fri, 21 May 2021 15:29:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59AFC613AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ACA3C6E82B; Fri, 21 May 2021 15:29:29 +0000 (UTC) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FF0D6E3BB for ; Fri, 21 May 2021 15:29:28 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id o127so11352325wmo.4 for ; Fri, 21 May 2021 08:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=lQZa3nF5KuYnerm4GLvju2DxCctG/p2J7D9NyuUkBqM=; b=dt1qnNiTnNH8FRdvLy1J/0tKQBFSQ3uYooI2fCgW3aJZqXUdbGz1sD0/Ycw3WiWQ7D tIEdeIg6H8Q51Kpxw4zMfOsDDeoyVeFkIowCThTaqaDhz38YNpr0BbtntTJ3M3izxMTh SxtALgBMTKAKnU/tJRQ/8ktg6DuDTMVBrPq9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=lQZa3nF5KuYnerm4GLvju2DxCctG/p2J7D9NyuUkBqM=; b=FbzRj8cdA7vZ42VS8VUzZ11udN4NB5/qLD6NGs4B2d0FjctYq5K7Z18lV8+aVlWXKr OlDTUlLJBM2/TIJHTF8hXYdSIuJWFSkaPlB2ikW206JzV7ok+QQRZaKzK5fmeA8moBOh Rwutkrp4In2jd0Hulg6XZpOOHw1LR6kQ+NklPs4qFMa5SeeSu9dLt0B1d3AQrfdR0h6c Mku4DjyDya8z4A2+CevCnEa4Y9cojBPVYp3N+SQTQ+Y80wPl24nK+U/YZLj/fjPo+Key TmMEr+O4OVTNOwZtdsiV7BeS/ntTQheKE8TjYNJ4CQ8xtRf6O6MdGzMrlG+d2dnaFaVP O86g== X-Gm-Message-State: AOAM531PeTmyTk7ikGQgzmuVlEfPN2Tqa3DrBFFwLtUueF1V+ev0FVc3 NnG36h1+9QttDAG4cG5WvHwecg== X-Google-Smtp-Source: ABdhPJyXe0znQ5LDPzXI9ISS+1RysJAiGcv2EjlURPsfwLAa62NVbU2C5NMOIKrc6RPMqRg406Z4sg== X-Received: by 2002:a7b:cd16:: with SMTP id f22mr9489300wmj.8.1621610966950; Fri, 21 May 2021 08:29:26 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x4sm12492047wmj.17.2021.05.21.08.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 08:29:26 -0700 (PDT) Date: Fri, 21 May 2021 17:29:24 +0200 From: Daniel Vetter To: Vinod Koul Subject: Re: [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function Message-ID: Mail-Followup-To: Vinod Koul , Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , David Airlie , Jonathan Marek , Dmitry Baryshkov , Abhinav Kumar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20210521124946.3617862-1-vkoul@kernel.org> <20210521124946.3617862-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521124946.3617862-2-vkoul@kernel.org> X-Operating-System: Linux phenom 5.10.32scarlett+ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Bjorn Andersson , dri-devel@lists.freedesktop.org, Dmitry Baryshkov , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 21, 2021 at 06:19:30PM +0530, Vinod Koul wrote: > We required a helper to create and set the dsc_dce_header, so add the > dsc_dce_header and API drm_dsc_dsi_pps_header_init > > Signed-off-by: Vinod Koul > --- > drivers/gpu/drm/drm_dsc.c | 11 +++++++++++ > include/drm/drm_dsc.h | 16 ++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c > index ff602f7ec65b..0c1b745090e2 100644 > --- a/drivers/gpu/drm/drm_dsc.c > +++ b/drivers/gpu/drm/drm_dsc.c > @@ -49,6 +49,17 @@ void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header) > } > EXPORT_SYMBOL(drm_dsc_dp_pps_header_init); > > +void drm_dsc_dsi_pps_header_init(struct dsc_dce_header *dsc_header) Kerneldoc for anything exported to drivers please, also ideally for all the structures. Thanks, Daniel > +{ > + memset(dsc_header, 0, sizeof(*dsc_header)); > + > + dsc_header->bp0 = 0x0A; > + dsc_header->bp1 = 1; > + dsc_header->bp4 = 10; > + dsc_header->bp6 = 128; > +} > +EXPORT_SYMBOL(drm_dsc_dsi_pps_header_init); > + > /** > * drm_dsc_dp_rc_buffer_size - get rc buffer size in bytes > * @rc_buffer_block_size: block size code, according to DPCD offset 62h > diff --git a/include/drm/drm_dsc.h b/include/drm/drm_dsc.h > index bbe120f461e5..5a3bbeb3e12f 100644 > --- a/include/drm/drm_dsc.h > +++ b/include/drm/drm_dsc.h > @@ -602,8 +602,24 @@ struct drm_dsc_pps_infoframe { > struct drm_dsc_picture_parameter_set pps_payload; > } __packed; > > +struct dsc_dce_header { > + u8 bp0; > + u8 bp1; > + u8 bp2; > + u8 bp3; > + u8 bp4; > + u8 bp5; > + u8 bp6; > +} __packed; > + > +struct drm_dsi_dsc_infoframe { > + struct dsc_dce_header dsc_header; > + struct drm_dsc_picture_parameter_set pps_payload; > +} __packed; > + > void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header); > int drm_dsc_dp_rc_buffer_size(u8 rc_buffer_block_size, u8 rc_buffer_size); > +void drm_dsc_dsi_pps_header_init(struct dsc_dce_header *dsc_header); > void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_sdp, > const struct drm_dsc_config *dsc_cfg); > int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg); > -- > 2.26.3 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch