From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 366C2C47081 for ; Sun, 23 May 2021 08:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B2DE60234 for ; Sun, 23 May 2021 08:18:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbhEWIUQ (ORCPT ); Sun, 23 May 2021 04:20:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:40204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbhEWIUP (ORCPT ); Sun, 23 May 2021 04:20:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AB4961168; Sun, 23 May 2021 08:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1621757928; bh=U0YAvZaLR8WDB/++plZoqCKo3gtUlnYXHKAqLTt8gr8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oPc0pz0dEPacRLTt9eTBIWButqRYE/XQ+Jy1WcfgbyZgnRYks466piY9L5/bR52ca 9aXd7M4YiLY3Kqs8xRoBZOX/3BZugaXSjcXKvDS1gWuHbJgppKflry2/6cqDsLRqEU Ji7yLOOTjyrg4dX+q2G94vmxfyVBi5Q22MQ+UtEs= Date: Sun, 23 May 2021 10:18:44 +0200 From: Greg Kroah-Hartman To: Lukas Bulwahn Cc: Jiri Slaby , Ralf Ramsauer , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 1/1] MAINTAINERS: TTY LAYER: add some ./include/linux/ header files Message-ID: References: <20210518052117.14819-1-lukas.bulwahn@gmail.com> <20210518052117.14819-2-lukas.bulwahn@gmail.com> <69da627e-91c5-66f0-c0c9-75fbaaba6782@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 23, 2021 at 09:05:48AM +0200, Lukas Bulwahn wrote: > On Tue, May 18, 2021 at 7:37 AM Jiri Slaby wrote: > > > > On 18. 05. 21, 7:21, Lukas Bulwahn wrote: > > > An early prototypical automated code analysis of headers and the > > > existing MAINTAINERS sections identified some header files in > > > ./include/linux/ to be probably included into the TTY LAYER section. > > > > > > I further checked those suggestions by this analysis and identified a > > > subset of files that I am rather certain to belong to the TTY LAYER. > > > > > > Add these ./include/linux/ header files to TTY LAYER in MAINTAINERS. > > > > > > The patterns include/linux/tty*.h and include/linux/vt_*.h currently cover: > > > > > > include/linux/tty.h > > > include/linux/tty_driver.h > > > include/linux/tty_flip.h > > > include/linux/tty_ldisc.h > > > > > > include/linux/vt_buffer.h > > > include/linux/vt_kern.h > > > > Yes, that looks good. > > > > Can you extend the tool to include/uapi too? > > > > For example this is missing too: > > include/uapi/linux/tty*.h > > > > It expands to: > > include/uapi/linux/tty_flags.h > > include/uapi/linux/tty.h > > > > Jiri, > > Greg already picked this patch up; so I will keep this patch as-is and move on. This patch was fine as-is, but sending an additional patch with that information added would be most welcome. No need for your tool to create it, you can do it by hand :) thanks, greg k-h