[GIT PULL FOR v5.14] imx7-mipi-csis driver improvements

[GIT PULL FOR v5.14] imx7-mipi-csis driver improvements

[Laurent Pinchart]

Hi Mauro,

The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5:

  Linux 5.13-rc1 (2021-05-09 14:17:44 -0700)

are available in the Git repository at:

  git://linuxtv.org/pinchartl/media.git tags/imx-20210519

for you to fetch changes up to 702077f1dd8ea4c0b6a91543b8d8946c77420ce8:

  media: imx: imx7_mipi_csis: Update MAINTAINERS (2021-05-19 03:36:26 +0300)

----------------------------------------------------------------
- Miscellaneous imx7-mipi-csis cleanups and fixes
- i.MX8MM support in the imx7-mipi-csis driver

----------------------------------------------------------------
Laurent Pinchart (25):
      media: imx: imx7_mipi_csis: Fix logging of only error event counters
      media: imx: imx7_mipi_csis: Count the CSI-2 debug interrupts
      media: imx: imx7_mipi_csis: Update ISP_CONFIG macros for quad pixel mode
      media: imx: imx7_mipi_csis: Move static data to top of mipi_csis_dump_regs()
      media: imx: imx7_mipi_csis: Minimize locking in get/set format
      media: imx: imx7_mipi_csis: Don't set subdev data
      media: imx: imx7_mipi_csis: Reorganize code in sections
      media: imx: imx7_mipi_csis: Set the CLKSETTLE register field
      media: imx: imx7_mipi_csis: Drop unused csis_hw_reset structure
      media: imx: imx7_mipi_csis: Store CSI-2 data type in format structure
      media: imx: imx7_mipi_csis: Drop csi_state phy field
      media: imx: imx7_mipi_csis: Rename mipi_sd to sd
      media: imx: imx7_mipi_csis: Rename csi_state flag field to state
      media: imx: imx7_mipi_csis: Turn csi_state irq field into local variable
      media: imx: imx7_mipi_csis: Don't pass pdev to mipi_csis_parse_dt()
      media: imx: imx7_mipi_csis: Pass csi_state to mipi_csis_subdev_init()
      media: imx: imx7_mipi_csis: Drop csi_state pdev field
      media: imx: imx7_mipi_csis: Make csi_state num_clocks field unsigned
      media: imx: imx7_mipi_csis: Reorganize csi_state structure
      media: imx: imx7_mipi_csis: Reorganize mipi_csis_probe()
      media: imx: imx7_mipi_csis: Reject invalid data-lanes settings
      media: imx: imx7_mipi_csis: Move PHY control to dedicated functions
      dt-bindings: media: nxp,imx7-mipi-csi2: Add i.MX8MM support
      media: imx: imx7_mipi_csis: Add i.MX8MM support
      media: imx: imx7_mipi_csis: Update MAINTAINERS

 .../devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml      | 109 ++-
 MAINTAINERS                                                |   1 +
 drivers/staging/media/imx/imx7-mipi-csis.c                 | 994 ++++++++++++++-----------
 3 files changed, 658 insertions(+), 446 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [GIT PULL FOR v5.14] imx7-mipi-csis driver improvements (#74349)

[Jenkins]

From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/YKReJdBSV9yIXfxt@pendragon.ideasonboard.com/
Build log: https://builder.linuxtv.org/job/patchwork/107748/
Build time: 00:23:35
Link: https://lore.kernel.org/linux-media/YKReJdBSV9yIXfxt@pendragon.ideasonboard.com

gpg: Signature made Wed 19 May 2021 12:37:13 AM UTC
gpg:                using RSA key CB9D6877529820CD53099B1B65F89C37BC54210D
gpg:                issuer "laurent.pinchart@ideasonboard.com"
gpg: Can't check signature: No public key

Summary: got 2/25 patches with issues, being 1 at build time, plus one error when buinding PDF document

Error/warnings:

patches/0001-media-imx-imx7_mipi_csis-Fix-logging-of-only-error-e.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]

    allyesconfig: return code #0:
	SPARSE:../drivers/media/cec/core/cec-core.c ../include/asm-generic/bitops/find.h:90:32:  warning: shift count is negative (-192)
	SPARSE:../drivers/media/mc/mc-devnode.c ../include/asm-generic/bitops/find.h:90:32:  warning: shift count is negative (-192)
	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1424 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1929 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/platform/exynos4-is/media-dev.c:1287:6: warning: unused variable ‘ret’ [-Wunused-variable]
	../drivers/media/platform/davinci/vpif_display.c:114: warning: Function parameter or member 'nplanes' not described in 'vpif_buffer_queue_setup'
	../drivers/media/platform/davinci/vpif_capture.c:112: warning: Function parameter or member 'nplanes' not described in 'vpif_buffer_queue_setup'
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2856 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

    allmodconfig: return code #0:
	../drivers/media/platform/exynos4-is/media-dev.c:1287:6: warning: unused variable ‘ret’ [-Wunused-variable]

patches/0003-media-imx-imx7_mipi_csis-Update-ISP_CONFIG-macros-fo.patch:

   checkpatch.pl:
	$ cat patches/0003-media-imx-imx7_mipi_csis-Update-ISP_CONFIG-macros-fo.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:28: CHECK: Prefer using the BIT macro


Error #512 when building PDF docs

Re: [GIT PULL FOR v5.14] imx7-mipi-csis driver improvements (#74349)

[Laurent Pinchart]

Hi Mauro,

On Wed, May 19, 2021 at 01:10:15AM +0000, Jenkins wrote:
> From: builder@linuxtv.org
> 
> Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/YKReJdBSV9yIXfxt@pendragon.ideasonboard.com/
> Build log: https://builder.linuxtv.org/job/patchwork/107748/
> Build time: 00:23:35
> Link: https://lore.kernel.org/linux-media/YKReJdBSV9yIXfxt@pendragon.ideasonboard.com
> 
> gpg: Signature made Wed 19 May 2021 12:37:13 AM UTC
> gpg:                using RSA key CB9D6877529820CD53099B1B65F89C37BC54210D
> gpg:                issuer "laurent.pinchart@ideasonboard.com"
> gpg: Can't check signature: No public key
> 
> Summary: got 2/25 patches with issues, being 1 at build time, plus one error when buinding PDF document
> 
> Error/warnings:
> 
> patches/0001-media-imx-imx7_mipi_csis-Fix-logging-of-only-error-e.patch:
> 
>     allyesconfig: return code #0:
> 	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
> 	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
> 
>     allyesconfig: return code #0:
> 	SPARSE:../drivers/media/cec/core/cec-core.c ../include/asm-generic/bitops/find.h:90:32:  warning: shift count is negative (-192)
> 	SPARSE:../drivers/media/mc/mc-devnode.c ../include/asm-generic/bitops/find.h:90:32:  warning: shift count is negative (-192)
> 	SPARSE:../drivers/media/v4l2-core/v4l2-dev.c ../include/asm-generic/bitops/find.h:132:46:  warning: shift count is negative (-192)
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:268 v4l_print_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:292 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:302 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:328 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:347 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:352 v4l_print_format() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:362 v4l_print_framebuffer() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:735 v4l_print_frmsizeenum() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:762 v4l_print_frmivalenum() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/v4l2-core/v4l2-ioctl.c: ../drivers/media/v4l2-core/v4l2-ioctl.c:1424 v4l_fill_fmtdesc() error: unrecognized %p extension '4', treated as normal %p
> 	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1929 vivid_create_instance() parse error: turning off implications after 60 seconds
> 	../drivers/media/platform/exynos4-is/media-dev.c:1287:6: warning: unused variable ‘ret’ [-Wunused-variable]
> 	../drivers/media/platform/davinci/vpif_display.c:114: warning: Function parameter or member 'nplanes' not described in 'vpif_buffer_queue_setup'
> 	../drivers/media/platform/davinci/vpif_capture.c:112: warning: Function parameter or member 'nplanes' not described in 'vpif_buffer_queue_setup'
> 	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2856 em28xx_v4l2_init() parse error: turning off implications after 60 seconds
> 
>     allmodconfig: return code #0:
> 	../drivers/media/platform/exynos4-is/media-dev.c:1287:6: warning: unused variable ‘ret’ [-Wunused-variable]

I don't think my patch is responsible for all this :-)

> patches/0003-media-imx-imx7_mipi_csis-Update-ISP_CONFIG-macros-fo.patch:
> 
>    checkpatch.pl:
> 	$ cat patches/0003-media-imx-imx7_mipi_csis-Update-ISP_CONFIG-macros-fo.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
> 	-:28: CHECK: Prefer using the BIT macro

This is a false positive.

> Error #512 when building PDF docs

-- 
Regards,

Laurent Pinchart