From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BA7C2B9F8 for ; Mon, 24 May 2021 11:47:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 283C661289 for ; Mon, 24 May 2021 11:47:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232753AbhEXLtF (ORCPT ); Mon, 24 May 2021 07:49:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232553AbhEXLtE (ORCPT ); Mon, 24 May 2021 07:49:04 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A463C061574; Mon, 24 May 2021 04:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UEO6EAq0B/BZq9m5Zu1X6wIqhfXCfA6vaV6yeUoFwnk=; b=Or7cMQ7Nzl98SOGOLDHWQs5AkK kd6QvgbIiLkHCNig8TZkoK4Qk6eNVlF8A1kPxiWTx3ZYBfDZPOecUnZcvWOhgRctNgCnWdwgB/Qkx vLz/kHulVD5Q6nuLTMUhcHWhdHOikWBkftygJrUaInoHHfJgHwqdSvdqSKR/pHk8CGtAnPw9D02tj DyDijYr5PtZjidf15hDW7+YrgdJ2t2IoCJ5Jbiw/8ca42BSrgNbBytwINWR8pyZ0gSJbhKsaUYEpa XRN2E5K6gLTLC74ituBPeZOM9HNyHtpT5HLvKmUofGtlt98U4zea5TdBHH9bPhlQAy+2O52rgjPuk bCEGnSFg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1ll92Q-002KEc-QT; Mon, 24 May 2021 11:46:31 +0000 Date: Mon, 24 May 2021 12:46:26 +0100 From: Christoph Hellwig To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH 0/6] Don't use BIT() macro in UAPI headers Message-ID: References: <20210520104343.317119-1-joerichey94@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520104343.317119-1-joerichey94@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 03:43:37AM -0700, Joe Richey wrote: > This patch series changes all UAPI uses of BIT() to just be open-coded. > However, there really should be a check for this in checkpatch.pl > Currently, the script actually _encourages_ users to use the BIT macro > even if adding things to UAPI. Yes. In fact it should warn about BIT() in general. It is totally pointless obsfucation that doesn't even save any typing at all. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BE9C2B9F7 for ; Tue, 25 May 2021 01:36:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 245B860FE3 for ; Tue, 25 May 2021 01:36:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 245B860FE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r+rHdOFm/wLBShr0oHheoPRPgn1m4X8HrDXHwLLKm5A=; b=zW1UrjGNHm0e3Q TYyVB+ybI3WNuPICdj/mXQt3qqjFpiglTmRJpkUN1+KRWTKapjcSgX6OzemYitbDAwqnmNI5JQn+v Mm100VlIhFtLoF1VbkDebUzIDMHZVPySQ1ZZzqnhh1iVNblQ/+D3HaGfE3UVwa02edQjDvCLQoAXR 5Insv+qqX5CttxbP6k7I6k3j+IO5yM2AkTfASaGAdLkg5BzyXyKVyTEKuEttnso+dzlUsJqukVJCt 6D1NBDPbWC6Qye0CIR6XPWvqT/ylvMe6PFHXZj1M+q4yifUmdfITbuyG950tdL1ua5C09Bln7g/Q/ q+hg+0hrJCEUDwzbifYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llLxd-002m3u-UJ; Tue, 25 May 2021 01:34:22 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llGuP-001nHN-3c for linux-arm-kernel@bombadil.infradead.org; Mon, 24 May 2021 20:10:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UEO6EAq0B/BZq9m5Zu1X6wIqhfXCfA6vaV6yeUoFwnk=; b=Or7cMQ7Nzl98SOGOLDHWQs5AkK kd6QvgbIiLkHCNig8TZkoK4Qk6eNVlF8A1kPxiWTx3ZYBfDZPOecUnZcvWOhgRctNgCnWdwgB/Qkx vLz/kHulVD5Q6nuLTMUhcHWhdHOikWBkftygJrUaInoHHfJgHwqdSvdqSKR/pHk8CGtAnPw9D02tj DyDijYr5PtZjidf15hDW7+YrgdJ2t2IoCJ5Jbiw/8ca42BSrgNbBytwINWR8pyZ0gSJbhKsaUYEpa XRN2E5K6gLTLC74ituBPeZOM9HNyHtpT5HLvKmUofGtlt98U4zea5TdBHH9bPhlQAy+2O52rgjPuk bCEGnSFg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1ll92Q-002KEc-QT; Mon, 24 May 2021 11:46:31 +0000 Date: Mon, 24 May 2021 12:46:26 +0100 From: Christoph Hellwig To: Joe Richey Cc: trivial@kernel.org, Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org Subject: Re: [PATCH 0/6] Don't use BIT() macro in UAPI headers Message-ID: References: <20210520104343.317119-1-joerichey94@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210520104343.317119-1-joerichey94@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 03:43:37AM -0700, Joe Richey wrote: > This patch series changes all UAPI uses of BIT() to just be open-coded. > However, there really should be a check for this in checkpatch.pl > Currently, the script actually _encourages_ users to use the BIT macro > even if adding things to UAPI. Yes. In fact it should warn about BIT() in general. It is totally pointless obsfucation that doesn't even save any typing at all. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel