All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Dario Binacchi <dariobin@libero.it>,
	linux-kernel@vger.kernel.org, Drew Fustini <drew@beagleboard.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file
Date: Tue, 25 May 2021 08:15:12 +0300	[thread overview]
Message-ID: <YKyH4BPypsfXiw1o@atomide.com> (raw)
In-Reply-To: <414c9176-7922-929f-e82e-f80f07e91b2c@mleia.com>

Hi,

* Vladimir Zapolskiy <vz@mleia.com> [210524 18:52]:
> Thus a higher level of abstraction is wanted:
> 
> * writing data to I/O mem -- not good enough,
> * writing data to pinmux/pinconf I/O mem -- better, but not good enough,
> * writing *valid* data to pinmux/pinconf I/O mem -- that's right.
> 
> The validity of data is defined by a developer, the abstraction name
> has been mentioned multiple times, it's pin groups and pin group functions.

Sounds like the planned interface should only allow changing between
already defined pingroups, and only if the pins are unclaimed. That
would leave out the issues tinkering with raw register data.

And it probably should also allow adding and removing new pingroups out
of the already defined pin functions that are unclaimed.

I also think such interface should be sysfs and not debugfs eventually.

Regards,

Tony

  reply	other threads:[~2021-05-25  5:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 20:27 [PATCH v3 0/3] am335x: set pinmux registers from pins debug file Dario Binacchi
2021-05-20 20:27 ` Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 1/3] docs/pinctrl: update `pins' description under debugfs Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file Dario Binacchi
2021-05-21  6:44   ` Vladimir Zapolskiy
2021-05-24 17:28     ` Dario Binacchi
2021-05-24 18:52       ` Vladimir Zapolskiy
2021-05-25  5:15         ` Tony Lindgren [this message]
2021-05-27 19:23         ` Dario Binacchi
2021-05-27 19:57           ` Vladimir Zapolskiy
2021-05-27 20:33             ` Dario Binacchi
2021-05-28  8:34               ` Vladimir Zapolskiy
2021-05-28  9:07               ` Linus Walleij
2021-06-02  5:03                 ` Tony Lindgren
2021-06-11  8:29                   ` Dario Binacchi
2021-05-20 20:27 ` [PATCH v3 3/3] pinctrl: single: set " Dario Binacchi
2021-05-20 20:27   ` Dario Binacchi
2021-05-21  6:44   ` Vladimir Zapolskiy
2021-05-21  6:44     ` Vladimir Zapolskiy
2021-05-25  0:18 ` [PATCH v3 0/3] am335x: set pinmux registers " Linus Walleij
2021-05-25  0:18   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKyH4BPypsfXiw1o@atomide.com \
    --to=tony@atomide.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dariobin@libero.it \
    --cc=drew@beagleboard.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.