From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8C9C47084 for ; Tue, 25 May 2021 07:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E215610CB for ; Tue, 25 May 2021 07:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231478AbhEYHJw (ORCPT ); Tue, 25 May 2021 03:09:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbhEYHJu (ORCPT ); Tue, 25 May 2021 03:09:50 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34EFAC061574; Tue, 25 May 2021 00:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DoIbSCZTbEoN70AvyZhpVM+9DseLPlFDyKptyhG0ieA=; b=AILSOYTr/eYzC8gkl6dwpUFWua xH/saKYH8uSCGZYaC1kybPIRbisbATdGGSrIxuUlEQ6mxr8bvChEkJIqlFKkSjmDQXhgc1JLtde+/ FgPSiwfAzlIhulNAhGpKp4VCSmvL5rhHERaiBJ1TjxMkL3tjvsImj30DHrzS/o9Wd91W4W6s9w5QT QtUvd1qz+JRvwUjn5ebT/xm8JMWp1qp9vaTKZMEs3Zdvl3g7JWnwywU/EV277SMUlr8O9oWSOpXx4 U+clAnJVrLFA6vACuUDvRpic4nzVWGVQbR78HxhZpsQ6klC+nR38PY00J8s5mczvwfAYP+7qwtaxA PL0qkh/A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1llR9v-003DP1-64; Tue, 25 May 2021 07:07:29 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7BE653001E4; Tue, 25 May 2021 09:07:22 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 363C131474564; Tue, 25 May 2021 09:07:22 +0200 (CEST) Date: Tue, 25 May 2021 09:07:22 +0200 From: Peter Zijlstra To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Johannes Berg , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Julian Braha , linux-arch@vger.kernel.org Subject: Re: [PATCH v2] LOCKDEP: reduce LOCKDEP dependency list Message-ID: References: <20210524224150.8009-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210524224150.8009-1-rdunlap@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 03:41:50PM -0700, Randy Dunlap wrote: > Some arches (um, sparc64, riscv, xtensa) cause a Kconfig warning for > LOCKDEP. > These arch-es select LOCKDEP_SUPPORT but they are not listed as one > of the arch-es that LOCKDEP depends on. > > Since (16) arch-es define the Kconfig symbol LOCKDEP_SUPPORT if they > intend to have LOCKDEP support, replace the awkward list of > arch-es that LOCKDEP depends on with the LOCKDEP_SUPPORT symbol. > > But wait. LOCKDEP_SUPPORT is included in LOCK_DEBUGGING_SUPPORT, > which is already a dependency here, so LOCKDEP_SUPPORT is redundant > and not needed. > That leaves the FRAME_POINTER dependency, but it is part of an > expression like this: > depends on (A && B) && (FRAME_POINTER || B') > where B' is a dependency of B so if B is true then B' is true > and the value of FRAME_POINTER does not matter. > Thus we can also delete the FRAME_POINTER dependency. > > Fixes this kconfig warning: (for um, sparc64, riscv, xtensa) > > WARNING: unmet direct dependencies detected for LOCKDEP > Depends on [n]: DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] && (FRAME_POINTER [=n] || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86) > Selected by [y]: > - PROVE_LOCKING [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] > - LOCK_STAT [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] > - DEBUG_LOCK_ALLOC [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] > > Link to v1: https://lore.kernel.org/lkml/20210517034430.9569-1-rdunlap@infradead.org/ > > Fixes: 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS") > Signed-off-by: Randy Dunlap Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 25 May 2021 09:07:22 +0200 From: Peter Zijlstra Subject: Re: [PATCH v2] LOCKDEP: reduce LOCKDEP dependency list Message-ID: References: <20210524224150.8009-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210524224150.8009-1-rdunlap@infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Johannes Berg , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Julian Braha , linux-arch@vger.kernel.org On Mon, May 24, 2021 at 03:41:50PM -0700, Randy Dunlap wrote: > Some arches (um, sparc64, riscv, xtensa) cause a Kconfig warning for > LOCKDEP. > These arch-es select LOCKDEP_SUPPORT but they are not listed as one > of the arch-es that LOCKDEP depends on. > > Since (16) arch-es define the Kconfig symbol LOCKDEP_SUPPORT if they > intend to have LOCKDEP support, replace the awkward list of > arch-es that LOCKDEP depends on with the LOCKDEP_SUPPORT symbol. > > But wait. LOCKDEP_SUPPORT is included in LOCK_DEBUGGING_SUPPORT, > which is already a dependency here, so LOCKDEP_SUPPORT is redundant > and not needed. > That leaves the FRAME_POINTER dependency, but it is part of an > expression like this: > depends on (A && B) && (FRAME_POINTER || B') > where B' is a dependency of B so if B is true then B' is true > and the value of FRAME_POINTER does not matter. > Thus we can also delete the FRAME_POINTER dependency. > > Fixes this kconfig warning: (for um, sparc64, riscv, xtensa) > > WARNING: unmet direct dependencies detected for LOCKDEP > Depends on [n]: DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] && (FRAME_POINTER [=n] || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86) > Selected by [y]: > - PROVE_LOCKING [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] > - LOCK_STAT [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] > - DEBUG_LOCK_ALLOC [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] > > Link to v1: https://lore.kernel.org/lkml/20210517034430.9569-1-rdunlap@infradead.org/ > > Fixes: 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTERS") > Signed-off-by: Randy Dunlap Thanks! _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um