From: Michal Hocko <mhocko@suse.com>
To: 陈冠有 <chenguanyou9338@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
lukas.bulwahn@gmail.com, vbabka@suse.cz, gpiccoli@canonical.com,
chenguanyou <chenguanyou@xiaomi.com>
Subject: Re: [PATCH] hungtask: add filter kthread/check comm
Date: Tue, 25 May 2021 09:26:14 +0200 [thread overview]
Message-ID: <YKymlullP1wuT+UE@dhcp22.suse.cz> (raw)
In-Reply-To: <CAHS3RMWjuB98TzvcYyQ0qtNYOxDeM7W1YmyqDYs=H-cn-VsVdw@mail.gmail.com>
On Tue 25-05-21 11:27:16, 陈冠有 wrote:
[...]
> These are MTK's LPM designs.
No idea what those are but it seems like an out of tree code.
> If we have linux-api, hungtask can choose to skip kthread, helpful for us
> to debug user space threads in "state=D" when enable hungtask panic.
No, this approach is wrong. You are trying to workaround an incorrect
out of tree code by creating a user visible API. I have already brought
that up in earlier version of this patch.
Nacked-by: Michal Hocko <mhocko@suse.com>
Andrew has already given you a lead on how to fix the said code. Use
TASK_IDLE when waiting for an event. This will both hide that waiting
task from load average accounting and also from the hung task detector.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-05-25 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 13:25 [PATCH] hungtask: add filter kthread/check comm chenguanyou
2021-05-22 21:51 ` Andrew Morton
[not found] ` <CAHS3RMWjuB98TzvcYyQ0qtNYOxDeM7W1YmyqDYs=H-cn-VsVdw@mail.gmail.com>
2021-05-25 7:26 ` Michal Hocko [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-21 13:25 chenguanyou
2021-05-21 16:37 ` Randy Dunlap
2021-05-19 12:13 chenguanyou
2021-05-19 13:06 ` Michal Hocko
2021-05-19 17:53 ` Randy Dunlap
[not found] ` <CAHS3RMVYbHTzD6JnOmE331qSbcnvuYnBe0jraNuuLc0Z2NnStg@mail.gmail.com>
2021-05-21 8:31 ` Michal Hocko
2021-05-18 11:16 chenguanyou
2021-05-19 11:28 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKymlullP1wuT+UE@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=chenguanyou9338@gmail.com \
--cc=chenguanyou@xiaomi.com \
--cc=gpiccoli@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.