From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D400C2B9F8 for ; Tue, 25 May 2021 08:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AB4E613F9 for ; Tue, 25 May 2021 08:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbhEYIPs (ORCPT ); Tue, 25 May 2021 04:15:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231133AbhEYIPs (ORCPT ); Tue, 25 May 2021 04:15:48 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07D3AC061574 for ; Tue, 25 May 2021 01:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IS8oe6DWcJGa9bQBBDi4fccLjfq1qMG9DdtD8Ef9/pA=; b=aiGi4Md1RIbLISctPoP6SRTcG3 OwRilm7WXXMZln8sJRa9s8mLMuBmxt8mR6p5Fvu7B7C2124hVmzWe29C0VG25AhXc8j1Q9L1e7DLd ql0Kh62XJVHxRaQO9xu9ATLkOI4hNUlHSpChLLY6ldsVTKThQEq4pTCzsOqwM9LkbRnjqj8TjL8Sb K9MTg3O+i6I7wh3YNJGqe3GLWRzlVz5F+7Pn8mMR8qg714lBRLoCqWv41wtUG6oZDfDCRcSTLBJ32 ptnS6ymrx6uccViu0zU+NN5ZQVWDRyFp0DWCi03Z3fR9U8o1SeNq9U3paviyeC2NA6DNLKJtbenT+ 2yOXsitQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1llSC4-003GjB-W0; Tue, 25 May 2021 08:13:47 +0000 Date: Tue, 25 May 2021 09:13:40 +0100 From: Christoph Hellwig To: Damien Le Moal Cc: dm-devel@redhat.com, Mike Snitzer , linux-block@vger.kernel.org, Jens Axboe Subject: Re: [PATCH v4 05/11] dm: cleanup device_area_is_invalid() Message-ID: References: <20210525022539.119661-1-damien.lemoal@wdc.com> <20210525022539.119661-6-damien.lemoal@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210525022539.119661-6-damien.lemoal@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, May 25, 2021 at 11:25:33AM +0900, Damien Le Moal wrote: > In device_area_is_invalid(), use bdev_is_zoned() instead of open > coding the test on the zoned model returned by bdev_zoned_model(). > > Signed-off-by: Damien Le Moal > Reviewed-by: Johannes Thumshirn > Reviewed-by: Hannes Reinecke Looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F54DC2B9F8 for ; Tue, 25 May 2021 08:14:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD26961400 for ; Tue, 25 May 2021 08:14:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD26961400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-323-cd1NbvwwMbCRBO2EC6LQ9g-1; Tue, 25 May 2021 04:14:21 -0400 X-MC-Unique: cd1NbvwwMbCRBO2EC6LQ9g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2BEC800D62; Tue, 25 May 2021 08:14:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B3F91037F20; Tue, 25 May 2021 08:14:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DEA4B180B463; Tue, 25 May 2021 08:14:14 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14P8EEkS023054 for ; Tue, 25 May 2021 04:14:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 070E22077FB5; Tue, 25 May 2021 08:14:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01A6E2077FA9 for ; Tue, 25 May 2021 08:14:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCF7D800B31 for ; Tue, 25 May 2021 08:14:07 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-n9Q77fWpO42QkZt5r3t2Tg-1; Tue, 25 May 2021 04:14:05 -0400 X-MC-Unique: n9Q77fWpO42QkZt5r3t2Tg-1 Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1llSC4-003GjB-W0; Tue, 25 May 2021 08:13:47 +0000 Date: Tue, 25 May 2021 09:13:40 +0100 From: Christoph Hellwig To: Damien Le Moal Message-ID: References: <20210525022539.119661-1-damien.lemoal@wdc.com> <20210525022539.119661-6-damien.lemoal@wdc.com> MIME-Version: 1.0 In-Reply-To: <20210525022539.119661-6-damien.lemoal@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: linux-block@vger.kernel.org, Jens Axboe , dm-devel@redhat.com, Mike Snitzer Subject: Re: [dm-devel] [PATCH v4 05/11] dm: cleanup device_area_is_invalid() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, May 25, 2021 at 11:25:33AM +0900, Damien Le Moal wrote: > In device_area_is_invalid(), use bdev_is_zoned() instead of open > coding the test on the zoned model returned by bdev_zoned_model(). > > Signed-off-by: Damien Le Moal > Reviewed-by: Johannes Thumshirn > Reviewed-by: Hannes Reinecke Looks good, Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel