All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
	linux-kernel@vger.kernel.org,
	Peter Robinson <pbrobinson@gmail.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names
Date: Tue, 25 May 2021 15:08:13 +0200	[thread overview]
Message-ID: <YKz2vbxYXSKQE1Ng@phenom.ffwll.local> (raw)
In-Reply-To: <fc6540fa-1945-a15d-239d-e87bb4d3fa9e@suse.de>

On Fri, May 21, 2021 at 08:53:56PM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 21.05.21 um 19:18 schrieb Javier Martinez Canillas:
> > On 5/21/21 6:53 PM, Thomas Zimmermann wrote:
> > 
> > [snip]
> > 
> > > > 
> > > > So what with all the drivers which do _not_ have drm in their name? Also
> > > > I'm never sure how much these are uapi or not ...
> > > 
> > 
> > That someone could threat as an uapi is a fair point indeed.
> > > Why do we need a suffix anyway?
> > > 
> > 
> > Yes, I thought the same and was torn about posting a patch to just remove
> > the suffix. I don't think users care that much if is a fb device from a
> > fbdev driver or a DRM driver using the fbdev emulation.
> 
> Yup. I don't see how anything in userspace would depend on the exact name;
> especially since fbdev emulation only provides basic features. (I'd welcome
> a counter examples that proves me wrong.)
> 
> IMHO we can risk it to remove the suffix entirely. But that needs an ack
> from Daniel or Dave.

If you guys with your distro hats on all think it doesn't matter, then
yeah I'm all for dropping the somewhat silly -drm or drmfb suffixes. I
think that was just way back so it's easier to know you've loaded the
right driver, back when there was both drm and native fbdev drivers
around. But now I think for new hw there's only drm, so should be all
fine.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID
From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Javier Martinez Canillas <javierm@redhat.com>,
	linux-kernel@vger.kernel.org,
	Peter Robinson <pbrobinson@gmail.com>
Subject: Re: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names
Date: Tue, 25 May 2021 15:08:13 +0200	[thread overview]
Message-ID: <YKz2vbxYXSKQE1Ng@phenom.ffwll.local> (raw)
In-Reply-To: <fc6540fa-1945-a15d-239d-e87bb4d3fa9e@suse.de>

On Fri, May 21, 2021 at 08:53:56PM +0200, Thomas Zimmermann wrote:
> Hi
> 
> Am 21.05.21 um 19:18 schrieb Javier Martinez Canillas:
> > On 5/21/21 6:53 PM, Thomas Zimmermann wrote:
> > 
> > [snip]
> > 
> > > > 
> > > > So what with all the drivers which do _not_ have drm in their name? Also
> > > > I'm never sure how much these are uapi or not ...
> > > 
> > 
> > That someone could threat as an uapi is a fair point indeed.
> > > Why do we need a suffix anyway?
> > > 
> > 
> > Yes, I thought the same and was torn about posting a patch to just remove
> > the suffix. I don't think users care that much if is a fb device from a
> > fbdev driver or a DRM driver using the fbdev emulation.
> 
> Yup. I don't see how anything in userspace would depend on the exact name;
> especially since fbdev emulation only provides basic features. (I'd welcome
> a counter examples that proves me wrong.)
> 
> IMHO we can risk it to remove the suffix entirely. But that needs an ack
> from Daniel or Dave.

If you guys with your distro hats on all think it doesn't matter, then
yeah I'm all for dropping the somewhat silly -drm or drmfb suffixes. I
think that was just way back so it's easier to know you've loaded the
right driver, back when there was both drm and native fbdev drivers
around. But now I think for new hw there's only drm, so should be all
fine.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2021-05-25 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 13:19 Javier Martinez Canillas
2021-05-21 13:19 ` Javier Martinez Canillas
2021-05-21 15:33 ` Daniel Vetter
2021-05-21 15:33   ` Daniel Vetter
2021-05-21 16:53   ` Thomas Zimmermann
2021-05-21 17:18     ` Javier Martinez Canillas
2021-05-21 18:53       ` Thomas Zimmermann
2021-05-25 13:08         ` Daniel Vetter [this message]
2021-05-25 13:08           ` Daniel Vetter
2021-05-25 13:34           ` Thomas Zimmermann
2021-05-25 13:52             ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKz2vbxYXSKQE1Ng@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=tzimmermann@suse.de \
    --subject='Re: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.