From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 333B4C2B9F8 for ; Tue, 25 May 2021 13:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 107356141B for ; Tue, 25 May 2021 13:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233076AbhEYNJw (ORCPT ); Tue, 25 May 2021 09:09:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232862AbhEYNJq (ORCPT ); Tue, 25 May 2021 09:09:46 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31B3C061574 for ; Tue, 25 May 2021 06:08:16 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id p24so45987561ejb.1 for ; Tue, 25 May 2021 06:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=J3i7sySuF9vAMwjRduq9o4pZBENGbTDxWuaAXXo5lxM=; b=CUcTIB0jGV2498eTndtJ4dsxx9tU25S/huYWnqhhT16rMypCIkW2OSS2dEjs/ScD2/ z6Oy6LTaUwdiQWKocdpHw/s4akCqzh3aFWaPuPl6h3FUY9uPGaFaDbs19ONFxN2lFxmk tiUlt5+GP9TsqYQrWQGwSV/5rZ/PXdNuRFves= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=J3i7sySuF9vAMwjRduq9o4pZBENGbTDxWuaAXXo5lxM=; b=X+/wieyr2UpbPKZ4gDVFTuMPRBhwU3Gu4I9P7/XSoAEwLJeCBWWFOBf9lLkkG0yZea oSSLQGpwgAuNysmHOLut0D8cBHR+CBpLz2GQqKZDRIlHp737HmI06JKrWNa8YNobIVo9 1d+FOr5StaRqeOZ76fGwYl8VnUp0XMWNvuo/fnzAjstpbHz93f0oc33q6553fyDIhyhU QfOiKOEzqV8k3ORnJhx7jICPmQHKP5ZbVByGFX1tkjWA50hcoEBjRn3oXqAZBMUolm5l UyP8PSPGQVVLE7ga6LbH7SIzANwoVwo/ugmVNP9v4pHnaDvMTs2R948es3lm1RQqGYJ7 bHLg== X-Gm-Message-State: AOAM53336cxk/60CKaOKVwpgd5aGJ23wuepVIwZOH31wylyXIEk2IkvJ T4vviTeqES97UZSFA47i4pV/Ag== X-Google-Smtp-Source: ABdhPJxXJHDlcz+lHAfC3eMn2DkJLakk8UYTxiXf4gRAsmQw7xJyIhqyJL0QLeuwZ9Zpjh38P9PnUA== X-Received: by 2002:a17:906:3ed0:: with SMTP id d16mr28105603ejj.16.1621948095527; Tue, 25 May 2021 06:08:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u21sm9007517ejg.50.2021.05.25.06.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 06:08:14 -0700 (PDT) Date: Tue, 25 May 2021 15:08:13 +0200 From: Daniel Vetter To: Thomas Zimmermann Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Peter Robinson , David Airlie , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names Message-ID: Mail-Followup-To: Thomas Zimmermann , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Peter Robinson , David Airlie , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org References: <20210521131910.3000689-1-javierm@redhat.com> <3a6f9235-5375-b2cb-2d63-a47c5f9752bb@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 08:53:56PM +0200, Thomas Zimmermann wrote: > Hi > > Am 21.05.21 um 19:18 schrieb Javier Martinez Canillas: > > On 5/21/21 6:53 PM, Thomas Zimmermann wrote: > > > > [snip] > > > > > > > > > > So what with all the drivers which do _not_ have drm in their name? Also > > > > I'm never sure how much these are uapi or not ... > > > > > > > That someone could threat as an uapi is a fair point indeed. > > > Why do we need a suffix anyway? > > > > > > > Yes, I thought the same and was torn about posting a patch to just remove > > the suffix. I don't think users care that much if is a fb device from a > > fbdev driver or a DRM driver using the fbdev emulation. > > Yup. I don't see how anything in userspace would depend on the exact name; > especially since fbdev emulation only provides basic features. (I'd welcome > a counter examples that proves me wrong.) > > IMHO we can risk it to remove the suffix entirely. But that needs an ack > from Daniel or Dave. If you guys with your distro hats on all think it doesn't matter, then yeah I'm all for dropping the somewhat silly -drm or drmfb suffixes. I think that was just way back so it's easier to know you've loaded the right driver, back when there was both drm and native fbdev drivers around. But now I think for new hw there's only drm, so should be all fine. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFE1C2B9F8 for ; Tue, 25 May 2021 13:08:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD1AD6052B for ; Tue, 25 May 2021 13:08:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD1AD6052B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A245B890AB; Tue, 25 May 2021 13:08:19 +0000 (UTC) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by gabe.freedesktop.org (Postfix) with ESMTPS id C66656EA4B for ; Tue, 25 May 2021 13:08:16 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id c20so47287562ejm.3 for ; Tue, 25 May 2021 06:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=J3i7sySuF9vAMwjRduq9o4pZBENGbTDxWuaAXXo5lxM=; b=CUcTIB0jGV2498eTndtJ4dsxx9tU25S/huYWnqhhT16rMypCIkW2OSS2dEjs/ScD2/ z6Oy6LTaUwdiQWKocdpHw/s4akCqzh3aFWaPuPl6h3FUY9uPGaFaDbs19ONFxN2lFxmk tiUlt5+GP9TsqYQrWQGwSV/5rZ/PXdNuRFves= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=J3i7sySuF9vAMwjRduq9o4pZBENGbTDxWuaAXXo5lxM=; b=FcqGKkGUmADMAyrtTA1QlCvAuFzqpZwzafEfibyvCrNfgNfFzCLRFhWQKpr+/hWG+t KaJAwQJQoJjSdkzryf72A6W8OGGC0yK4Sw8omyzGisTMOaWtn8oT5SX/VU8p60wYDijN SQ3nmEAQz2EZQ4DzJT3LcUiSWkcWAfA2z4MCHeQ6xzSQezEy9jeSSiXi+RG0+xq2mcTN 8h7eiOJSdhDM/B7xzcFc8DGr0GYXzWXwr55K830U52fnbQtyicF0AGPn/PnmtUJGFDmD y2Mnrrmd15RoQH4MVkn/djhT1ruC6BsvDoXTl9ZZ7NPjnrFxC85LxoQ1OABqsjpdLscO 0fvA== X-Gm-Message-State: AOAM530GW5YlanLbqhgf5MLbjNETmIbhCa/r+bRHLgqxbwyS9SPfFNaj ogOPs+lbU5Qn2SzcFPW5ccSa2A== X-Google-Smtp-Source: ABdhPJxXJHDlcz+lHAfC3eMn2DkJLakk8UYTxiXf4gRAsmQw7xJyIhqyJL0QLeuwZ9Zpjh38P9PnUA== X-Received: by 2002:a17:906:3ed0:: with SMTP id d16mr28105603ejj.16.1621948095527; Tue, 25 May 2021 06:08:15 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u21sm9007517ejg.50.2021.05.25.06.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 06:08:14 -0700 (PDT) Date: Tue, 25 May 2021 15:08:13 +0200 From: Daniel Vetter To: Thomas Zimmermann Subject: Re: [PATCH] drm/fb-helper: improve DRM fbdev emulation device names Message-ID: Mail-Followup-To: Thomas Zimmermann , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Peter Robinson , David Airlie , Maarten Lankhorst , Maxime Ripard , dri-devel@lists.freedesktop.org References: <20210521131910.3000689-1-javierm@redhat.com> <3a6f9235-5375-b2cb-2d63-a47c5f9752bb@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Javier Martinez Canillas , linux-kernel@vger.kernel.org, Peter Robinson Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 21, 2021 at 08:53:56PM +0200, Thomas Zimmermann wrote: > Hi > > Am 21.05.21 um 19:18 schrieb Javier Martinez Canillas: > > On 5/21/21 6:53 PM, Thomas Zimmermann wrote: > > > > [snip] > > > > > > > > > > So what with all the drivers which do _not_ have drm in their name? Also > > > > I'm never sure how much these are uapi or not ... > > > > > > > That someone could threat as an uapi is a fair point indeed. > > > Why do we need a suffix anyway? > > > > > > > Yes, I thought the same and was torn about posting a patch to just remove > > the suffix. I don't think users care that much if is a fb device from a > > fbdev driver or a DRM driver using the fbdev emulation. > > Yup. I don't see how anything in userspace would depend on the exact name; > especially since fbdev emulation only provides basic features. (I'd welcome > a counter examples that proves me wrong.) > > IMHO we can risk it to remove the suffix entirely. But that needs an ack > from Daniel or Dave. If you guys with your distro hats on all think it doesn't matter, then yeah I'm all for dropping the somewhat silly -drm or drmfb suffixes. I think that was just way back so it's easier to know you've loaded the right driver, back when there was both drm and native fbdev drivers around. But now I think for new hw there's only drm, so should be all fine. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch