From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF52C47082 for ; Tue, 8 Jun 2021 19:35:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CF696100A for ; Tue, 8 Jun 2021 19:35:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CF696100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqhVN-0005kf-Kd for qemu-devel@archiver.kernel.org; Tue, 08 Jun 2021 15:35:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqhUX-0004Ld-Rb for qemu-devel@nongnu.org; Tue, 08 Jun 2021 15:34:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqhUV-0000wG-3Y for qemu-devel@nongnu.org; Tue, 08 Jun 2021 15:34:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623180861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YCJC5wvUZCre5HBhxFvBC/bxmhevHXB/QZPFHSuEIAw=; b=TiIKoc4pJVekboik3szExaCSAS4+m9awbI7gS5YF7aqQUA1gXjswKAqVl8NkKCkO7INpzn kqyWI2cfLWjnuNE4TX+l8W7nKn8HjftVrbRUvkRWQ0wpJ4/phbEAUlkx3eb31IS65ZklNN sZ6sS2n3/HvRrdVBdokhmZShqggbr80= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-MXB7DHWEPzSqrfAs0CLFQQ-1; Tue, 08 Jun 2021 15:34:18 -0400 X-MC-Unique: MXB7DHWEPzSqrfAs0CLFQQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9344B801ADE; Tue, 8 Jun 2021 19:34:17 +0000 (UTC) Received: from work-vm (ovpn-115-50.ams2.redhat.com [10.36.115.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 316E15C1BB; Tue, 8 Jun 2021 19:34:16 +0000 (UTC) Date: Tue, 8 Jun 2021 20:34:13 +0100 From: "Dr. David Alan Gilbert" To: Connor Kuehl Subject: Re: [PATCH] Add Connor Kuehl as reviewer for AMD SEV Message-ID: References: <20210608192537.103584-1-ckuehl@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210608192537.103584-1-ckuehl@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Paolo Bonzini , Brijesh Singh , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Connor Kuehl (ckuehl@redhat.com) wrote: > It may not be appropriate for me to take over as a maintainer at this time, > but I would consider myself familiar with AMD SEV and what this code is > meant to be doing as part of a VMM for launching SEV-protected guests. > > To that end, I would be happy to volunteer as a reviewer for SEV-related > changes so that I am CC'd on them and can help share the review burden with > whoever does maintain this code. > > Signed-off-by: Connor Kuehl Ooh yes please, we could do with someone to be a reviewer; > --- > Note: because there's no maintainer entry, when running > ./scripts/get_maintainers.pl on target/i386/sev.c, my name and the qemu > mailing list is the only thing that shows up... it doesn't even show > previous committers (as it would before applying this patch). Which is > probably not great considering I do not make pull requests to QEMU. > > Is the way forward to get someone to sign up as a maintainer before > applying a patch like this? If you wanted to do a submaintainer for it and send it to one of the x86 maintainers rather than having to do full pulls? Dave > MAINTAINERS | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7d9cd29042..3eb7ce8fc6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2938,6 +2938,10 @@ F: hw/core/clock-vmstate.c > F: hw/core/qdev-clock.c > F: docs/devel/clocks.rst > > +AMD Secure Encrypted Virtualization > +R: Connor Kuehl > +F: target/i386/sev.c > + > Usermode Emulation > ------------------ > Overall usermode emulation > -- > 2.31.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK