From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00263C4743F for ; Mon, 7 Jun 2021 04:38:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D59956121E for ; Mon, 7 Jun 2021 04:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229458AbhFGEkp (ORCPT ); Mon, 7 Jun 2021 00:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbhFGEko (ORCPT ); Mon, 7 Jun 2021 00:40:44 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 199E6C061766 for ; Sun, 6 Jun 2021 21:38:53 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id c5so15921080wrq.9 for ; Sun, 06 Jun 2021 21:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E1wc2vADYmdO4VfcTB00D2pdpcFUyCevP9KOOTbdqQo=; b=TP7AMNDQjPj+ycKu4IHrzlxJg0CnCoWTObFUzD4A3sdqJDkvIOxdHF98JttTRmu2i5 RcayfRsPj1AZzwg85v2M53KOpWjxLq9P77f0FTV01pybFYK5hgl2yTqSFQhSOllVYplf 5CguxbqSGEBTXJs0lpZvt48u2AmrXvWJo4QksoEwyij+Y21h2CxbJUBxaJAr9DK4iYPh 02MNHeCRaTDmLfDy61H36fGDHNO5bgY6wIE62rwTiuZIj7p3UCz0/xBWpZiVjNSlNFsd ipzgA0tJ06V/Pa6seQrX8yywdKJSf42vtzloOP/GPE5r3i/NUmMeY9YUdSlxYDCual6m GnLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E1wc2vADYmdO4VfcTB00D2pdpcFUyCevP9KOOTbdqQo=; b=qA4NCC635R3TC6eCwxzeHedupxrmjIGTt9AW13liSmpQ9tlFGh2Bk1t8IVp7gDxNYi 015e+D7YIOxf6vMjDmaYe1WoopzUq0E2PKatsgzzwmB4zhGov87P7KF2Ed4Rn70LJy0O xD0CXZBm43e9hK0rNoyoIrIVKbihDx1ftyPoyYCp8uMxm1EOuXfoUxtedZyeUlCumcY+ gLv0IK4uwaY7jhShX6kx4k2MkTyLgND1To3c5HHuKo3W8RlaJnTcbY9zZg+f0G+zn/9d Ouffx2a8BXkwFHplzLDe+cUosLMtYA4X+YGzO/Avqarbgkx3uRXaLMWafrd8ojMr2LmY +vAQ== X-Gm-Message-State: AOAM532VwGPVTEifl7oKJp53GXbIyv+L6XffSeH2VnweVFFaIY6nIm0v 2/3kuFqKezARJW2fXLJIjItybw== X-Google-Smtp-Source: ABdhPJxjF4LIaqtRC95Oq3bA26T3W0QYwrHnNU6vQou645Gz9dMKs+jbPgxyJMgLG2P0F5/igqamtQ== X-Received: by 2002:a5d:4681:: with SMTP id u1mr7857513wrq.268.1623040729275; Sun, 06 Jun 2021 21:38:49 -0700 (PDT) Received: from Iliass-MBP (ppp-94-66-57-185.home.otenet.gr. [94.66.57.185]) by smtp.gmail.com with ESMTPSA id u2sm14299429wrn.38.2021.06.06.21.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jun 2021 21:38:48 -0700 (PDT) Date: Mon, 7 Jun 2021 07:38:43 +0300 From: Ilias Apalodimas To: Tariq Toukan Cc: Matteo Croce , David Ahern , Yunsheng Lin , netdev@vger.kernel.org, linux-mm@kvack.org, Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Subject: Re: [PATCH net-next v6 3/5] page_pool: Allow drivers to hint on SKB recycling Message-ID: References: <20210521161527.34607-1-mcroce@linux.microsoft.com> <20210521161527.34607-4-mcroce@linux.microsoft.com> <722e5567-d8ee-228c-978e-9d5966257bb1@gmail.com> <63a4ea45-9938-3106-9eda-0f7e8fe079ce@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63a4ea45-9938-3106-9eda-0f7e8fe079ce@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Hi Tariq, > > > > > > > > Yes the comment is there to prohibit people (mlx5 only actually) to add the > > > > recycling bit on their driver. Because if they do it will *probably* work > > > > but they might get random corrupted packets which will be hard to debug. > > > > > > > > > > What's the complexity for getting it to work with split page model? > > > Since 1500 is the default MTU, requiring a page per packet means a lot > > > of wasted memory. > > > > We could create a new memory model, e.g. MEM_TYPE_PAGE_SPLIT, and > > restore the behavior present in the previous versions of this serie, > > which is, save xdp_mem_info in struct page. > > As this could slightly impact the performances, this can be added in a > > future change when the drivers which are doing it want to use this > > recycling api. > > > > page-split model doesn't only help reduce memory waste, but increase > cache-locality, especially for aggregated GRO SKBs. > > I'm looking forward to integrating the page-pool SKB recycling API into > mlx5e datapath. For this we need it to support the page-split model. > > Let's see what's missing and how we can help making this happen. Yes that's the final goal. As I said I don't think adding the page split model will fundamentally change the current patchset. So imho we should get this in first, make sure that everything is fine, and then add code for the mlx cards. Regards /Ilias