From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A90DC47082 for ; Mon, 7 Jun 2021 08:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C629610A2 for ; Mon, 7 Jun 2021 08:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbhFGIIo (ORCPT ); Mon, 7 Jun 2021 04:08:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:59196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhFGIIn (ORCPT ); Mon, 7 Jun 2021 04:08:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5849D6102A; Mon, 7 Jun 2021 08:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623053212; bh=xmIDJ297EbDzxkQF9obeTuoyIAjOCtz2+6Ofw+DrFXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sM2u+WyfdldAkzzqhNEq2wVbktPE9gknkrkYPnr8/LdjYaKYBXHFiOr+U8NylodnI dKCe3oCN2qVP2hFpiTEofcH0Pq0cCumErxKYvFsJMlgjmNMABEE2OdTPsV2zfG8KZA r5hy6REuclAD4YTFgHZlkFFt2VpdPNzwM6wsdtfajESdm8taI/7o37jA+65CEvmp8y Y3SfrV4VpNVsJttuF/Fu93gt+mfN10rkDCg+YM1BV5Jho1oqoDXosVqcXuQ8HBmBhR 6+O4rcp61F7naUFa5GLuo6zPA7M0I7iKcn8mc/jVvLmTPOnFU7sAaFhRo+eFqHvdpZ hLfIiy8HB0bGg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1lqAHU-0004Ne-KD; Mon, 07 Jun 2021 10:06:45 +0200 Date: Mon, 7 Jun 2021 10:06:44 +0200 From: Johan Hovold To: Vinod Koul Cc: "yukuai (C)" , mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, michal.simek@xilinx.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: Re: [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe() Message-ID: References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-3-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Thu, Jun 03, 2021 at 04:39:08PM +0530, Vinod Koul wrote: > On 31-05-21, 11:19, Johan Hovold wrote: > > On Mon, May 31, 2021 at 02:27:34PM +0530, Vinod Koul wrote: > > > On 31-05-21, 14:11, yukuai (C) wrote: > > > > On 2021/05/31 12:00, Vinod Koul wrote: > > > > > On 17-05-21, 16:18, Yu Kuai wrote: > > > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > > > > > Forgetting to putting operation will result in reference leak here. > > > > > > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > > > > > > counter balanced. > > > Yes the rumtime_pm is disabled on failure here and the count would have > > > no consequence... > > > > You should still balance the PM usage counter as it isn't reset for > > example when reloading the driver. > > Should I driver trust that on load PM usage counter is balanced and not > to be reset..? Not sure what you're asking here. But a driver should never leave the PM usage counter unbalanced. > > Using pm_runtime_resume_and_get() is one way of handling this, but > > alternatively you could also move the error_pm label above the > > pm_runtime_put() in the error path. > > That would be a better way I think Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C33CC47082 for ; Mon, 7 Jun 2021 08:08:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D73F5610A1 for ; Mon, 7 Jun 2021 08:08:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D73F5610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YXjf4zKuc+POrZ+qg0ZcHZTSTvHbVRFW09Lb2mWpjN4=; b=iTbwhYBY402S62 egxMT5YBPn9Mpz3FNStKlIzeNpqWbyvBQj67lKMY1XT1d0YeYjF0rAQqeC9g+rA5fusNGLA85B5ML xwBR6Ys2MISwyqv4Cj2cb98O0lIsWOiyF5dy4ezpz5h4Db+KrBTA/ASbRC07X90MHPUZq1aB53qri IL7he/NfEWJrWNkZgYNTJmT6z3JmuKgLJggYZh6wfZvjZEaoW4ZxaSAbNvLMwMn3IV3604WD5WRbr O2hkSPsUItqFjrsqNpnRtsRss/FBXu9Z6TNd9cPj67UbaB6fMiJXeCIKO1GpymxG7brYI5wMQXMLv D5J2tCBaGC1XQ0jYxP2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqAHk-002Bmx-Si; Mon, 07 Jun 2021 08:07:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqAHc-002Bkk-LJ for linux-arm-kernel@lists.infradead.org; Mon, 07 Jun 2021 08:06:53 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5849D6102A; Mon, 7 Jun 2021 08:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623053212; bh=xmIDJ297EbDzxkQF9obeTuoyIAjOCtz2+6Ofw+DrFXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sM2u+WyfdldAkzzqhNEq2wVbktPE9gknkrkYPnr8/LdjYaKYBXHFiOr+U8NylodnI dKCe3oCN2qVP2hFpiTEofcH0Pq0cCumErxKYvFsJMlgjmNMABEE2OdTPsV2zfG8KZA r5hy6REuclAD4YTFgHZlkFFt2VpdPNzwM6wsdtfajESdm8taI/7o37jA+65CEvmp8y Y3SfrV4VpNVsJttuF/Fu93gt+mfN10rkDCg+YM1BV5Jho1oqoDXosVqcXuQ8HBmBhR 6+O4rcp61F7naUFa5GLuo6zPA7M0I7iKcn8mc/jVvLmTPOnFU7sAaFhRo+eFqHvdpZ hLfIiy8HB0bGg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1lqAHU-0004Ne-KD; Mon, 07 Jun 2021 10:06:45 +0200 Date: Mon, 7 Jun 2021 10:06:44 +0200 From: Johan Hovold To: Vinod Koul Cc: "yukuai (C)" , mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, michal.simek@xilinx.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: Re: [PATCH 2/3] dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe() Message-ID: References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-3-yukuai3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_010652_748093_65E70D45 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 03, 2021 at 04:39:08PM +0530, Vinod Koul wrote: > On 31-05-21, 11:19, Johan Hovold wrote: > > On Mon, May 31, 2021 at 02:27:34PM +0530, Vinod Koul wrote: > > > On 31-05-21, 14:11, yukuai (C) wrote: > > > > On 2021/05/31 12:00, Vinod Koul wrote: > > > > > On 17-05-21, 16:18, Yu Kuai wrote: > > > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > > > > > Forgetting to putting operation will result in reference leak here. > > > > > > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > > > > > > counter balanced. > > > Yes the rumtime_pm is disabled on failure here and the count would have > > > no consequence... > > > > You should still balance the PM usage counter as it isn't reset for > > example when reloading the driver. > > Should I driver trust that on load PM usage counter is balanced and not > to be reset..? Not sure what you're asking here. But a driver should never leave the PM usage counter unbalanced. > > Using pm_runtime_resume_and_get() is one way of handling this, but > > alternatively you could also move the error_pm label above the > > pm_runtime_put() in the error path. > > That would be a better way I think Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel