From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiri Prchal <jiri.prchal@aksignal.cz>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Christian Eggers <ceggers@arri.de>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num
Date: Mon, 7 Jun 2021 14:36:43 +0200 [thread overview]
Message-ID: <YL4S2/hlfRwRM+Ug@kroah.com> (raw)
In-Reply-To: <20210607122640.143582-5-jiri.prchal@aksignal.cz>
On Mon, Jun 07, 2021 at 02:26:39PM +0200, Jiri Prchal wrote:
> This exports serial number of FRAM in sysfs file named "sernum".
> Formatted in hex, each byte separated by space.
> Example:
> $ cat /sys/class/spi_master/spi0/spi0.0/sernum
> 0000a43644f2ae6c
>
> Signed-off-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> ---
> v2: no change here
> v3: resend and added more recipients
> v4: resend
> v5: reworked up on Greg comments: no spaces in string, sysfs done correctly
> v6: no change here
> v7: moved FM25_SN_LEN, static array, used sysfs_emit, DEVICE_ATTR_RO
> ---
> drivers/misc/eeprom/at25.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
> index 3b7ffef1f0d7..a28dfd7e1798 100644
> --- a/drivers/misc/eeprom/at25.c
> +++ b/drivers/misc/eeprom/at25.c
> @@ -31,6 +31,7 @@
> * AT25M02, AT25128B
> */
>
> +#define FM25_SN_LEN 8 /* serial number length */
> struct at25_data {
> struct spi_device *spi;
> struct mutex lock;
> @@ -39,6 +40,7 @@ struct at25_data {
> struct nvmem_config nvmem_config;
> struct nvmem_device *nvmem;
> int has_sernum;
> + u8 sernum[FM25_SN_LEN];
> };
>
> #define AT25_WREN 0x06 /* latch the write enable */
> @@ -172,6 +174,21 @@ static int fm25_aux_read(struct at25_data *at25, char *buf, uint8_t command,
> return status;
> }
>
> +static ssize_t sernum_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + struct at25_data *at25;
> +
> + at25 = dev_get_drvdata(dev);
> + return sysfs_emit(buf, "%016llx\n", *(unsigned long long *)at25->sernum);
That's a horrid hack, why not use the %*phN modifier?
Look in the printk-formats.rst file for help.
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-07 12:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 12:26 [PATCH v7 0/5] add support for FRAM Jiri Prchal
2021-06-07 12:26 ` [PATCH v7 1/5] nvmem: eeprom: at25: prepare basics for FRAM support Jiri Prchal
2021-06-07 12:35 ` Greg Kroah-Hartman
2021-06-07 12:26 ` [PATCH v7 2/5] nvmem: eeprom: at25: add support for FRAM Jiri Prchal
2021-06-07 12:26 ` [PATCH v7 3/5] nvmem: eeprom: add documentation " Jiri Prchal
2021-06-07 13:09 ` Enrico Weigelt, metux IT consult
2021-06-07 12:26 ` [PATCH v7 4/5] nvmem: eeprom: at25: export FRAM serial num Jiri Prchal
2021-06-07 12:36 ` Greg Kroah-Hartman [this message]
2021-06-07 14:47 ` Jiří Prchal
2021-06-08 9:03 ` Greg Kroah-Hartman
2021-06-08 9:45 ` Jiří Prchal
2021-06-08 9:53 ` Greg Kroah-Hartman
2021-06-08 10:07 ` Jiří Prchal
2021-06-10 7:51 ` Jiří Prchal
2021-06-07 12:26 ` [PATCH v7 5/5] nvmem: eeprom: add documentation of sysfs sernum file Jiri Prchal
2021-06-07 12:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL4S2/hlfRwRM+Ug@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ceggers@arri.de \
--cc=devicetree@vger.kernel.org \
--cc=jiri.prchal@aksignal.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.