From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93DEC4743F for ; Mon, 7 Jun 2021 20:20:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB446601FC for ; Mon, 7 Jun 2021 20:20:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231698AbhFGUWn (ORCPT ); Mon, 7 Jun 2021 16:22:43 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35475 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbhFGUWl (ORCPT ); Mon, 7 Jun 2021 16:22:41 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 6130320002; Mon, 7 Jun 2021 20:20:48 +0000 (UTC) Date: Mon, 7 Jun 2021 22:20:48 +0200 From: Alexandre Belloni To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alessandro Zummo , linux-rtc@vger.kernel.org Subject: Re: [PATCH] dt-bindings: rtc: Add Arm PL031 schema Message-ID: References: <20210607193718.3090202-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607193718.3090202-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, On 07/06/2021 14:37:18-0500, Rob Herring wrote: > The PL031 RTC binding has been in use for a long time, but never got > documented. Fortunately, it's simple and existing users are consistent. > > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: linux-rtc@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/rtc/arm,pl031.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/arm,pl031.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/arm,pl031.yaml b/Documentation/devicetree/bindings/rtc/arm,pl031.yaml > new file mode 100644 > index 000000000000..77452c9e9b63 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/arm,pl031.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/arm,pl031.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Arm Primecell PL031 Real Time Clock > + > +select: > + properties: > + compatible: > + contains: > + const: arm,pl031 > + required: > + - compatible > + > +allOf: > + - $ref: rtc.yaml# > + > +maintainers: > + - Rob Herring > + > +properties: > + compatible: > + items: > + - const: arm,pl031 > + - const: arm,primecell > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + As the driver sets the range, it also supports start-date from rtc.yaml With that added: Acked-by: Alexandre Belloni -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com