From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EA6C47095 for ; Mon, 7 Jun 2021 18:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42A1C60FE4 for ; Mon, 7 Jun 2021 18:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbhFGSZ7 (ORCPT ); Mon, 7 Jun 2021 14:25:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:34364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbhFGSZ4 (ORCPT ); Mon, 7 Jun 2021 14:25:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 848D66100B; Mon, 7 Jun 2021 18:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623090228; bh=3qwQjke9SsTYx5f2eASEV9qw21YlAZykyJ/j3df/k/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n+NCTiHtUaVhv4TT5TlzNFuevIV1NtcnocTXkHj0DW77u4R/8iV318yPf+et5nukK iVlqz+gBTOA83lrF2bB2TJmfG6b/uvoZoDVhZTtX8iBBTroIdWjEO4jVut7N+Cy08/ W8K5BaZZf1lqMEr92kp2ZVU8E4AG8ZvYOdKJxPSk= Date: Mon, 7 Jun 2021 20:23:43 +0200 From: Greg Kroah-Hartman To: Matthias Kaehlcke Cc: kernel test robot , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , kbuild-all@lists.01.org, Michal Simek , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Bastien Nocera , linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver Message-ID: References: <20210604144027.v11.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid> <202106050751.uNo0uAEm-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 07, 2021 at 10:51:57AM -0700, Matthias Kaehlcke wrote: > On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote: > > Hi Matthias, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on next-20210604] > > [also build test WARNING on v5.13-rc4] > > [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5.13-rc2] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > base: ccc252d2e818f6a479441119ad453c3ce7c7c461 > > config: arc-allyesconfig (attached as .config) > > compiler: arceb-elf-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/0day-ci/linux/commit/7107f99a12058b7147342c6f763d026102bd6606 > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > git checkout 7107f99a12058b7147342c6f763d026102bd6606 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous prototype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] > > 400 | void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_head *pdev_list) > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous prototype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] > > 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Oh, I wasn't aware that prototypes are required for public functions. How else can they be called? From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6097038820684624711==" MIME-Version: 1.0 From: Greg Kroah-Hartman To: kbuild-all@lists.01.org Subject: Re: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver Date: Mon, 07 Jun 2021 20:23:43 +0200 Message-ID: In-Reply-To: List-Id: --===============6097038820684624711== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2021 at 10:51:57AM -0700, Matthias Kaehlcke wrote: > On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote: > > Hi Matthias, > > = > > I love your patch! Perhaps something to improve: > > = > > [auto build test WARNING on next-20210604] > > [also build test WARNING on v5.13-rc4] > > [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-test= ing driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5.13-= rc2] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch] > > = > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-= misc-Add-onboard_usb_hub-driver/20210605-054213 > > base: ccc252d2e818f6a479441119ad453c3ce7c7c461 > > config: arc-allyesconfig (attached as .config) > > compiler: arceb-elf-gcc (GCC) 9.3.0 > > reproduce (this is a W=3D1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/s= bin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/0day-ci/linux/commit/7107f99a12058b7147342= c6f763d026102bd6606 > > git remote add linux-review https://github.com/0day-ci/linux > > git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add= -onboard_usb_hub-driver/20210605-054213 > > git checkout 7107f99a12058b7147342c6f763d026102bd6606 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cr= oss ARCH=3Darc = > > = > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > = > > All warnings (new ones prefixed by >>): > > = > > >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous proto= type for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] > > 400 | void onboard_hub_create_pdevs(struct usb_device *parent_hub,= struct list_head *pdev_list) > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous proto= type for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] > > 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > = > Oh, I wasn't aware that prototypes are required for public functions. How else can they be called? --===============6097038820684624711==--