From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F9CCC4743E for ; Tue, 8 Jun 2021 08:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F05D86101A for ; Tue, 8 Jun 2021 08:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbhFHI6Y (ORCPT ); Tue, 8 Jun 2021 04:58:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:57798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhFHI6T (ORCPT ); Tue, 8 Jun 2021 04:58:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 314A061153; Tue, 8 Jun 2021 08:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623142570; bh=ews02L1jG1jjqGhNiQBHVN06tOoeL+zxI87hCEUyTkY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNfCk3uPL/u3KJrFtRoAGgFuNVs9IeZf6yMzuChgn0OzADTn+sFtyGdKGiogPvJ0l 4OaqjsubDE3q0EmA2eXEIOiljTEksdm31Ltf3rleRITNeV9a1f6z98jZ1pumXm9NXy hpYgt0+3Pxbx8bJfKEPJYyZfpuZjfSJnAO/EIjPE= Date: Tue, 8 Jun 2021 10:56:08 +0200 From: Greg Kroah-Hartman To: Matthias Kaehlcke Cc: kernel test robot , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , kbuild-all@lists.01.org, Michal Simek , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Bastien Nocera , linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver Message-ID: References: <20210604144027.v11.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid> <202106050751.uNo0uAEm-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 07, 2021 at 11:32:31AM -0700, Matthias Kaehlcke wrote: > On Mon, Jun 07, 2021 at 08:23:43PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 07, 2021 at 10:51:57AM -0700, Matthias Kaehlcke wrote: > > > On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote: > > > > Hi Matthias, > > > > > > > > I love your patch! Perhaps something to improve: > > > > > > > > [auto build test WARNING on next-20210604] > > > > [also build test WARNING on v5.13-rc4] > > > > [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5.13-rc2] > > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > > And when submitting patch, we suggest to use '--base' as documented in > > > > https://git-scm.com/docs/git-format-patch] > > > > > > > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > > > base: ccc252d2e818f6a479441119ad453c3ce7c7c461 > > > > config: arc-allyesconfig (attached as .config) > > > > compiler: arceb-elf-gcc (GCC) 9.3.0 > > > > reproduce (this is a W=1 build): > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # https://github.com/0day-ci/linux/commit/7107f99a12058b7147342c6f763d026102bd6606 > > > > git remote add linux-review https://github.com/0day-ci/linux > > > > git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > > > git checkout 7107f99a12058b7147342c6f763d026102bd6606 > > > > # save the attached .config to linux build tree > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc > > > > > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous prototype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] > > > > 400 | void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_head *pdev_list) > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous prototype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] > > > > 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list) > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Oh, I wasn't aware that prototypes are required for public functions. > > > > How else can they be called? > > Well, there are prototypes in include/linux/usb/onboard_hub.h, however this > header isn't included (anymore) by the driver itself to avoid conflicts > when COMPILE_TEST=y (see https://lkml.org/lkml/2021/5/25/975). Then that needs to be resolved please. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5579823797283214036==" MIME-Version: 1.0 From: Greg Kroah-Hartman To: kbuild-all@lists.01.org Subject: Re: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver Date: Tue, 08 Jun 2021 10:56:08 +0200 Message-ID: In-Reply-To: List-Id: --===============5579823797283214036== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2021 at 11:32:31AM -0700, Matthias Kaehlcke wrote: > On Mon, Jun 07, 2021 at 08:23:43PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 07, 2021 at 10:51:57AM -0700, Matthias Kaehlcke wrote: > > > On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote: > > > > Hi Matthias, > > > > = > > > > I love your patch! Perhaps something to improve: > > > > = > > > > [auto build test WARNING on next-20210604] > > > > [also build test WARNING on v5.13-rc4] > > > > [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-= testing driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5= .13-rc2] > > > > [If your patch is applied to the wrong git tree, kindly drop us a n= ote. > > > > And when submitting patch, we suggest to use '--base' as documented= in > > > > https://git-scm.com/docs/git-format-patch] > > > > = > > > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/= USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > > > base: ccc252d2e818f6a479441119ad453c3ce7c7c461 > > > > config: arc-allyesconfig (attached as .config) > > > > compiler: arceb-elf-gcc (GCC) 9.3.0 > > > > reproduce (this is a W=3D1 build): > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/mast= er/sbin/make.cross -O ~/bin/make.cross > > > > chmod +x ~/bin/make.cross > > > > # https://github.com/0day-ci/linux/commit/7107f99a12058b714= 7342c6f763d026102bd6606 > > > > git remote add linux-review https://github.com/0day-ci/linux > > > > git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc= -Add-onboard_usb_hub-driver/20210605-054213 > > > > git checkout 7107f99a12058b7147342c6f763d026102bd6606 > > > > # save the attached .config to linux build tree > > > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 mak= e.cross ARCH=3Darc = > > > > = > > > > If you fix the issue, kindly add following tag as appropriate > > > > Reported-by: kernel test robot > > > > = > > > > All warnings (new ones prefixed by >>): > > > > = > > > > >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous p= rototype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] > > > > 400 | void onboard_hub_create_pdevs(struct usb_device *parent_= hub, struct list_head *pdev_list) > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous p= rototype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] > > > > 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_li= st) > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > = > > > Oh, I wasn't aware that prototypes are required for public functions. > > = > > How else can they be called? > = > Well, there are prototypes in include/linux/usb/onboard_hub.h, however th= is > header isn't included (anymore) by the driver itself to avoid conflicts > when COMPILE_TEST=3Dy (see https://lkml.org/lkml/2021/5/25/975). Then that needs to be resolved please. thanks, greg k-h --===============5579823797283214036==--