From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C359C47087 for ; Fri, 28 May 2021 10:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FDD2613B6 for ; Fri, 28 May 2021 10:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236530AbhE1KrO (ORCPT ); Fri, 28 May 2021 06:47:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:53668 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236340AbhE1KrN (ORCPT ); Fri, 28 May 2021 06:47:13 -0400 IronPort-SDR: YsePYQJD8tTo0UOVaqrZINZuuC98X7vZS8IWuIzoIVLrzteSE3um5PPRJcf8olZwbkWQ0ED/b+ /dvtD+TPqJuw== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="224166045" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="224166045" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 03:45:38 -0700 IronPort-SDR: bbuC1joOym2GH0be1kABCGUGS8fy59so6ikZaWMxUoC1GT44vRQcUTA1V8pg5ys7z54svUUn6x AStv45sMm1lw== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="465837093" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 03:45:34 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lmZzf-00FIDS-NS; Fri, 28 May 2021 13:45:31 +0300 Date: Fri, 28 May 2021 13:45:31 +0300 From: Andy Shevchenko To: Pavel Machek Cc: Amireddy Mallikarjuna reddy , Linus Walleij , Marek =?iso-8859-1?Q?Beh=FAn?= , Abanoub Sameh , Dan Murphy , Krzysztof Kozlowski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 03/28] leds: el15203000: Give better margin for usleep_range() Message-ID: References: <20210510095045.3299382-1-andy.shevchenko@gmail.com> <20210510095045.3299382-4-andy.shevchenko@gmail.com> <20210528100440.GE2209@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528100440.GE2209@amd> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, May 28, 2021 at 12:04:40PM +0200, Pavel Machek wrote: > On Mon 2021-05-10 12:50:20, Andy Shevchenko wrote: > > 1 microsecond with 20 millisecond parameter is too low margin for > > usleep_range(). Give 100 to make scheduler happier. > > > > While at it, fix indentation in cases where EL_FW_DELAY_USEC is in use. > > In the loop, move it to the end to avoid a conditional. > > Its not like unhappy schedulers are problem... Any hints then? To me it sounds like torturing scheduler is the real problem and that's why scheduler is unhappy. -- With Best Regards, Andy Shevchenko