From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41420C2B9F7 for ; Fri, 28 May 2021 13:37:20 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id BD1AC610A8 for ; Fri, 28 May 2021 13:37:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD1AC610A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1C0140143; Fri, 28 May 2021 15:37:18 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 2174D40040 for ; Fri, 28 May 2021 15:37:16 +0200 (CEST) IronPort-SDR: 2RZjiS/wouRikm9qbeJcS8hIS+pyLlzYyEyOYFLlxNcxG+D0W6QCTT7wKV6ZfDDF7M/wd2x0zD oC4xpPtBN+0Q== X-IronPort-AV: E=McAfee;i="6200,9189,9998"; a="199921255" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="199921255" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 06:37:16 -0700 IronPort-SDR: hwuW6G9hPxiR/V/QVxGh6DjHzGAz85UkjAgm92v9V1crECeFAjjwyqE8zBEkpK/zkctuCdERDP Kg2ElZy+9uxw== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="477930608" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.7.179]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 May 2021 06:37:14 -0700 Date: Fri, 28 May 2021 14:37:10 +0100 From: Bruce Richardson To: Kevin Laatz Cc: dev@dpdk.org Message-ID: References: <20210527132646.3565721-1-kevin.laatz@intel.com> <20210528131902.344423-1-kevin.laatz@intel.com> <20210528131902.344423-3-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528131902.344423-3-kevin.laatz@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 2/2] raw/ioat: add device reset to python script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 28, 2021 at 02:19:02PM +0100, Kevin Laatz wrote: > Currently once a device is configured, the user does not have the ability > to reset the device via the script. > > This patch adds a device reset option to the script. For example > "$dpdk_idxd_cfg.py 0 --reset" would reset device 0. > > Signed-off-by: Kevin Laatz > --- I'd tend toward not having the prints for what the script is doing, and have the script silent by default. However, with or without that tweak: Acked-by: Bruce Richardson