All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Phil Elwell <phil@raspberrypi.com>
Cc: stable@vger.kernel.org
Subject: Re: Back-ports of dwc2 commit break peripheral-only builds
Date: Sun, 30 May 2021 14:18:38 +0200	[thread overview]
Message-ID: <YLOCnlGa9L7rnwk4@kroah.com> (raw)
In-Reply-To: <558ce64c-666a-5b68-ee48-74293b08cbbc@raspberrypi.com>

On Fri, May 28, 2021 at 11:19:00AM +0100, Phil Elwell wrote:
> Hi,
> 
> Back-ports of [1] - a Fix to the dwc2 driver - cause build errors for
> configurations including CONFIG_USB_DWC2_PERIPHERAL=y because in the stable
> branches the bus_suspended member of struct dwc2_hsotg is not present with
> that setting. [1] depends on [2] to move bus_suspended into a common part of
> dwc2_hsotg, but because [2] is not a fix it hasn't been back-ported to
> stable branches. [2] does not apply cleanly on its own (e.g. to
> linux-5.10.y) , so either more commits must be back-ported, [1] must be
> reverted, or a subset of [2] could be used for the back-ports.
> 
> Phil
> 
> [1] 24d209dba5a3 ("usb: dwc2: Fix hibernation between host and device modes")
> 
> [2] 012466fc8ccc0 ("usb: dwc2: Add device clock gating support functions")

Do you have a "working" version of this patch that we could take for the
older kernel trees that does not break the build?  That might be the
best thing here.

thanks,

greg k-h

      reply	other threads:[~2021-05-30 12:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 10:19 Back-ports of dwc2 commit break peripheral-only builds Phil Elwell
2021-05-30 12:18 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLOCnlGa9L7rnwk4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=phil@raspberrypi.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.