From: Vinod Koul <vkoul@kernel.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] dmaengine: fix PM reference leak
Date: Mon, 31 May 2021 09:46:36 +0530 [thread overview]
Message-ID: <YLRjJFN96NGHS9Rj@vkoul-mobl.Dlink> (raw)
In-Reply-To: <1621601902-33697-1-git-send-email-zou_wei@huawei.com>
On 21-05-21, 20:58, Zou Wei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
Please rebase and submit per driver.. I have already applied few fixes
for this and rejected few
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] dmaengine: fix PM reference leak
Date: Mon, 31 May 2021 09:46:36 +0530 [thread overview]
Message-ID: <YLRjJFN96NGHS9Rj@vkoul-mobl.Dlink> (raw)
In-Reply-To: <1621601902-33697-1-git-send-email-zou_wei@huawei.com>
On 21-05-21, 20:58, Zou Wei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
Please rebase and submit per driver.. I have already applied few fixes
for this and rejected few
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-31 4:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 12:58 [PATCH -next] dmaengine: fix PM reference leak Zou Wei
2021-05-21 12:58 ` Zou Wei
2021-05-31 4:16 ` Vinod Koul [this message]
2021-05-31 4:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLRjJFN96NGHS9Rj@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=baolin.wang7@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.