From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E55C47080 for ; Mon, 31 May 2021 17:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 370E26127C for ; Mon, 31 May 2021 17:57:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231722AbhEaR6s (ORCPT ); Mon, 31 May 2021 13:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhEaR6s (ORCPT ); Mon, 31 May 2021 13:58:48 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01C57C061760 for ; Mon, 31 May 2021 10:57:06 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id z3so12981461oib.5 for ; Mon, 31 May 2021 10:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DSZZAxEHbdLZZFw3vP+gxBVlQqCyrawB+uRSZuIZgfE=; b=RP19OH9CpI0aNDLkOYv5uoSwZpnzBzCwG0E1jDZxgOQ9DkRGGQYX9AtUXLRsZUgVPo RhURb0Raz1N7KIW7dJk7am/V/UUhd1h7rhObulSEsAMaZIsfDG58KTC/2JJCrx0H5Blf diMBqTGi5N3gPAiSkrw7aGA6R5O3N10wvHQwj67IHblAzBpQlFMbYyWK6NKnx5HYhYpG 7UpGewtypbHUCieQA7m+QYitIdJ5XPYD2btoDY5+khlbBWoe4QPpC965AwC3FlZk0SfY PLYAllF1azN0SygOufTNLacrELbXVw8k30ShmM228igEYhszT1xLdFQhVAXDFon1SyL9 S/OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DSZZAxEHbdLZZFw3vP+gxBVlQqCyrawB+uRSZuIZgfE=; b=qUTiUE0fOu9sjD0Pn/K1x1+iBaq5+SO5ZH9ivvd7IbotUb1EeO9OdALGW3tlGA3dTV +xNtKQQupDM8nH+nMagyL8PSLMv7pnZYRh9z1+uX3hB9vMa0lwSCqyKtJNR2LUuj1MPE dM68K4SarfFhO9upVDaJpBXKlw7EVmZz41xamf1EiTUnqnLLqEX0SWzTHzeJ2cn2/Cnj QVuWGGs4/fCZ6WWRjlO5zbdbGWNn8StQ54tMt1pL8iMeLhTI9CHfXaBt1IRu03YxctXP IfsH4dTXwhgO+WJoEPuRH71MIDdtAqbHYP4Fj+QoN0WIfvn/zPq5zupUrECHz2uxUO90 7opw== X-Gm-Message-State: AOAM531uYLRa1+h/hElCHOq6y9qEVHqdjrjdrUSKBdHlghYBZcfBdvza cK0F3ou3LZ9bZhpxBcJPkDv+5A== X-Google-Smtp-Source: ABdhPJyMSM6FwtPAzJOnXLO+pv4nc6c2SOvHU9KLqi26VKWEHZ1Ea9pf222zATy1Qo3Pp5k6oOaR9w== X-Received: by 2002:a54:4113:: with SMTP id l19mr203643oic.38.1622483826247; Mon, 31 May 2021 10:57:06 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 7sm3169597oti.30.2021.05.31.10.57.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 10:57:05 -0700 (PDT) Date: Mon, 31 May 2021 12:57:03 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Maulik Shah , evgreen@chromium.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, dianders@chromium.org, linux@roeck-us.net, rnayak@codeaurora.org, lsrao@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats Message-ID: References: <1621596371-26482-1-git-send-email-mkshah@codeaurora.org> <1621596371-26482-4-git-send-email-mkshah@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 26 May 18:30 CDT 2021, Stephen Boyd wrote: > Quoting Maulik Shah (2021-05-21 04:26:09) > > Add device node for SoC sleep stats driver which provides various > > low power mode stats. > > > > Also update the reg size of aoss_qmp device to 0x400. > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Maulik Shah > > Reviewed-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 6228ba2..889d04d 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -3215,7 +3215,7 @@ > > > > aoss_qmp: power-controller@c300000 { > > compatible = "qcom,sc7180-aoss-qmp"; > > - reg = <0 0x0c300000 0 0x100000>; > > + reg = <0 0x0c300000 0 0x400>; > > interrupts = ; > > mboxes = <&apss_shared 0>; > > > > @@ -3223,6 +3223,11 @@ > > #power-domain-cells = <1>; > > }; > > > > + rpmh-sleep-stats@c3f0000 { > > + compatible = "qcom,rpmh-sleep-stats"; > > + reg = <0 0x0c3f0000 0 0x400>; > > + }; > > + > > Does this need to be in DT? Can the sc7180-aoss-qmp driver use the > aux-bus and stick the sleep stats device on there? > The AOSS memory space has N chunks of "message ram", one is used for the QMP protocol (presumably the APSS specific one), a different one is used for the sleep stats. I presume we could have come up with a binding for the entire AOSS/AOP and then describe (either implicit or explicitly) the QMP and debug-stats under that. But we'd also have to come up with the same container-device for the RPM case. Regards, Bjorn > > spmi_bus: spmi@c440000 { > > compatible = "qcom,spmi-pmic-arb"; > > reg = <0 0x0c440000 0 0x1100>,