From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0DE7C47080 for ; Tue, 1 Jun 2021 03:17:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE9460FEE for ; Tue, 1 Jun 2021 03:17:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE9460FEE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnuu3-0000P5-MW for qemu-devel@archiver.kernel.org; Mon, 31 May 2021 23:17:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnut8-0006ut-9z; Mon, 31 May 2021 23:16:18 -0400 Received: from ozlabs.org ([203.11.71.1]:46237) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnut2-00014G-KG; Mon, 31 May 2021 23:16:17 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FvHNx36qBz9sSs; Tue, 1 Jun 2021 13:16:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1622517361; bh=usM57kv9dr//uaApxAu/bH6hxwQW5KR/7AVmwFjwpsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lSnrCud46wxBIAnrDop37EJUuy8AMXn8Z8+auatRGhonEYdmTx26kE73jD7UEZhlL qy6CYfHxoqTJfxR/ruUPyDyaq1hUrW6ac9kRnLKIriiApmFaBzIPdcFsW3VrgTWmxC kNiqPeq+tLddHGLu58OiogeJWB/sTecPAVh9IAOs= Date: Tue, 1 Jun 2021 12:47:37 +1000 From: "david@gibson.dropbear.id.au" To: Luis Fernando Fujita Pires Subject: Re: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU Message-ID: References: <20210531145629.21300-1-bruno.larsen@eldorado.org.br> <20210531145629.21300-5-bruno.larsen@eldorado.org.br> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yBahZdVT0gnhLCS4" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "farosas@linux.ibm.com" , "richard.henderson@linaro.org" , "qemu-devel@nongnu.org" , Greg Kurz , Lucas Mateus Martins Araujo e Castro , Fernando Eckhardt Valle , "qemu-ppc@nongnu.org" , Matheus Kowalczuk Ferst Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --yBahZdVT0gnhLCS4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 31, 2021 at 05:46:07PM +0000, Luis Fernando Fujita Pires wrote: > From: Bruno Larsen (billionai) > > This feature will no longer be useful as ppc moves to using decotree fo= r TCG. > > And building with it enabled is no longer possible, due to changes in > > opc_handler_t. Since the last commit that mentions it happened in 2014,= I think > > it is safe to remove it. > >=20 > > Signed-off-by: Bruno Larsen (billionai) > > --- > > target/ppc/cpu_init.c | 205 ----------------------------------------- > > target/ppc/internal.h | 2 - > > target/ppc/translate.c | 105 --------------------- > > 3 files changed, 312 deletions(-) >=20 > I believe you lost Richard's review for this one. In addition to approvin= g it, he also noted the a typo in the commit message ("decotree" -> "decode= tree"). I folded in the typo fix and Richard's R-b for this patch and the previous one. > Reviewed-by: Luis Pires >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yBahZdVT0gnhLCS4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmC1n8cACgkQbDjKyiDZ s5IXvQ//fsX8lBQcl3Vzj+MWQQn+cn+yBWryRKosxZAs9SmZkEYpmCK11MX0wsXM Y1RoguNndACdXHxRw4wIKVr3velHJLijF0+HiDIhIpckQT/x1d3c5cGGTGjhZfGE qNBpFuwlQgX9HlbmvHDYT4UrUt6RY8f/kmstXMOXK3CiErqwdopcf/QNEaD0DHEV hq2PrvfIWZqjRWZtCoEPeMs1ahT3Uow5P7mG/7Y9tM+sWCt+WQ446Q2QJZ/ZK8UK WxLheWAYWp9+LpZZ9Jd1hfV48ScBwPEa+IDUk2/WUGe+857KnCluaMNR64T1Jhlh WpwoQD2tKave/adxePV4wxKdQg+55Fy4ivTZuxKAWEx/HEAWAwdSmgDbjY9yw2Kb kZFJBdNOQAKGjjRxG1DuCGrqknGEbhfoM3NohwYXJ6SKEVIMbAQ3S4877FIG8fM5 wjxMPCyMh3nrc3FPRrN+y9iJrIlvUppZFAI6xd+NDhhHwQn+MSxufTAHu0L34iYq 2nHbRGhywKEdVGyxsr6og21nbB8b8DuFlqhtlH5NBPoSA6v5H62mVfuoXizurauc SBKJcAUTLvwwe+94CNERX4PA5mUIr2jiNUEDAjdsXQbvuF1Pkpzm/jYRbAv+QE/x TYHd5f813d4WmpTw5MjIun8Q9vyW3ol8P8O8SyAdMMAVLiaX4JE= =/v8r -----END PGP SIGNATURE----- --yBahZdVT0gnhLCS4--