From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, lizhijian@fujitsu.com
Subject: Re: rdma_get_cm_event error behaviour defined?
Date: Tue, 1 Jun 2021 12:32:00 +0100 [thread overview]
Message-ID: <YLYasCUuuNMpag2M@work-vm> (raw)
In-Reply-To: <YLYXBD9jupPOslnR@unreal>
* Leon Romanovsky (leon@kernel.org) wrote:
> On Mon, May 17, 2021 at 11:06:35AM +0100, Dr. David Alan Gilbert wrote:
> > Hi,
> > Is 'rdma_get_cm_event's behaviour in initialising **event
> > defined in the error case?
> > We don't see anything in the manual page, my reading of the
> > code is it's not set/changed in the case of failure - but is
> > that defined?
> > It would be good if the manpage could explicitly state it.
>
> AFAIK, the general practice do not rely on any output argument if
> function returns an error and I'm not sure that the man update is
> needed.
The case we had was whether we needed to clean up or not in the error
case; the original code in qemu was:
2496 ret = rdma_get_cm_event(rdma->channel, &cm_event);
2497 if (ret) {
2498 perror("rdma_get_cm_event after rdma_connect");
2499 ERROR(errp, "connecting to destination!");
2500 rdma_ack_cm_event(cm_event);
2501 goto err_rdma_source_connect;
2502 }
and Li spotted that rdma_ack_cm_event would seg in the case
rdma_get_cm_event failed.
While I agree on not relying on an output; without a definition you're
stuck between not knowing if you're leaking an event that should
have been cleaned up.
Dave
> Thanks
>
> >
> > Dave
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> >
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-06-01 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 10:06 rdma_get_cm_event error behaviour defined? Dr. David Alan Gilbert
2021-06-01 11:16 ` Leon Romanovsky
2021-06-01 11:32 ` Dr. David Alan Gilbert [this message]
2021-06-02 12:33 ` Leon Romanovsky
2021-06-02 12:55 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLYasCUuuNMpag2M@work-vm \
--to=dgilbert@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.