From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E0BC47080 for ; Tue, 1 Jun 2021 14:47:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C208061378 for ; Tue, 1 Jun 2021 14:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233797AbhFAOtd (ORCPT ); Tue, 1 Jun 2021 10:49:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:59524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234043AbhFAOtd (ORCPT ); Tue, 1 Jun 2021 10:49:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0B70611CB; Tue, 1 Jun 2021 14:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622558871; bh=uz2NRF/ljSpkm4h6Gs9S8effJf7eoaTi+UNqCbCyWDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dscnB1AQut8bhJEL8ArV4529oIQvLZkHRyuEFzg/khDnqh+gcIdtKHbmqOdMTM4Is OKjQll6iUHQb1EPftzOWJk3p55nX6nX0V8F3SCRCBSQ6wRZZZJV/r1uB0WCrY6iHYA nG1g9KtReSSdzReXf2o66sfGjDIyUqALVKL4bAluQFM7STvU/pGfxdSndo10k1JkoU U6lQvDEPYR6+yIq2xlM8dnjT3ycvdMCvtZPvDeQ2O8dZQ8NURhldkt91iNsCZyTub0 L6xKggOTrWdLjsZhw0wLkfQEy8jPfvMwVZWFMPVALX+Gs7dKUbky1G3hy4WLP33E0h lFE00D1HGx9dw== Date: Tue, 1 Jun 2021 17:47:47 +0300 From: Leon Romanovsky To: Devesh Sharma Cc: linux-rdma Subject: Re: [for-next 1/2] RDMA/bnxt_re: Enable global atomic ops if platform supports Message-ID: References: <20210517132522.774762-1-devesh.sharma@broadcom.com> <20210517132522.774762-2-devesh.sharma@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Jun 01, 2021 at 07:45:09PM +0530, Devesh Sharma wrote: > On Tue, Jun 1, 2021 at 4:55 PM Leon Romanovsky wrote: > > > > On Fri, May 21, 2021 at 06:20:35PM +0530, Devesh Sharma wrote: > > > On Thu, May 20, 2021 at 1:20 PM Leon Romanovsky wrote: > > > > > > > > On Mon, May 17, 2021 at 06:55:21PM +0530, Devesh Sharma wrote: > > > > > Enabling Atomic operations for Gen P5 devices if the underlying > > > > > platform supports global atomic ops. > > > > > > > > > > Fixes:7ff662b76167 ("Disable atomic capability on bnxt_re adapters") > > > > > Signed-off-by: Devesh Sharma > > > > > --- > > > > > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 4 ++++ > > > > > drivers/infiniband/hw/bnxt_re/main.c | 4 ++++ > > > > > drivers/infiniband/hw/bnxt_re/qplib_res.c | 15 +++++++++++++++ > > > > > drivers/infiniband/hw/bnxt_re/qplib_res.h | 1 + > > > > > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 13 ++++++++++++- > > > > > drivers/infiniband/hw/bnxt_re/qplib_sp.h | 2 -- > > > > > 6 files changed, 36 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > > > > > index 2efaa80bfbd2..8194ac52a484 100644 > > > > > --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c > > > > > +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > > > > > @@ -163,6 +163,10 @@ int bnxt_re_query_device(struct ib_device *ibdev, > > > > > ib_attr->max_qp_init_rd_atom = dev_attr->max_qp_init_rd_atom; > > > > > ib_attr->atomic_cap = IB_ATOMIC_NONE; > > > > > ib_attr->masked_atomic_cap = IB_ATOMIC_NONE; > > > > > + if (dev_attr->is_atomic) { > > > > > + ib_attr->atomic_cap = IB_ATOMIC_GLOB; > > > > > + ib_attr->masked_atomic_cap = IB_ATOMIC_GLOB; > > > > > + } > > > > > > > > > > ib_attr->max_ee_rd_atom = 0; > > > > > ib_attr->max_res_rd_atom = 0; > > > > > diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c > > > > > index 8bfbf0231a9e..e91e987b7861 100644 > > > > > --- a/drivers/infiniband/hw/bnxt_re/main.c > > > > > +++ b/drivers/infiniband/hw/bnxt_re/main.c > > > > > @@ -128,6 +128,10 @@ static int bnxt_re_setup_chip_ctx(struct bnxt_re_dev *rdev, u8 wqe_mode) > > > > > rdev->rcfw.res = &rdev->qplib_res; > > > > > > > > > > bnxt_re_set_drv_mode(rdev, wqe_mode); > > > > > + if (bnxt_qplib_enable_atomic_ops_to_root(en_dev->pdev)) > > > > > + ibdev_info(&rdev->ibdev, > > > > > + "platform doesn't support global atomics."); > > > > > + > > > > > return 0; > > > > > } > > > > > > > > > > diff --git a/drivers/infiniband/hw/bnxt_re/qplib_res.c b/drivers/infiniband/hw/bnxt_re/qplib_res.c > > > > > index 3ca47004b752..d2efb295e0f6 100644 > > > > > --- a/drivers/infiniband/hw/bnxt_re/qplib_res.c > > > > > +++ b/drivers/infiniband/hw/bnxt_re/qplib_res.c > > > > > @@ -959,3 +959,18 @@ int bnxt_qplib_alloc_res(struct bnxt_qplib_res *res, struct pci_dev *pdev, > > > > > bnxt_qplib_free_res(res); > > > > > return rc; > > > > > } > > > > > + > > > > > +bool bnxt_qplib_enable_atomic_ops_to_root(struct pci_dev *dev) > > > > > > > > Why do you need open-coded variant of pci_enable_atomic_ops_to_root()? > > > That function is trying to write on the device after determination. I > > > can rename to something else to avoid partial namespace collision, not > > > a problem > > > > I saw same implementation and this was the reason of my question. > I see, you want me to drop a call to "pcie_capability_set_word(dev, > PCI_EXP_DEVCTL2, PCI_EXP_DEVCTL2_ATOMIC_REQ);" > because this becomes duplicate after pci_enable_atomic_ops_to_root(). Yes, I think so. > > > > > Thanks > > > > > > > > > > Thanks > > > > > > > > > > > > -- > > > -Regards > > > Devesh > > > > > > > -- > -Regards > Devesh