From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D85C4708F for ; Tue, 1 Jun 2021 15:43:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8912561026 for ; Tue, 1 Jun 2021 15:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234336AbhFAPpR (ORCPT ); Tue, 1 Jun 2021 11:45:17 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:43556 "EHLO mail-pf1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhFAPpQ (ORCPT ); Tue, 1 Jun 2021 11:45:16 -0400 Received: by mail-pf1-f180.google.com with SMTP id t28so1800932pfg.10; Tue, 01 Jun 2021 08:43:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8nqvdsxR+NH3rJZwNtBOf3sh1n/YKIXVAZu6aHmIR4Y=; b=isf5e3YmVixACO5BLt3X1F9K282sxiB5zydlVyyu+XchWQKNwApWcQQWmT7V3QnkCp LR1GgJeT6R/xnM4eyl7VFyz1n1m9E2mgYW+pll5HrOEstsej026qPH5nIFgLSwUZthbb YXBQP3gmz3vuO5aQCl2DnMIYn5i2wxrKQEoyvoN/pe4k039C3qT5cfQdlQYM/9Gno5GI +hJxN8Cd0AD2gswZQRH9u9FYezL66EX40ptJMnfaGUgOu/0WFEDAkztJBy2bv8v1AK8g 3ootBqPcFZFiYEvIjGNKQEaj9oWVC6OkC8FMp1weymehooK+lNO4tKQOZfQK1yC39FZd 9SVw== X-Gm-Message-State: AOAM530NBrTY0I1eA2AN6U6D/AiSu9W7jltn25zy+0+EgziS/xHmdyOV VZsd0Gj9fThdZ86t5/vY5hU= X-Google-Smtp-Source: ABdhPJzOW6RED4Ih2u20gVslejrorZChUDTMbBc7LmT9Bh1a5ny5bJVe4RLHtFbHEoIEnUODP0zInw== X-Received: by 2002:a65:4109:: with SMTP id w9mr28404216pgp.24.1622562214518; Tue, 01 Jun 2021 08:43:34 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id o27sm14771374pgb.70.2021.06.01.08.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 08:43:33 -0700 (PDT) Date: Tue, 1 Jun 2021 08:43:32 -0700 From: Moritz Fischer To: Nava kishore Manne Cc: Greg KH , "robh+dt@kernel.org" , Michal Simek , "mdf@kernel.org" , "trix@redhat.com" , "arnd@arndb.de" , Rajan Vaja , Amit Sunil Dhamne , Tejas Patel , "zou_wei@huawei.com" , Sai Krishna Potthuri , Ravi Patel , "iwamatsu@nigauri.org" , Jiaying Liang , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" , git , "chinnikishore369@gmail.com" , Appana Durga Kedareswara Rao Subject: Re: [PATCH v6 4/4] fpga: versal-fpga: Add versal fpga manager driver Message-ID: References: <20210520080954.1393-1-nava.manne@xilinx.com> <20210520080954.1393-5-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 01, 2021 at 06:56:32AM +0000, Nava kishore Manne wrote: > Hi Greg, > > Thanks for providing the review comments. > Please find my response inline. > > > -----Original Message----- > > From: Greg KH > > Sent: Thursday, May 20, 2021 2:19 PM > > To: Nava kishore Manne > > Cc: robh+dt@kernel.org; Michal Simek ; > > mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja > > ; Amit Sunil Dhamne ; > > Tejas Patel ; zou_wei@huawei.com; Sai Krishna > > Potthuri ; Ravi Patel ; > > iwamatsu@nigauri.org; Jiaying Liang ; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git ; > > chinnikishore369@gmail.com; Appana Durga Kedareswara Rao > > > > Subject: Re: [PATCH v6 4/4] fpga: versal-fpga: Add versal fpga manager driver > > > > On Thu, May 20, 2021 at 01:39:54PM +0530, Nava kishore Manne wrote: > > > Add support for Xilinx Versal FPGA manager. > > > > > > PDI source type can be DDR, OCM, QSPI flash etc.. > > > But driver allocates memory always from DDR, Since driver supports > > > only DDR source type. > > > > > > Signed-off-by: Appana Durga Kedareswara rao > > > > > > Signed-off-by: Nava kishore Manne > > > Reviewed-by: Moritz Fischer > > > --- > > > Changes for v2: > > > -Updated the Fpga Mgr registrations call's > > > to 5.11 > > > -Fixed some minor coding issues as suggested by > > > Moritz. > > > Changes for v3: > > > -Rewritten the Versal fpga Kconfig contents. > > > Changes for v4: > > > -Rebased the changes on linux-next. > > > No functional changes. > > > Changes for v5: > > > -None. > > > Changes for v6: > > > -None. > > > > > > drivers/fpga/Kconfig | 9 +++ > > > drivers/fpga/Makefile | 1 + > > > drivers/fpga/versal-fpga.c | 117 > > > +++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 127 insertions(+) > > > create mode 100644 drivers/fpga/versal-fpga.c > > > > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index > > > 33e15058d0dc..92c20b92357a 100644 > > > --- a/drivers/fpga/Kconfig > > > +++ b/drivers/fpga/Kconfig > > > @@ -234,4 +234,13 @@ config FPGA_MGR_ZYNQMP_FPGA > > > to configure the programmable logic(PL) through PS > > > on ZynqMP SoC. > > > > > > +config FPGA_MGR_VERSAL_FPGA > > > + tristate "Xilinx Versal FPGA" > > > + depends on ARCH_ZYNQMP || COMPILE_TEST > > > + help > > > + Select this option to enable FPGA manager driver support for > > > + Xilinx Versal SoC. This driver uses the firmware interface to > > > + configure the programmable logic(PL). > > > + > > > + To compile this as a module, choose M here. > > > endif # FPGA > > > diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index > > > 18dc9885883a..0bff783d1b61 100644 > > > --- a/drivers/fpga/Makefile > > > +++ b/drivers/fpga/Makefile > > > @@ -18,6 +18,7 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += > > ts73xx-fpga.o > > > obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > > > obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o > > > obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o > > > +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o > > > obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o > > > obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o > > > > > > diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c > > > new file mode 100644 index 000000000000..5744e44f981d > > > --- /dev/null > > > +++ b/drivers/fpga/versal-fpga.c > > > @@ -0,0 +1,117 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2019-2021 Xilinx, Inc. > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +/** > > > + * struct versal_fpga_priv - Private data structure > > > + * @dev: Device data structure > > > + */ > > > +struct versal_fpga_priv { > > > + struct device *dev; > > > +}; > > > > Don't you have this pointer already? What device is this exactly and why > > does it differ from the structure it currently lives in? > > > Agree, this struct is not needed. > Will fix this issue in v7. > > > > + > > > +static int versal_fpga_ops_write_init(struct fpga_manager *mgr, > > > + struct fpga_image_info *info, > > > + const char *buf, size_t size) { > > > + return 0; > > > +} > > > > If you don't need this, why include it? > > > > Agree this empty API is not needed. > It's a limitation with the framework and this needs to fixed in the fpga_manager core. > Will address this generic issue in a different series. I was working on a series to clean this up anyways :) > > > > + > > > +static int versal_fpga_ops_write(struct fpga_manager *mgr, > > > + const char *buf, size_t size) > > > +{ > > > + struct versal_fpga_priv *priv; > > > + dma_addr_t dma_addr = 0; > > > + char *kbuf; > > > + int ret; > > > + > > > + priv = mgr->priv; > > > + > > > + kbuf = dma_alloc_coherent(priv->dev, size, &dma_addr, > > GFP_KERNEL); > > > + if (!kbuf) > > > + return -ENOMEM; > > > + > > > + memcpy(kbuf, buf, size); > > > + > > > + wmb(); /* ensure all writes are done before initiate FW call */ > > > > What "writes"? The memcpy above? Are you _SURE_ that really is correct > > here? This feels wrong. > > > > Will fix in v7. > > > > + > > > + ret = zynqmp_pm_load_pdi(PDI_SRC_DDR, dma_addr); > > > > If this needs some sort of barrier, shouldn't it be in this call? > > > > Will fix in v7. > > > > + > > > + dma_free_coherent(priv->dev, size, kbuf, dma_addr); > > > + > > > + return ret; > > > +} > > > + > > > +static int versal_fpga_ops_write_complete(struct fpga_manager *mgr, > > > + struct fpga_image_info *info) > > > +{ > > > + return 0; > > > +} > > > > Again, why have it if it does nothing? > > > > Same as above. > > > > + > > > +static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager > > > +*mgr) { > > > + return FPGA_MGR_STATE_UNKNOWN; > > > +} > > > > Again, is this needed? If so, then the fpga_manager core needs to be fixed > > up :) > > > > Same as above. > > > > +static const struct fpga_manager_ops versal_fpga_ops = { > > > + .state = versal_fpga_ops_state, > > > + .write_init = versal_fpga_ops_write_init, > > > + .write = versal_fpga_ops_write, > > > + .write_complete = versal_fpga_ops_write_complete, }; > > > + > > > +static int versal_fpga_probe(struct platform_device *pdev) { > > > + struct device *dev = &pdev->dev; > > > + struct versal_fpga_priv *priv; > > > + struct fpga_manager *mgr; > > > + int ret; > > > + > > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > > + if (!priv) > > > + return -ENOMEM; > > > + > > > + priv->dev = dev; > > > > You save a pointer to a reference counted structure, without incrementing > > the reference count. What could go wrong? :) > > > > You are getting lucky here, but as stated above, why do you need this > > pointer? > > > > Will fix in v7. > > Regards, > Navakishore. - Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9AEBC4708F for ; Tue, 1 Jun 2021 15:44:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9105161026 for ; Tue, 1 Jun 2021 15:44:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9105161026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FrYhJY/7EvOC8O9yzGY7X+JE5APJkOKuDWAASwuppNo=; b=O+MhgGYPjOiztn 0kE2BfmKhsazKUfLFXHL6X+eseth49n5Aa/d2Mlw5wiX8XVWI3mnXbKOtV5Z8SQZ0NJlSgwuDhaDv eJL9TJ/eSRqnte/mEIRucnmFhgZuZocwrf5smPXw2NaBXKKSHH6j0gji4L8cBl5ly4703Q8obr41A nrTEgf0HoeVbFJPLCqvHsg9X2JgpPiNpDMlSA4dS6zrEeSOxG+5T40LjfUvTmoIzllAnOl5DAAprM YWAq1lGoq34BGSnitbQ5/SqX/52kYEnLBBeybpI9mU+9TzTgJJV0w2LMKUlQfFqTIw+uLn797IZp9 dzppGhyeKhG6TgJbOegg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo6YO-00HIFF-Pv; Tue, 01 Jun 2021 15:43:40 +0000 Received: from mail-pf1-f179.google.com ([209.85.210.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo6YK-00HIEC-4p for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 15:43:38 +0000 Received: by mail-pf1-f179.google.com with SMTP id u18so1507774pfk.11 for ; Tue, 01 Jun 2021 08:43:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8nqvdsxR+NH3rJZwNtBOf3sh1n/YKIXVAZu6aHmIR4Y=; b=d9EPJm+YVXqZbDDzeJA+x3UPriHP//eMLPB/2MdiAwLy7UsN1pYqDjs6bliqrP3G7C ktosnkVYm8Ud0Ab2xVHhUczYVCnHa244Q/kAmXOlCnLgpPAe6HsdK6Xx1DT8wUkUIg6Y /onooOQUL4n4aFCHxV8Q/VoFehbkOVcdn8YtHEt3VijlABA9bnWnavt0LD9WdepvesbR Ja6bckSV9aMxBq+kXDyGgihOhlgTXeZqdqJRGSaSBeeH0Ehf9Vx9HGsL/F6hhXIUbclG 1+E3kYYBXvAzZ0nmyq1Ma5/hUm2rcktJ++6kYoniPTMof9srP6m8Y6lQvXFc0kMvaTfr gzBw== X-Gm-Message-State: AOAM530erPZdLkT2//B0CvXpkeO4NQb60qNc6rXiPXTQnuYCFFGmuh7m xAmnn49WVhn+v068bRg/WYQ= X-Google-Smtp-Source: ABdhPJzOW6RED4Ih2u20gVslejrorZChUDTMbBc7LmT9Bh1a5ny5bJVe4RLHtFbHEoIEnUODP0zInw== X-Received: by 2002:a65:4109:: with SMTP id w9mr28404216pgp.24.1622562214518; Tue, 01 Jun 2021 08:43:34 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id o27sm14771374pgb.70.2021.06.01.08.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 08:43:33 -0700 (PDT) Date: Tue, 1 Jun 2021 08:43:32 -0700 From: Moritz Fischer To: Nava kishore Manne Cc: Greg KH , "robh+dt@kernel.org" , Michal Simek , "mdf@kernel.org" , "trix@redhat.com" , "arnd@arndb.de" , Rajan Vaja , Amit Sunil Dhamne , Tejas Patel , "zou_wei@huawei.com" , Sai Krishna Potthuri , Ravi Patel , "iwamatsu@nigauri.org" , Jiaying Liang , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" , git , "chinnikishore369@gmail.com" , Appana Durga Kedareswara Rao Subject: Re: [PATCH v6 4/4] fpga: versal-fpga: Add versal fpga manager driver Message-ID: References: <20210520080954.1393-1-nava.manne@xilinx.com> <20210520080954.1393-5-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_084336_225394_F424B07C X-CRM114-Status: GOOD ( 51.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 01, 2021 at 06:56:32AM +0000, Nava kishore Manne wrote: > Hi Greg, > > Thanks for providing the review comments. > Please find my response inline. > > > -----Original Message----- > > From: Greg KH > > Sent: Thursday, May 20, 2021 2:19 PM > > To: Nava kishore Manne > > Cc: robh+dt@kernel.org; Michal Simek ; > > mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja > > ; Amit Sunil Dhamne ; > > Tejas Patel ; zou_wei@huawei.com; Sai Krishna > > Potthuri ; Ravi Patel ; > > iwamatsu@nigauri.org; Jiaying Liang ; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git ; > > chinnikishore369@gmail.com; Appana Durga Kedareswara Rao > > > > Subject: Re: [PATCH v6 4/4] fpga: versal-fpga: Add versal fpga manager driver > > > > On Thu, May 20, 2021 at 01:39:54PM +0530, Nava kishore Manne wrote: > > > Add support for Xilinx Versal FPGA manager. > > > > > > PDI source type can be DDR, OCM, QSPI flash etc.. > > > But driver allocates memory always from DDR, Since driver supports > > > only DDR source type. > > > > > > Signed-off-by: Appana Durga Kedareswara rao > > > > > > Signed-off-by: Nava kishore Manne > > > Reviewed-by: Moritz Fischer > > > --- > > > Changes for v2: > > > -Updated the Fpga Mgr registrations call's > > > to 5.11 > > > -Fixed some minor coding issues as suggested by > > > Moritz. > > > Changes for v3: > > > -Rewritten the Versal fpga Kconfig contents. > > > Changes for v4: > > > -Rebased the changes on linux-next. > > > No functional changes. > > > Changes for v5: > > > -None. > > > Changes for v6: > > > -None. > > > > > > drivers/fpga/Kconfig | 9 +++ > > > drivers/fpga/Makefile | 1 + > > > drivers/fpga/versal-fpga.c | 117 > > > +++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 127 insertions(+) > > > create mode 100644 drivers/fpga/versal-fpga.c > > > > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index > > > 33e15058d0dc..92c20b92357a 100644 > > > --- a/drivers/fpga/Kconfig > > > +++ b/drivers/fpga/Kconfig > > > @@ -234,4 +234,13 @@ config FPGA_MGR_ZYNQMP_FPGA > > > to configure the programmable logic(PL) through PS > > > on ZynqMP SoC. > > > > > > +config FPGA_MGR_VERSAL_FPGA > > > + tristate "Xilinx Versal FPGA" > > > + depends on ARCH_ZYNQMP || COMPILE_TEST > > > + help > > > + Select this option to enable FPGA manager driver support for > > > + Xilinx Versal SoC. This driver uses the firmware interface to > > > + configure the programmable logic(PL). > > > + > > > + To compile this as a module, choose M here. > > > endif # FPGA > > > diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index > > > 18dc9885883a..0bff783d1b61 100644 > > > --- a/drivers/fpga/Makefile > > > +++ b/drivers/fpga/Makefile > > > @@ -18,6 +18,7 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += > > ts73xx-fpga.o > > > obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o > > > obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o > > > obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o > > > +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o > > > obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o > > > obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o > > > > > > diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c > > > new file mode 100644 index 000000000000..5744e44f981d > > > --- /dev/null > > > +++ b/drivers/fpga/versal-fpga.c > > > @@ -0,0 +1,117 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2019-2021 Xilinx, Inc. > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +/** > > > + * struct versal_fpga_priv - Private data structure > > > + * @dev: Device data structure > > > + */ > > > +struct versal_fpga_priv { > > > + struct device *dev; > > > +}; > > > > Don't you have this pointer already? What device is this exactly and why > > does it differ from the structure it currently lives in? > > > Agree, this struct is not needed. > Will fix this issue in v7. > > > > + > > > +static int versal_fpga_ops_write_init(struct fpga_manager *mgr, > > > + struct fpga_image_info *info, > > > + const char *buf, size_t size) { > > > + return 0; > > > +} > > > > If you don't need this, why include it? > > > > Agree this empty API is not needed. > It's a limitation with the framework and this needs to fixed in the fpga_manager core. > Will address this generic issue in a different series. I was working on a series to clean this up anyways :) > > > > + > > > +static int versal_fpga_ops_write(struct fpga_manager *mgr, > > > + const char *buf, size_t size) > > > +{ > > > + struct versal_fpga_priv *priv; > > > + dma_addr_t dma_addr = 0; > > > + char *kbuf; > > > + int ret; > > > + > > > + priv = mgr->priv; > > > + > > > + kbuf = dma_alloc_coherent(priv->dev, size, &dma_addr, > > GFP_KERNEL); > > > + if (!kbuf) > > > + return -ENOMEM; > > > + > > > + memcpy(kbuf, buf, size); > > > + > > > + wmb(); /* ensure all writes are done before initiate FW call */ > > > > What "writes"? The memcpy above? Are you _SURE_ that really is correct > > here? This feels wrong. > > > > Will fix in v7. > > > > + > > > + ret = zynqmp_pm_load_pdi(PDI_SRC_DDR, dma_addr); > > > > If this needs some sort of barrier, shouldn't it be in this call? > > > > Will fix in v7. > > > > + > > > + dma_free_coherent(priv->dev, size, kbuf, dma_addr); > > > + > > > + return ret; > > > +} > > > + > > > +static int versal_fpga_ops_write_complete(struct fpga_manager *mgr, > > > + struct fpga_image_info *info) > > > +{ > > > + return 0; > > > +} > > > > Again, why have it if it does nothing? > > > > Same as above. > > > > + > > > +static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager > > > +*mgr) { > > > + return FPGA_MGR_STATE_UNKNOWN; > > > +} > > > > Again, is this needed? If so, then the fpga_manager core needs to be fixed > > up :) > > > > Same as above. > > > > +static const struct fpga_manager_ops versal_fpga_ops = { > > > + .state = versal_fpga_ops_state, > > > + .write_init = versal_fpga_ops_write_init, > > > + .write = versal_fpga_ops_write, > > > + .write_complete = versal_fpga_ops_write_complete, }; > > > + > > > +static int versal_fpga_probe(struct platform_device *pdev) { > > > + struct device *dev = &pdev->dev; > > > + struct versal_fpga_priv *priv; > > > + struct fpga_manager *mgr; > > > + int ret; > > > + > > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > > + if (!priv) > > > + return -ENOMEM; > > > + > > > + priv->dev = dev; > > > > You save a pointer to a reference counted structure, without incrementing > > the reference count. What could go wrong? :) > > > > You are getting lucky here, but as stated above, why do you need this > > pointer? > > > > Will fix in v7. > > Regards, > Navakishore. - Moritz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel