From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Schmitz <schmitz@debian.org>,
Roman Zippel <zippel@linux-m68k.org>,
linux-input <linux-input@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Michael Schmitz <schmitzmic@gmail.com>
Subject: Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning
Date: Tue, 1 Jun 2021 21:15:46 -0700 [thread overview]
Message-ID: <YLcF8k71w1mhN9OX@google.com> (raw)
In-Reply-To: <CAMuHMdWxBDM6za4_zPrkPGja8K6vy47gfdzYMNjJ-i1n1ySsHA@mail.gmail.com>
On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote:
> On Thu, May 27, 2021 at 2:12 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> > Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
> > code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
> > this dependency.
> >
> > Removes this kconfig warning:
> >
> > WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> > Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> > Selected by [y]:
> > - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
> >
> > Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Michael Schmitz <schmitz@debian.org>
> > Cc: Roman Zippel <zippel@linux-m68k.org>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: linux-input@vger.kernel.org
> > Cc: linux-m68k@lists.linux-m68k.org
> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
>
> > ---
> > v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
> > to Kconfig.machine (Michael). Thanks.
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.
Sure, works for me.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-06-02 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 0:12 [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
2021-05-27 6:56 ` Geert Uytterhoeven
2021-06-02 4:15 ` Dmitry Torokhov [this message]
2021-06-07 14:36 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLcF8k71w1mhN9OX@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=rdunlap@infradead.org \
--cc=schmitz@debian.org \
--cc=schmitzmic@gmail.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.