From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2255C4708F for ; Wed, 2 Jun 2021 11:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DA43613D0 for ; Wed, 2 Jun 2021 11:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbhFBLI0 (ORCPT ); Wed, 2 Jun 2021 07:08:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:42108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232106AbhFBLIU (ORCPT ); Wed, 2 Jun 2021 07:08:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F359A613B8; Wed, 2 Jun 2021 11:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622631997; bh=1pg+MG37+fS5YicaXP0xD9f9S1lKkaW87BxtuaVzwvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=abv8LMc142JlLjtSs6HPx5+vRInJT+MQ2tf/b2CPy4kexX5J5IP9ju3DxlGqsSVaq t2XwUHN2uF9OluciFmOeImhgMSYjN9mBeQcPXV6ryDL+X82HL9SnreYTmTBAqjRM5B q9vpKyjI3gp4lbYDnlIp4T5jjrznwrC8R7d8vFDNmgvdi8+CzPjYfaYNoxa8Ki2Yxy SFVmIpJ9gDeIodCeku8L4WwDN7P9bv+7OtZ3Ob+c6K8j6YWx0ciWAoxnWwHChMTa7I Axcm5C5Q0l55DxiyIMwvKIMIap2gURNPWQfT3YNur0ztEGPwT9HO5v2k1Gneq2nDjP iLAImxNUDVQjw== Date: Wed, 2 Jun 2021 16:36:34 +0530 From: Vinod Koul To: Dmitry Baryshkov Cc: Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , David Airlie , Daniel Vetter , Jonathan Marek , Abhinav Kumar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data Message-ID: References: <20210521124946.3617862-1-vkoul@kernel.org> <20210521124946.3617862-5-vkoul@kernel.org> <73815f0b-b6d1-f6f3-d7aa-f77492861967@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73815f0b-b6d1-f6f3-d7aa-f77492861967@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28-05-21, 02:45, Dmitry Baryshkov wrote: > On 21/05/2021 15:49, Vinod Koul wrote: > > DSC needs some configuration from device tree, add support to read and > > store these params and add DSC structures in msm_drv > > > > Signed-off-by: Vinod Koul > > --- > > drivers/gpu/drm/msm/dsi/dsi_host.c | 170 +++++++++++++++++++++++++++++ > > drivers/gpu/drm/msm/msm_drv.h | 32 ++++++ > > 2 files changed, 202 insertions(+) > > > > > [skipped] > > > > DRM_DEV_ERROR(dev, "%s: invalid lane configuration %d\n", > > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > > index 2668941df529..26661dd43936 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.h > > +++ b/drivers/gpu/drm/msm/msm_drv.h > > @@ -30,6 +30,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > @@ -70,6 +71,16 @@ enum msm_mdp_plane_property { > > #define MSM_GPU_MAX_RINGS 4 > > #define MAX_H_TILES_PER_DISPLAY 2 > > +/** > > + * enum msm_display_compression_type - compression method used for pixel stream > > + * @MSM_DISPLAY_COMPRESSION_NONE: Pixel data is not compressed > > + * @MSM_DISPLAY_COMPRESSION_DSC: DSC compresison is used > > + */ > > +enum msm_display_compression_type { > > + MSM_DISPLAY_COMPRESSION_NONE, > > + MSM_DISPLAY_COMPRESSION_DSC, > > +}; > > + > > Seems to be unused Yeah this was started from downstream which used this and I seem to have not cleared this up, thanks for pointing. Will remove.. -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B00EC47083 for ; Wed, 2 Jun 2021 11:06:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37D88613BF for ; Wed, 2 Jun 2021 11:06:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37D88613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF39D6E3C1; Wed, 2 Jun 2021 11:06:39 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8F136E3C1; Wed, 2 Jun 2021 11:06:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F359A613B8; Wed, 2 Jun 2021 11:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622631997; bh=1pg+MG37+fS5YicaXP0xD9f9S1lKkaW87BxtuaVzwvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=abv8LMc142JlLjtSs6HPx5+vRInJT+MQ2tf/b2CPy4kexX5J5IP9ju3DxlGqsSVaq t2XwUHN2uF9OluciFmOeImhgMSYjN9mBeQcPXV6ryDL+X82HL9SnreYTmTBAqjRM5B q9vpKyjI3gp4lbYDnlIp4T5jjrznwrC8R7d8vFDNmgvdi8+CzPjYfaYNoxa8Ki2Yxy SFVmIpJ9gDeIodCeku8L4WwDN7P9bv+7OtZ3Ob+c6K8j6YWx0ciWAoxnWwHChMTa7I Axcm5C5Q0l55DxiyIMwvKIMIap2gURNPWQfT3YNur0ztEGPwT9HO5v2k1Gneq2nDjP iLAImxNUDVQjw== Date: Wed, 2 Jun 2021 16:36:34 +0530 From: Vinod Koul To: Dmitry Baryshkov Subject: Re: [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data Message-ID: References: <20210521124946.3617862-1-vkoul@kernel.org> <20210521124946.3617862-5-vkoul@kernel.org> <73815f0b-b6d1-f6f3-d7aa-f77492861967@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73815f0b-b6d1-f6f3-d7aa-f77492861967@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Bjorn Andersson , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28-05-21, 02:45, Dmitry Baryshkov wrote: > On 21/05/2021 15:49, Vinod Koul wrote: > > DSC needs some configuration from device tree, add support to read and > > store these params and add DSC structures in msm_drv > > > > Signed-off-by: Vinod Koul > > --- > > drivers/gpu/drm/msm/dsi/dsi_host.c | 170 +++++++++++++++++++++++++++++ > > drivers/gpu/drm/msm/msm_drv.h | 32 ++++++ > > 2 files changed, 202 insertions(+) > > > > > [skipped] > > > > DRM_DEV_ERROR(dev, "%s: invalid lane configuration %d\n", > > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > > index 2668941df529..26661dd43936 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.h > > +++ b/drivers/gpu/drm/msm/msm_drv.h > > @@ -30,6 +30,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > @@ -70,6 +71,16 @@ enum msm_mdp_plane_property { > > #define MSM_GPU_MAX_RINGS 4 > > #define MAX_H_TILES_PER_DISPLAY 2 > > +/** > > + * enum msm_display_compression_type - compression method used for pixel stream > > + * @MSM_DISPLAY_COMPRESSION_NONE: Pixel data is not compressed > > + * @MSM_DISPLAY_COMPRESSION_DSC: DSC compresison is used > > + */ > > +enum msm_display_compression_type { > > + MSM_DISPLAY_COMPRESSION_NONE, > > + MSM_DISPLAY_COMPRESSION_DSC, > > +}; > > + > > Seems to be unused Yeah this was started from downstream which used this and I seem to have not cleared this up, thanks for pointing. Will remove.. -- ~Vinod