From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D826C47093 for ; Wed, 2 Jun 2021 13:02:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7B3F613D7 for ; Wed, 2 Jun 2021 13:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229719AbhFBNEf (ORCPT ); Wed, 2 Jun 2021 09:04:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:36540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhFBNEd (ORCPT ); Wed, 2 Jun 2021 09:04:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E87FE613D6; Wed, 2 Jun 2021 13:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622638971; bh=9GVCr1LuCvcjTrKzbRTyT/1HGLmEne+W2aNyF5fY9Ug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FGDC1pckBbHFpilSlrP5ficerhpwZc0XRBn9Ghsgg4tiIrjuM8yFGhFATo4EU121z f+j34bWeyvWnMhSQ/KYq5AiWQi2CONmNNDeEmkLGcl77whH7PARMfnZADZZhLWlPOJ Ri3Ys/c3QfphLNRC49FJyAQoVnL6c1F/n2LFTm3Hk9O4sSKAOindmOa7e3ShRUqXro /tarCoUoHDQiHG0GI0LfgqfdtWIUUcNaQEFKTDqlh1VT4AEIbSSTNwRZNMcpG5nK8U wvMzuXQ9nSv7oMFpX2ygLn7bH63SYxQsTGZnABZVvC6NloZ7tlqHsX4mx/Yli16Ny8 HkpIWbjdJGkvg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1loQWG-0000Mb-0x; Wed, 02 Jun 2021 15:02:48 +0200 Date: Wed, 2 Jun 2021 15:02:48 +0200 From: Johan Hovold To: Nava kishore Manne Cc: mdf@kernel.org, trix@redhat.com, robh+dt@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support Message-ID: References: <20210402092049.479-1-nava.manne@xilinx.com> <20210402092049.479-4-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210402092049.479-4-nava.manne@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote: > Adds support to handle FPGA/PL power domain. With this patch, > the PL power domain will be turned on before loading the bitstream > and turned off while removing/unloading the bitstream using overlays. > This can be achieved by adding the runtime PM support. > > Signed-off-by: Nava kishore Manne > --- > drivers/fpga/of-fpga-region.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > /** > @@ -411,9 +416,16 @@ static int of_fpga_region_probe(struct platform_device *pdev) > goto eprobe_mgr_put; > } > > + pm_runtime_enable(&pdev->dev); > + ret = pm_runtime_get_sync(&pdev->dev); > + if (ret < 0) > + goto err_pm; > + > + pm_runtime_put(&pdev->dev); > + > ret = fpga_region_register(region); > if (ret) > - goto eprobe_mgr_put; > + goto err_pm; Just a drive-by comment: you have PM usage counter imbalance here (double put). > of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); > platform_set_drvdata(pdev, region); > @@ -422,6 +434,9 @@ static int of_fpga_region_probe(struct platform_device *pdev) > > return 0; > > +err_pm: > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > eprobe_mgr_put: > fpga_mgr_put(mgr); > return ret; Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D91C4708F for ; Wed, 2 Jun 2021 13:09:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8547761263 for ; Wed, 2 Jun 2021 13:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8547761263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lxVPRNfacGdTGj9Y1BYQakrPII+XUHVu1Io9TZHrZlQ=; b=z4sdXD112AK2pc HJB4BUtYgB10uJd6LmBGRkOJ1slK/S/8VN4BrU4Rv6nzlsOKBJE7p2zQtfsCSx9vqVzau1bZoYE/8 aD4fS4V4pSLsrr9oIpmI91CKqRBJnYeyYF5+a2MIbjMOYmsyb45bG4cG8HWt3X70XEba6rb0ApbaG 5pzkEe82GU7YOsiRU9f1P9SpMZGAmj1Dyjds8RNjVONeWT03KwBdYfZ0/xDMT1tDHLg6g0VlgrFJa sMpJtggYc7rWOqpyYSbTpm8jbYPreSHKoI0A2BY58oNrBeub+04OOHseqjYpmjDfB+THcHv3qSRj2 Qg1LMQRPm9eME9kUYs3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loQaP-004G7x-Oo; Wed, 02 Jun 2021 13:07:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loQWJ-004E31-9G for linux-arm-kernel@lists.infradead.org; Wed, 02 Jun 2021 13:02:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E87FE613D6; Wed, 2 Jun 2021 13:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622638971; bh=9GVCr1LuCvcjTrKzbRTyT/1HGLmEne+W2aNyF5fY9Ug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FGDC1pckBbHFpilSlrP5ficerhpwZc0XRBn9Ghsgg4tiIrjuM8yFGhFATo4EU121z f+j34bWeyvWnMhSQ/KYq5AiWQi2CONmNNDeEmkLGcl77whH7PARMfnZADZZhLWlPOJ Ri3Ys/c3QfphLNRC49FJyAQoVnL6c1F/n2LFTm3Hk9O4sSKAOindmOa7e3ShRUqXro /tarCoUoHDQiHG0GI0LfgqfdtWIUUcNaQEFKTDqlh1VT4AEIbSSTNwRZNMcpG5nK8U wvMzuXQ9nSv7oMFpX2ygLn7bH63SYxQsTGZnABZVvC6NloZ7tlqHsX4mx/Yli16Ny8 HkpIWbjdJGkvg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1loQWG-0000Mb-0x; Wed, 02 Jun 2021 15:02:48 +0200 Date: Wed, 2 Jun 2021 15:02:48 +0200 From: Johan Hovold To: Nava kishore Manne Cc: mdf@kernel.org, trix@redhat.com, robh+dt@kernel.org, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Subject: Re: [PATCH 3/3] fpga: region: Adds runtime PM support Message-ID: References: <20210402092049.479-1-nava.manne@xilinx.com> <20210402092049.479-4-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210402092049.479-4-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_060251_408557_14061492 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 02, 2021 at 02:50:49PM +0530, Nava kishore Manne wrote: > Adds support to handle FPGA/PL power domain. With this patch, > the PL power domain will be turned on before loading the bitstream > and turned off while removing/unloading the bitstream using overlays. > This can be achieved by adding the runtime PM support. > > Signed-off-by: Nava kishore Manne > --- > drivers/fpga/of-fpga-region.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > /** > @@ -411,9 +416,16 @@ static int of_fpga_region_probe(struct platform_device *pdev) > goto eprobe_mgr_put; > } > > + pm_runtime_enable(&pdev->dev); > + ret = pm_runtime_get_sync(&pdev->dev); > + if (ret < 0) > + goto err_pm; > + > + pm_runtime_put(&pdev->dev); > + > ret = fpga_region_register(region); > if (ret) > - goto eprobe_mgr_put; > + goto err_pm; Just a drive-by comment: you have PM usage counter imbalance here (double put). > of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev); > platform_set_drvdata(pdev, region); > @@ -422,6 +434,9 @@ static int of_fpga_region_probe(struct platform_device *pdev) > > return 0; > > +err_pm: > + pm_runtime_put(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > eprobe_mgr_put: > fpga_mgr_put(mgr); > return ret; Johan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel