From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3861AC47083 for ; Wed, 2 Jun 2021 14:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20843613BF for ; Wed, 2 Jun 2021 14:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbhFBO1X (ORCPT ); Wed, 2 Jun 2021 10:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbhFBO1W (ORCPT ); Wed, 2 Jun 2021 10:27:22 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B16B8C061574; Wed, 2 Jun 2021 07:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FXtOoRkqKzh7kLJLNx1aUNoAKOt2OwhOUmVlEeFOV/k=; b=aRuCf7uzTZTu6Zoj/CNNkrWz2p NiTO7Wp3c1qPbyOpXwrYp1PtzDWjm9lFd/a9yCbHrEoTHdjq7a3h6AyF0BhDXTQ3QxkDP57PRhMDO zEAZMYNvsYz4QiZA1N4mjgb4wXj7bSBZgp8Pj/xrfNSCm3M3p7yfnXQJFAELoJtdR+E6Ao31ANWBK 327hKxLUv5HjbIqhiob98T4BjpKz+Vu+QWE82pAMH8ZWHQCaLUEhWPpOLHq5XbviYzak8e7g6jAgm AiylRMwPRrr6GP8fi1UzCBGjGo3iWRRsemSjXVXxNvj6tuH5bjajvu6yIt+A7WLPb35t2K8sXA42g 5gfHi5dg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1loRmn-00BCUs-DM; Wed, 02 Jun 2021 14:24:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D1C23300269; Wed, 2 Jun 2021 16:23:56 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B6EF620223DA8; Wed, 2 Jun 2021 16:23:56 +0200 (CEST) Date: Wed, 2 Jun 2021 16:23:56 +0200 From: Peter Zijlstra To: Mathieu Desnoyers Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , rostedt , Ben Segall , Mel Gorman , bristot , Borislav Petkov , x86 , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , acme , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , paulmck , Josh Triplett , Lai Jiangshan , "Joel Fernandes, Google" , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , linux-kernel , linux-block@vger.kernel.org, netdev , linux-usb@vger.kernel.org, linux-fsdevel , cgroups , kgdb-bugreport@lists.sourceforge.net, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, rcu , linux-mm , KVM list Subject: Re: [PATCH 3/6] sched,perf,kvm: Fix preemption condition Message-ID: References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Jun 02, 2021 at 10:15:16AM -0400, Mathieu Desnoyers wrote: > ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: > [...] > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > > }, > > }; > > > > - if (!sched_in && task->state == TASK_RUNNING) > > + if (!sched_in && current->on_rq) { > > switch_event.event_id.header.misc |= > > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > > + } > > > > - perf_iterate_sb(perf_event_switch_output, > > - &switch_event, > > - NULL); > > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > > } > > There is a lot of code cleanup going on here which does not seem to belong > to a "Fix" patch. Maybe, but I so hate whitespace only patches :-/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE3BC47097 for ; Thu, 3 Jun 2021 06:33:55 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17500613F2 for ; Thu, 3 Jun 2021 06:33:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17500613F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-aPKNGwAoPhKeI7ZfkvQSAw-1; Thu, 03 Jun 2021 02:33:20 -0400 X-MC-Unique: aPKNGwAoPhKeI7ZfkvQSAw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34D85107ACF9; Thu, 3 Jun 2021 06:33:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15D1E614FD; Thu, 3 Jun 2021 06:33:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D6DE744A5E; Thu, 3 Jun 2021 06:33:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 152EPRo5000320 for ; Wed, 2 Jun 2021 10:25:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id BEDA12162382; Wed, 2 Jun 2021 14:25:27 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAF9F2162383 for ; Wed, 2 Jun 2021 14:25:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF2F210334A4 for ; Wed, 2 Jun 2021 14:25:23 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-QRFMJvVEPdW-TCFVqSAZtQ-1; Wed, 02 Jun 2021 10:25:19 -0400 X-MC-Unique: QRFMJvVEPdW-TCFVqSAZtQ-1 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1loRmn-00BCUs-DM; Wed, 02 Jun 2021 14:24:00 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D1C23300269; Wed, 2 Jun 2021 16:23:56 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B6EF620223DA8; Wed, 2 Jun 2021 16:23:56 +0200 (CEST) Date: Wed, 2 Jun 2021 16:23:56 +0200 From: Peter Zijlstra To: Mathieu Desnoyers Message-ID: References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 In-Reply-To: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Mimecast-Spam-Signature: yes X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Thu, 03 Jun 2021 02:32:49 -0400 Cc: Juri Lelli , Mark Rutland , Pavel Machek , Mike Snitzer , Alexander Shishkin , kgdb-bugreport@lists.sourceforge.net, Lai Jiangshan , Oleg Nesterov , Ben Segall , linux-mm , dm-devel@redhat.com, Paolo Bonzini , Zefan Li , "H. Peter Anvin" , "Joel Fernandes, Google" , netdev , Jiri Olsa , Alasdair Kergon , Daniel Thompson , Davidlohr Bueso , Vincent Guittot , KVM list , Will Deacon , cgroups , x86 , Ingo Molnar , Mel Gorman , Jakub Kicinski , paulmck , linux-pm@vger.kernel.org, Boqun Feng , Jason Wessel , Josh Triplett , rostedt , linux-block@vger.kernel.org, linux-fsdevel , Borislav Petkov , Alexander Viro , Waiman Long , Namhyung Kim , Thomas Gleixner , acme , Dietmar Eggemann , Jens Axboe , Felipe Balbi , Stephen Boyd , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Douglas Anderson , linux-kernel , linux-perf-users@vger.kernel.org, Johannes Weiner , Tejun Heo , John Stultz , Andrew Morton , rcu , bristot , "David S. Miller" Subject: Re: [dm-devel] [PATCH 3/6] sched, perf, kvm: Fix preemption condition X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 02, 2021 at 10:15:16AM -0400, Mathieu Desnoyers wrote: > ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: > [...] > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > > }, > > }; > > > > - if (!sched_in && task->state == TASK_RUNNING) > > + if (!sched_in && current->on_rq) { > > switch_event.event_id.header.misc |= > > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > > + } > > > > - perf_iterate_sb(perf_event_switch_output, > > - &switch_event, > > - NULL); > > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > > } > > There is a lot of code cleanup going on here which does not seem to belong > to a "Fix" patch. Maybe, but I so hate whitespace only patches :-/ -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 3/6] sched,perf,kvm: Fix preemption condition Date: Wed, 2 Jun 2021 16:23:56 +0200 Message-ID: References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FXtOoRkqKzh7kLJLNx1aUNoAKOt2OwhOUmVlEeFOV/k=; b=CHh50MAnwHptxKKeb98FX0zBM/ hZGvhB4OgPfd+ch/7Q4Awrbwu4YMPhZZyT4MBL6ufwo9T1X3jzwrDiV2mV+NLG+uaGFtpk4wJW0Sl qULAlfcMVVVzXG+nvaGIKpuQWC7oHU4cD3sRPQLrMBkEqwZcdjHxvNg+me0S6xPh9OUSlXXgEDC6Z pzRSlZNULro6LWJusA97DADN/jHRNpmBokq3XpapoFAiUebSvq5DGMtNHHjHI7P94iuGqIHoF5IK5 c9Cs6a/FvoaHXq4eeNZQEa+OSz+uu1jB7/A+OTqK1Log/LLFviNFlK2bXPZ1hwESu9YATeOjws0cR 3OjnDBZg==; Content-Disposition: inline In-Reply-To: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mathieu Desnoyers Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , rostedt , Ben Segall , Mel Gorman , bristot , Borislav Petkov , x86 , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li On Wed, Jun 02, 2021 at 10:15:16AM -0400, Mathieu Desnoyers wrote: > ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: > [...] > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > > }, > > }; > > > > - if (!sched_in && task->state == TASK_RUNNING) > > + if (!sched_in && current->on_rq) { > > switch_event.event_id.header.misc |= > > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > > + } > > > > - perf_iterate_sb(perf_event_switch_output, > > - &switch_event, > > - NULL); > > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > > } > > There is a lot of code cleanup going on here which does not seem to belong > to a "Fix" patch. Maybe, but I so hate whitespace only patches :-/