All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v5 00/11] dm: Improve zoned block device support
Date: Wed, 2 Jun 2021 14:32:55 -0400	[thread overview]
Message-ID: <YLfO168QXfAWJ9dn@redhat.com> (raw)
In-Reply-To: <DM6PR04MB708146E418BF65FC2F7847E3E73E9@DM6PR04MB7081.namprd04.prod.outlook.com>

On Tue, Jun 01 2021 at  6:57P -0400,
Damien Le Moal <Damien.LeMoal@wdc.com> wrote:

> On 2021/05/26 6:25, Damien Le Moal wrote:
> > This series improve device mapper support for zoned block devices and
> > of targets exposing a zoned device.
> 
> Mike, Jens,
> 
> Any feedback regarding this series ?
> 
> > 
> > The first patch improve support for user requests to reset all zones of
> > the target device. With the fix, such operation behave similarly to
> > physical block devices implementation based on the single zone reset
> > command with the ALL bit set.
> > 
> > The following 2 patches are preparatory block layer patches.
> > 
> > Patch 4 and 5 are 2 small fixes to DM core zoned block device support.
> > 
> > Patch 6 reorganizes DM core code, moving conditionally defined zoned
> > block device code into the new dm-zone.c file. This avoids sprinkly DM
> > with zone related code defined under an #ifdef CONFIG_BLK_DEV_ZONED.
> > 
> > Patch 7 improves DM zone report helper functions for target drivers.
> > 
> > Patch 8 fixes a potential problem with BIO requeue on zoned target.
> > 
> > Finally, patch 9 to 11 implement zone append emulation using regular
> > writes for target drivers that cannot natively support this BIO type.
> > The only target currently needing this emulation is dm-crypt. With this
> > change, a zoned dm-crypt device behaves exactly like a regular zoned
> > block device, correctly executing user zone append BIOs.
> > 
> > This series passes the following tests:
> > 1) zonefs tests on top of dm-crypt with a zoned nullblk device
> > 2) zonefs tests on top of dm-crypt+dm-linear with an SMR HDD
> > 3) btrfs fstests on top of dm-crypt with zoned nullblk devices.
> > 
> > Comments are as always welcome.

I've picked up DM patches 4-8 because they didn't depend on the first
3 block patches.

But I'm fine with picking up 1-3 if Jens provides his Acked-by.
And then I can pickup the remaining DM patches 9-11.

Thanks,
Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [dm-devel] [PATCH v5 00/11] dm: Improve zoned block device support
Date: Wed, 2 Jun 2021 14:32:55 -0400	[thread overview]
Message-ID: <YLfO168QXfAWJ9dn@redhat.com> (raw)
In-Reply-To: <DM6PR04MB708146E418BF65FC2F7847E3E73E9@DM6PR04MB7081.namprd04.prod.outlook.com>

On Tue, Jun 01 2021 at  6:57P -0400,
Damien Le Moal <Damien.LeMoal@wdc.com> wrote:

> On 2021/05/26 6:25, Damien Le Moal wrote:
> > This series improve device mapper support for zoned block devices and
> > of targets exposing a zoned device.
> 
> Mike, Jens,
> 
> Any feedback regarding this series ?
> 
> > 
> > The first patch improve support for user requests to reset all zones of
> > the target device. With the fix, such operation behave similarly to
> > physical block devices implementation based on the single zone reset
> > command with the ALL bit set.
> > 
> > The following 2 patches are preparatory block layer patches.
> > 
> > Patch 4 and 5 are 2 small fixes to DM core zoned block device support.
> > 
> > Patch 6 reorganizes DM core code, moving conditionally defined zoned
> > block device code into the new dm-zone.c file. This avoids sprinkly DM
> > with zone related code defined under an #ifdef CONFIG_BLK_DEV_ZONED.
> > 
> > Patch 7 improves DM zone report helper functions for target drivers.
> > 
> > Patch 8 fixes a potential problem with BIO requeue on zoned target.
> > 
> > Finally, patch 9 to 11 implement zone append emulation using regular
> > writes for target drivers that cannot natively support this BIO type.
> > The only target currently needing this emulation is dm-crypt. With this
> > change, a zoned dm-crypt device behaves exactly like a regular zoned
> > block device, correctly executing user zone append BIOs.
> > 
> > This series passes the following tests:
> > 1) zonefs tests on top of dm-crypt with a zoned nullblk device
> > 2) zonefs tests on top of dm-crypt+dm-linear with an SMR HDD
> > 3) btrfs fstests on top of dm-crypt with zoned nullblk devices.
> > 
> > Comments are as always welcome.

I've picked up DM patches 4-8 because they didn't depend on the first
3 block patches.

But I'm fine with picking up 1-3 if Jens provides his Acked-by.
And then I can pickup the remaining DM patches 9-11.

Thanks,
Mike

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-06-02 18:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 21:24 [PATCH v5 00/11] dm: Improve zoned block device support Damien Le Moal
2021-05-25 21:24 ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 01/11] block: improve handling of all zones reset operation Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-26  6:36   ` Hannes Reinecke
2021-05-26  6:36     ` [dm-devel] " Hannes Reinecke
2021-05-25 21:24 ` [PATCH v5 02/11] block: introduce bio zone helpers Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 03/11] block: introduce BIO_ZONE_WRITE_LOCKED bio flag Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 04/11] dm: Fix dm_accept_partial_bio() Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 05/11] dm: cleanup device_area_is_invalid() Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 06/11] dm: move zone related code to dm-zone.c Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 07/11] dm: Introduce dm_report_zones() Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 08/11] dm: Forbid requeue of writes to zones Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-06-04 14:56   ` Mike Snitzer
2021-06-04 14:56     ` [dm-devel] " Mike Snitzer
2021-06-05  0:17     ` Damien Le Moal
2021-06-05  0:17       ` [dm-devel] " Damien Le Moal
2021-05-25 21:24 ` [PATCH v5 09/11] dm: rearrange core declarations Damien Le Moal
2021-05-25 21:24   ` [dm-devel] " Damien Le Moal
2021-05-25 21:25 ` [PATCH v5 10/11] dm: introduce zone append emulation Damien Le Moal
2021-05-25 21:25   ` [dm-devel] " Damien Le Moal
2021-05-26  6:40   ` Hannes Reinecke
2021-05-26  6:40     ` [dm-devel] " Hannes Reinecke
2021-05-25 21:25 ` [PATCH v5 11/11] dm crypt: Fix zoned block device support Damien Le Moal
2021-05-25 21:25   ` [dm-devel] " Damien Le Moal
2021-06-01 22:57 ` [PATCH v5 00/11] dm: Improve " Damien Le Moal
2021-06-01 22:57   ` [dm-devel] " Damien Le Moal
2021-06-02 18:32   ` Mike Snitzer [this message]
2021-06-02 18:32     ` Mike Snitzer
2021-06-03 17:46     ` Jens Axboe
2021-06-03 17:46       ` [dm-devel] " Jens Axboe
2021-06-03 22:16       ` Mike Snitzer
2021-06-03 22:16         ` [dm-devel] " Mike Snitzer
2021-06-03 23:44         ` Damien Le Moal
2021-06-03 23:44           ` [dm-devel] " Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLfO168QXfAWJ9dn@redhat.com \
    --to=snitzer@redhat.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.