All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: ysato@users.sourceforge.jp, akpm@linux-foundation.org,
	sboyd@kernel.org, geert+renesas@glider.be,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] h8300: Remove unused variable
Date: Wed, 2 Jun 2021 22:04:24 +0300	[thread overview]
Message-ID: <YLfWONfYC0Fw2mdL@kernel.org> (raw)
In-Reply-To: <20210602185431.11416-1-jrdr.linux@gmail.com>

On Thu, Jun 03, 2021 at 12:24:31AM +0530, Souptick Joarder wrote:
> Kernel test robot throws below warning ->
> 
> >> arch/h8300/kernel/setup.c:72:26:
> warning: Unused variable: region [unusedVariable]
>     struct memblock_region *region;
> 
> Fixed it by removing unused variable.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

I believe a Fixes: tag would be appropriate here. Otherwise

Acked-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  arch/h8300/kernel/setup.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index 15280af7251c..5745a763dc78 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
>  
>  static void __init bootmem_init(void)
>  {
> -	struct memblock_region *region;
> -
>  	memory_end = memory_start = 0;
>  
>  	/* Find main memory where is the kernel */
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.

  reply	other threads:[~2021-06-02 19:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02 18:54 [PATCH] h8300: Remove unused variable Souptick Joarder
2021-06-02 19:04 ` Mike Rapoport [this message]
2021-06-06 14:27 ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLfWONfYC0Fw2mdL@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=geert+renesas@glider.be \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sboyd@kernel.org \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.