From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel-team@android.com
Subject: Re: [PATCH 2/2] f2fs: Advertise encrypted casefolding in sysfs
Date: Wed, 2 Jun 2021 12:54:30 -0700 [thread overview]
Message-ID: <YLfh9pv1fDT+Q3pe@sol.localdomain> (raw)
In-Reply-To: <20210602041539.123097-3-drosen@google.com>
On Wed, Jun 02, 2021 at 04:15:39AM +0000, Daniel Rosenberg wrote:
> +#ifdef CONFIG_UNICODE
> +F2FS_FEATURE_RO_ATTR(encrypted_casefold, FEAT_ENCRYPTED_CASEFOLD);
> +#endif
Shouldn't it be defined(CONFIG_UNICODE) && defined(CONFIG_FS_ENCRYPTION)?
> #endif
> #ifdef CONFIG_BLK_DEV_ZONED
> F2FS_FEATURE_RO_ATTR(block_zoned, FEAT_BLKZONED);
> @@ -815,6 +823,9 @@ static struct attribute *f2fs_feat_attrs[] = {
> #ifdef CONFIG_FS_ENCRYPTION
> ATTR_LIST(encryption),
> ATTR_LIST(test_dummy_encryption_v2),
> +#ifdef CONFIG_UNICODE
> + ATTR_LIST(encrypted_casefold),
> +#endif
Likewise here.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: Advertise encrypted casefolding in sysfs
Date: Wed, 2 Jun 2021 12:54:30 -0700 [thread overview]
Message-ID: <YLfh9pv1fDT+Q3pe@sol.localdomain> (raw)
In-Reply-To: <20210602041539.123097-3-drosen@google.com>
On Wed, Jun 02, 2021 at 04:15:39AM +0000, Daniel Rosenberg wrote:
> +#ifdef CONFIG_UNICODE
> +F2FS_FEATURE_RO_ATTR(encrypted_casefold, FEAT_ENCRYPTED_CASEFOLD);
> +#endif
Shouldn't it be defined(CONFIG_UNICODE) && defined(CONFIG_FS_ENCRYPTION)?
> #endif
> #ifdef CONFIG_BLK_DEV_ZONED
> F2FS_FEATURE_RO_ATTR(block_zoned, FEAT_BLKZONED);
> @@ -815,6 +823,9 @@ static struct attribute *f2fs_feat_attrs[] = {
> #ifdef CONFIG_FS_ENCRYPTION
> ATTR_LIST(encryption),
> ATTR_LIST(test_dummy_encryption_v2),
> +#ifdef CONFIG_UNICODE
> + ATTR_LIST(encrypted_casefold),
> +#endif
Likewise here.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-02 19:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 4:15 [PATCH 0/2] Fix up casefolding sysfs entries for F2FS Daniel Rosenberg
2021-06-02 4:15 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-02 4:15 ` [PATCH 1/2] f2fs: Show casefolding support only when supported Daniel Rosenberg
2021-06-02 4:15 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-02 14:54 ` Chao Yu
2021-06-02 14:54 ` [f2fs-dev] " Chao Yu
2021-06-02 19:51 ` Eric Biggers
2021-06-02 19:51 ` [f2fs-dev] " Eric Biggers
2021-06-02 4:15 ` [PATCH 2/2] f2fs: Advertise encrypted casefolding in sysfs Daniel Rosenberg
2021-06-02 4:15 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-02 14:57 ` Chao Yu
2021-06-02 14:57 ` [f2fs-dev] " Chao Yu
2021-06-02 19:54 ` Eric Biggers [this message]
2021-06-02 19:54 ` Eric Biggers
2021-06-02 23:22 ` Daniel Rosenberg
2021-06-02 23:22 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-02 23:49 ` Eric Biggers
2021-06-02 23:49 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLfh9pv1fDT+Q3pe@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.