From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E07EC47096 for ; Thu, 3 Jun 2021 08:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74BD3613E3 for ; Thu, 3 Jun 2021 08:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbhFCI1X (ORCPT ); Thu, 3 Jun 2021 04:27:23 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:46057 "EHLO mail-ej1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbhFCI1W (ORCPT ); Thu, 3 Jun 2021 04:27:22 -0400 Received: by mail-ej1-f46.google.com with SMTP id k7so7911511ejv.12 for ; Thu, 03 Jun 2021 01:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o5kw+//VKIV37NgUU8wnmMDxCrt1xJBfaT2OcQb5jmY=; b=HwePD0yuklUKjr79BnSZIco6VX+WGTu+HoObY1IfqheNz9RFW3He0JEzFE3xSogSMH c5ZLoP6FaKZOCrVU0u0JYWiuzpe5sIRL/Udyunk1j1jKHDxvWr+FO/s2rURfr0HAGO89 0VKv2sc1F1D/mzb0AgmjlL/C7qS0K3A2HD+cg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o5kw+//VKIV37NgUU8wnmMDxCrt1xJBfaT2OcQb5jmY=; b=i7l9m/wPtMxK11T9FfYnN6X43AhRSh2JTUASu05vXHY/cRH+ApuemFDeUx4eSlwiIm JU5JPoGWeJiVBHOHlgcos3n6O3Yz5neu0A1cWVz19stG+3YL4sWYpakwXcwvUL+5f5Rr D0rw3j94YL5Go7wvcn2AYi0E1FrfxtrWRwcm2cP2KReQDQMv88ycJLgo6Qf6KqC+oxqr uc7C/DhpzVz6j+s3sjR0MHKl+pOAd7OLOTRYI7Hzf6Xy8BYd1wxppTnoykSwt6csdXcl 56Q5qKmvJs3dNvVkviMO9rnRV5vRhO/lrheuvzJ5L4YbZGGS2/ur5aNd+//bd5HiOaXH qgOQ== X-Gm-Message-State: AOAM531+vXgHgLvn4DvzrzKlRS6n8LPdDOziJdNaqlkx/aCehVZj14YY TI5+EtUQsPoA9B/7fgiy10HxHtzKADyJxg== X-Google-Smtp-Source: ABdhPJyoowUPQmDFu4llPYKbjkkVb3iq/NgCwmOUL6l4PJA5WX11nE+fiyjr4bx7EwbTnwVE7ck8qw== X-Received: by 2002:a17:906:489:: with SMTP id f9mr19691933eja.508.1622708664167; Thu, 03 Jun 2021 01:24:24 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id r12sm1317922edv.82.2021.06.03.01.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 01:24:23 -0700 (PDT) Date: Thu, 3 Jun 2021 10:24:21 +0200 From: Daniel Vetter To: Jason Ekstrand Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Jason Ekstrand , Marcin Slusarz , stable@vger.kernel.org, Daniel Vetter , Jon Bloomfield Subject: Re: [PATCH 4/5] Revert "drm/i915: Propagate errors on awaiting already signaled fences" Message-ID: References: <20210602164149.391653-1-jason@jlekstrand.net> <20210602164149.391653-5-jason@jlekstrand.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210602164149.391653-5-jason@jlekstrand.net> X-Operating-System: Linux phenom 5.10.32scarlett+ Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jun 02, 2021 at 11:41:48AM -0500, Jason Ekstrand wrote: > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > since that commit, we've been having issues where a hang in one client > can propagate to another. In particular, a hang in an app can propagate > to the X server which causes the whole desktop to lock up. I think we need a note to backporters here: "For backporters: Please note that you _must_ have a backport of https://lore.kernel.org/dri-devel/20210602164149.391653-2-jason@jlekstrand.net/ for otherwise backporting just this patch opens up a security bug." Or something like that. -Daniel > Signed-off-by: Jason Ekstrand > Reported-by: Marcin Slusarz > Cc: # v5.6+ > Cc: Jason Ekstrand > Cc: Marcin Slusarz > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3080 > Fixes: 9e31c1fe45d5 ("drm/i915: Propagate errors on awaiting already signaled fences") > Signed-off-by: Daniel Vetter > Reviewed-by: Jon Bloomfield > --- > drivers/gpu/drm/i915/i915_request.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c > index 970d8f4986bbe..b796197c07722 100644 > --- a/drivers/gpu/drm/i915/i915_request.c > +++ b/drivers/gpu/drm/i915/i915_request.c > @@ -1426,10 +1426,8 @@ i915_request_await_execution(struct i915_request *rq, > > do { > fence = *child++; > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { > - i915_sw_fence_set_error_once(&rq->submit, fence->error); > + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) > continue; > - } > > if (fence->context == rq->fence.context) > continue; > @@ -1527,10 +1525,8 @@ i915_request_await_dma_fence(struct i915_request *rq, struct dma_fence *fence) > > do { > fence = *child++; > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { > - i915_sw_fence_set_error_once(&rq->submit, fence->error); > + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) > continue; > - } > > /* > * Requests on the same timeline are explicitly ordered, along > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4FEC47082 for ; Thu, 3 Jun 2021 08:24:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8272613DA for ; Thu, 3 Jun 2021 08:24:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8272613DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 48BFF6F427; Thu, 3 Jun 2021 08:24:26 +0000 (UTC) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by gabe.freedesktop.org (Postfix) with ESMTPS id 845276F427 for ; Thu, 3 Jun 2021 08:24:25 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id og14so2660301ejc.5 for ; Thu, 03 Jun 2021 01:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o5kw+//VKIV37NgUU8wnmMDxCrt1xJBfaT2OcQb5jmY=; b=HwePD0yuklUKjr79BnSZIco6VX+WGTu+HoObY1IfqheNz9RFW3He0JEzFE3xSogSMH c5ZLoP6FaKZOCrVU0u0JYWiuzpe5sIRL/Udyunk1j1jKHDxvWr+FO/s2rURfr0HAGO89 0VKv2sc1F1D/mzb0AgmjlL/C7qS0K3A2HD+cg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o5kw+//VKIV37NgUU8wnmMDxCrt1xJBfaT2OcQb5jmY=; b=meyWW3tZvIwj/20Af59j7K1Q3qqu8g0Kj5Yjf6Q8NkBm+A7ez/0FMPKdnp0r7KTEp1 CA4trE4xs3f57Szfp4nkZ2yWIseCPrssIfCbr1cUwom+X62QSVVetiX6HJB+Low5ZS9L PSUZkS8o+no6NytZK1wqCo2Z7V6QtPW+VK3FI556DoD6/j60lwNuF2fwtpaOb/GdUo93 mwh68xiOWUFO3OnnTy7j2EtXr4lTPbMFeMm4IysEVAr7YEQnDNSipAVGFRE7HBFKB1gg zQtBVrIMsEwY1p6UWZRTNIU2epX4BRSrYfjHO7qaIaB+hAbiZVEZWona4X3nVvQc7QRw L2Ow== X-Gm-Message-State: AOAM530wvRDBj7CBzRRTlLlk3NZ/Zd6A6XQuC9Hp/BZw6s2DBzwppU9B QrbNvh/N7RB8wD3A5Ci91UMiBQ== X-Google-Smtp-Source: ABdhPJyoowUPQmDFu4llPYKbjkkVb3iq/NgCwmOUL6l4PJA5WX11nE+fiyjr4bx7EwbTnwVE7ck8qw== X-Received: by 2002:a17:906:489:: with SMTP id f9mr19691933eja.508.1622708664167; Thu, 03 Jun 2021 01:24:24 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id r12sm1317922edv.82.2021.06.03.01.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 01:24:23 -0700 (PDT) Date: Thu, 3 Jun 2021 10:24:21 +0200 From: Daniel Vetter To: Jason Ekstrand Subject: Re: [PATCH 4/5] Revert "drm/i915: Propagate errors on awaiting already signaled fences" Message-ID: References: <20210602164149.391653-1-jason@jlekstrand.net> <20210602164149.391653-5-jason@jlekstrand.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210602164149.391653-5-jason@jlekstrand.net> X-Operating-System: Linux phenom 5.10.32scarlett+ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Jason Ekstrand , Jon Bloomfield , dri-devel@lists.freedesktop.org, Marcin Slusarz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jun 02, 2021 at 11:41:48AM -0500, Jason Ekstrand wrote: > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > since that commit, we've been having issues where a hang in one client > can propagate to another. In particular, a hang in an app can propagate > to the X server which causes the whole desktop to lock up. I think we need a note to backporters here: "For backporters: Please note that you _must_ have a backport of https://lore.kernel.org/dri-devel/20210602164149.391653-2-jason@jlekstrand.net/ for otherwise backporting just this patch opens up a security bug." Or something like that. -Daniel > Signed-off-by: Jason Ekstrand > Reported-by: Marcin Slusarz > Cc: # v5.6+ > Cc: Jason Ekstrand > Cc: Marcin Slusarz > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3080 > Fixes: 9e31c1fe45d5 ("drm/i915: Propagate errors on awaiting already signaled fences") > Signed-off-by: Daniel Vetter > Reviewed-by: Jon Bloomfield > --- > drivers/gpu/drm/i915/i915_request.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c > index 970d8f4986bbe..b796197c07722 100644 > --- a/drivers/gpu/drm/i915/i915_request.c > +++ b/drivers/gpu/drm/i915/i915_request.c > @@ -1426,10 +1426,8 @@ i915_request_await_execution(struct i915_request *rq, > > do { > fence = *child++; > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { > - i915_sw_fence_set_error_once(&rq->submit, fence->error); > + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) > continue; > - } > > if (fence->context == rq->fence.context) > continue; > @@ -1527,10 +1525,8 @@ i915_request_await_dma_fence(struct i915_request *rq, struct dma_fence *fence) > > do { > fence = *child++; > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { > - i915_sw_fence_set_error_once(&rq->submit, fence->error); > + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) > continue; > - } > > /* > * Requests on the same timeline are explicitly ordered, along > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25A9C47096 for ; Thu, 3 Jun 2021 08:24:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1D82613DA for ; Thu, 3 Jun 2021 08:24:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1D82613DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53D056F42C; Thu, 3 Jun 2021 08:24:26 +0000 (UTC) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A55D6F42C for ; Thu, 3 Jun 2021 08:24:25 +0000 (UTC) Received: by mail-ej1-x634.google.com with SMTP id ci15so7921003ejc.10 for ; Thu, 03 Jun 2021 01:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o5kw+//VKIV37NgUU8wnmMDxCrt1xJBfaT2OcQb5jmY=; b=HwePD0yuklUKjr79BnSZIco6VX+WGTu+HoObY1IfqheNz9RFW3He0JEzFE3xSogSMH c5ZLoP6FaKZOCrVU0u0JYWiuzpe5sIRL/Udyunk1j1jKHDxvWr+FO/s2rURfr0HAGO89 0VKv2sc1F1D/mzb0AgmjlL/C7qS0K3A2HD+cg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o5kw+//VKIV37NgUU8wnmMDxCrt1xJBfaT2OcQb5jmY=; b=nI21FTpLp5s9qjS1JxhKiJd+160cxMZ7NVirSKRJxM+h4euBMQ2WmWWJ+7d9tSb6zG SeDOqBYNGSKzk5P9ZBERkNKlkesDdsdPoMDvp1sGE/6AWZAEET/TELON+wPzzL8GPSim sZxulgxXILMWeNH8pD0yBRDUmG3iWxN6XFB0oayeUi7NJyx5G7oTVirDqa/OjbTQ+E8B I2r2rqcChCLqOWfUob1Yfwy2XyIAuSBQT28OE1HZ4GdMUuEMX4vogwInWao2hwPPWnlh GlyfBFQPFVO8/gRW4HrdeMItiAo1QiRh5PGP9M7CEddxtzRQj8sToreraJKZk12H4Day WAJQ== X-Gm-Message-State: AOAM5324MFiM6gwBw9eeDRQmSu+VSPmEK1wmlV+0s3ddp+5arhKaprcw JoukfxY3oCiCfjKc4FPFd4SHGQ== X-Google-Smtp-Source: ABdhPJyoowUPQmDFu4llPYKbjkkVb3iq/NgCwmOUL6l4PJA5WX11nE+fiyjr4bx7EwbTnwVE7ck8qw== X-Received: by 2002:a17:906:489:: with SMTP id f9mr19691933eja.508.1622708664167; Thu, 03 Jun 2021 01:24:24 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id r12sm1317922edv.82.2021.06.03.01.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 01:24:23 -0700 (PDT) Date: Thu, 3 Jun 2021 10:24:21 +0200 From: Daniel Vetter To: Jason Ekstrand Message-ID: References: <20210602164149.391653-1-jason@jlekstrand.net> <20210602164149.391653-5-jason@jlekstrand.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210602164149.391653-5-jason@jlekstrand.net> X-Operating-System: Linux phenom 5.10.32scarlett+ Subject: Re: [Intel-gfx] [PATCH 4/5] Revert "drm/i915: Propagate errors on awaiting already signaled fences" X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Jason Ekstrand , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jun 02, 2021 at 11:41:48AM -0500, Jason Ekstrand wrote: > This reverts commit 9e31c1fe45d555a948ff66f1f0e3fe1f83ca63f7. Ever > since that commit, we've been having issues where a hang in one client > can propagate to another. In particular, a hang in an app can propagate > to the X server which causes the whole desktop to lock up. I think we need a note to backporters here: "For backporters: Please note that you _must_ have a backport of https://lore.kernel.org/dri-devel/20210602164149.391653-2-jason@jlekstrand.net/ for otherwise backporting just this patch opens up a security bug." Or something like that. -Daniel > Signed-off-by: Jason Ekstrand > Reported-by: Marcin Slusarz > Cc: # v5.6+ > Cc: Jason Ekstrand > Cc: Marcin Slusarz > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3080 > Fixes: 9e31c1fe45d5 ("drm/i915: Propagate errors on awaiting already signaled fences") > Signed-off-by: Daniel Vetter > Reviewed-by: Jon Bloomfield > --- > drivers/gpu/drm/i915/i915_request.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c > index 970d8f4986bbe..b796197c07722 100644 > --- a/drivers/gpu/drm/i915/i915_request.c > +++ b/drivers/gpu/drm/i915/i915_request.c > @@ -1426,10 +1426,8 @@ i915_request_await_execution(struct i915_request *rq, > > do { > fence = *child++; > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { > - i915_sw_fence_set_error_once(&rq->submit, fence->error); > + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) > continue; > - } > > if (fence->context == rq->fence.context) > continue; > @@ -1527,10 +1525,8 @@ i915_request_await_dma_fence(struct i915_request *rq, struct dma_fence *fence) > > do { > fence = *child++; > - if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) { > - i915_sw_fence_set_error_once(&rq->submit, fence->error); > + if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) > continue; > - } > > /* > * Requests on the same timeline are explicitly ordered, along > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx